Repository navigation
[HOLD for payment 2024-08-01] Thread – Join button reappears in header when try to join thread after leave it #45828
Description
Activity
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.Triggered auto assignment to @NikkiWines (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
@bernhardoj @akinwale Seems like this might be related to #45136 maybe we should revert the PR and cover these newly found edge cases
Confirmed that it comes from #45370 as suggested here by reverting it locally.
/cc @dominictb @thesahindia if you can think of a fix. In the meantime I'll prepare a revert CP just in case.
Going to go ahead with the revert for now.
Reacted by Nikki Wines- changed the title
[-]Thread – Join button reappears in header when try to join thread after leave it[/-][+][HOLD for payment 2024-08-01] Thread – Join button reappears in header when try to join thread after leave it[/+]on Jul 25, 2024 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.11-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-08-01. 🎊
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
- [@NikkiWines] The PR that introduced the bug has been identified. Link to the PR:
- [@NikkiWines] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
- [@NikkiWines] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
- [@NikkiWines] Determine if we should create a regression test for this bug.
- [@NikkiWines] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
- [@CortneyOfstad] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
No payment is needed as this was internal and a C+ was not assigned due to comment here. Closing!
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.10-2
Reproducible in staging?: yes
Reproducible in production?: no, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4747620
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause Internal Team
Slack conversation:
Action Performed:
Expected Result:
Join button disappears, user joined to thread
Actual Result:
Join button reappears, user is not joined to thread
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6547693_1721435111628.Join.1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @CortneyOfstad