[HOLD PR #42892][$250] Text pasted from Slack won't send or disappears in NewDot.

@mallenexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.61-5
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1712695994757859

Action Performed:

Scenario 1:

Copy text from from Slack
Paste text in compose box
Tap return

Scenario 2:

Copy text from from Slack
Type > in compose box
Paste text after > (and a space after)
Tap return

Expected Result:

Message is sent

Actual Result:

Scenario 1: Message stays in compose box and won't send. Cursor stays at the beginning of the message
Scenario 2: Only the > part of the message sends.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Recording.2959.mp4

2024-04-09_10-53-38.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01892e3b8e5931a268
Upwork Job ID: 1778891800225918976
Last Price Increase: 2024-04-12
Automatic offers:

jayeshmangwani | Reviewer | 0
kpadmanabhan | Contributor | 0

@slafortune

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@roryabraham

Triggered auto assignment to @roryabraham (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@roryabraham

@roryabraham been discussing here with @thienlnam that this is specific for Slack it seems so we should not have to hold deploy for this bug

@m-natarajan

@m-natarajan can you pls paste the unformatted content of the slack message? initial suspicion is > symbol is treated with a special character when you copy to clipboard.

@brkdavis

📣 @brkdavis! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@kpadmanabhan

OK.. since @kpadmanabhan was hired and invested a non-immaterial amount of work, compensation should be do.
My gut says either 50 or 100%. What do you think @jayeshmangwani and @roryabraham ?

@mallenexpensify

@mallenexpensify Generally, we should have given 100% as the PR was almost in a mergeable state, but since the raised PR had one regression found during testing, I would say 50% compensation should be given.

@jayeshmangwani

Thanks @jayeshmangwani . Does that sound good n' fair to you @kpadmanabhan ?

@mallenexpensify

@mallenexpensify though task was for completing the bug fix, I did a lot more than that following up on other bugs and PRs in the related area. However, I am fine with the suggestion from you and @jayeshmangwani .

Sad that my changes couldn't hit production. Looking forward to that in next proposals.

@kpadmanabhan

I did a lot more than that following up on other bugs and PRs in the related area

@kpadmanabhan if you want to provide links and details to the additional work, it's possible that could influence the compensation amount. We always appreciate contributors monitoring other issues/PRs and chiming in when it's helpful.

@mallenexpensify

@mallenexpensify tagged the wrong contributor 🙂 ; the message was meant for you, @kpadmanabhan.

@kpadmanabhan

@kpadmanabhan if you want to provide links and details to the additional work, it's possible that could influence the compensation amount. We always appreciate contributors monitoring other issues/PRs and chiming in when it's helpful.

thanks @mallenexpensify and @jayeshmangwani.

I am fine with any compensation that Expensify considers fair.
anyhow noting down my contribution for this issue and the issues that I was keeping track of.

addition of unit tests in my PR for this issue, which i do not see covered in any of the merged PRs from others for this issue.

other related issues that i kept track of.

not counting the other proposals that i submitted.

@jayeshmangwani

but since the raised PR had one regression found during testing,

and, from CONTRIBUTING.md

If a PR causes a regression at any point within the regression period (starting when the code is merged and ending 168 hours (that's 7 days) after being deployed to production):

@jayeshmangwani, was the regression found during testing before the code was merged?

Also, @kpadmanabhan , thanks for the breakdown and context.

@jayeshmangwani

@jayeshmangwani, was the regression found during testing before the code was merged?

@mallenexpensify : jayesh found it when everything looked good during final review.
you may refer to this comment and the surrounding comments in the PR.
#41265 (comment)

correct me if i am wrong @jayeshmangwani

@mallenexpensify

was the regression found during testing before the code was merged?

@mallenexpensify Yes, found when testing the PR.

@kpadmanabhan

Since the regression was found before being merged, that would be normal testing. We don't have documentation stating there are penalties for that. Based on that, and @kpadmanabhan 's breakdown above, I think we shoudl compensate 100% here for both @kpadmanabhan and @jayeshmangwani. They were both hired/assigned and started work on the PR.

@kpadmanabhan

Contributor: @kpadmanabhan paid $250 via Upwork
Contributor+: @jayeshmangwani paid $250 via Upwork

Thanks!

@slafortune

@slafortune @roryabraham Be sure to fill out the Contact List!

Navigation Menu

Repository navigation

[HOLD PR #42892][$250] Text pasted from Slack won't send or disappears in NewDot. #39971

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

120 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD PR #42892][$250] Text pasted from Slack won't send or disappears in NewDot. #39971

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 9, 2024

melvin-bot commented on Apr 9, 2024

github-actions commented on Apr 9, 2024

mountiny commented on Apr 9, 2024

brkdavis commented on Apr 9, 2024

melvin-bot commented on Apr 9, 2024

120 remaining items

mallenexpensify commented on Jul 18, 2024

jayeshmangwani commented on Jul 19, 2024

mallenexpensify commented on Jul 20, 2024

kpadmanabhan commented on Jul 20, 2024

mallenexpensify commented on Jul 22, 2024

jayeshmangwani commented on Jul 22, 2024

kpadmanabhan commented on Jul 23, 2024

mallenexpensify commented on Jul 24, 2024

kpadmanabhan commented on Jul 25, 2024

jayeshmangwani commented on Jul 25, 2024

mallenexpensify commented on Jul 25, 2024

mallenexpensify commented on Jul 26, 2024

melvin-bot commented on Jul 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions