[Pay meow][$250] Web - Composer - Cursor positioned at the start if pasting text which contains a new line

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: y
Issue reported by: Applause - Internal Team

Action Performed:

Navigate to staging.new.expensify.com
Open a chat and type a one line text and create an empty new line
Select all using keyboard ctrl + A and cut the text
Paste it inside the compose box

Expected Result:

The cursor gets positioned at the end of the pasted text, no console error

Actual Result:

The cursor gets positioned at the start of the pasted text if the pasted text contains a new empty line, console error is showing

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6481716_1715782332852.bandicam_2024-05-15_17-07-29-894.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cc45b59ee9c4ae02
Upwork Job ID: 1792451156946927616
Last Price Increase: 2024-08-08

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-collect - Release 1

@Christinadobrzyn

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

Very similar to #42112 - asking if the fix will be the same

Proposal

Please re-state the problem that we are trying to solve in this issue.

Web - Composer - Cursor positioned at the start if pasting text which contains a new line

What is the root cause of that problem?

We are setting cursor position in below part when pasting.

App/src/hooks/useHtmlPaste/index.ts

Lines 19 to 20 in fb14d5a

    
           range.setStart(node, node.length); 
        
           range.setEnd(node, node.length);

When pasted text contains empty line, the value of node.length is greater than it's actually length because the length of line break at the end(\n\n) will be caculated as 2.
So console error occurs and cursor is not set because we are trying to set cursor to non-exist position.

What changes do you think we should make in order to solve the problem?

We have to set range with node.length - 1 when it contains empty line at the end.

What alternative solutions did you explore? (Optional)

📣 @moonstar-95515! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Doesn't seem to be related to #42112 as that is resolved. I can still reproduce this - adding external

Job added to Upwork: https://www.upwork.com/jobs/~01cc45b59ee9c4ae02

@rakhaxor

The decision to compensate @rakhaxor is an edge case, based on the fact they were assigned to the issue and hired. It was the responsibility of Expensify to hire/assign. Since this action is considered a source-of-truth and gives the green light for the contributor to invest more time into the issue (assuming compensation), we feel it's fair to compensate. Since their proposal was initially accepted, we decided on 50%.

@moonstar-95515 , your compensation on this issue, and the value associated with it, is completely unrelated to the compensation for @rakhaxor. Please keep in mind our documented code of conduct when communicating with others, both internal and with fellow contributors.

We pride ourselves as a company and as individual employees on our core qualities: Talent, Ambition, & Humility. The environment we have developed uses these qualities to adhere to our two golden rules of Expensify:

Get Shit Done

Don’t Ruin it for Everyone Else

Thanks

@AndrewGable

@AndrewGable, @eVoloshchak, @rakhaxor, @Christinadobrzyn, @moonstar-95515 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@eVoloshchak

Quick follow up - based on a review (as Matt outlined) we are going to continue with this payment summary.

@eVoloshchak can you accept this Upwork offer - https://www.upwork.com/nx/wm/offer/103544327
@rakhaxor can you accept this Upwork offer - https://www.upwork.com/nx/wm/offer/103593092

TY!

@Christinadobrzyn

Hello @Christinadobrzyn! I have accepted the offer on Upwork. Thank you

@Christinadobrzyn

@Christinadobrzyn, declined the Upwork offer, requested the payment on NewDot
Thanks!

@eVoloshchak

Awesome! Thanks! The payment summary is here.

Feel free to submit your NewDot payment @eVoloshchak. Also, I don't see that it was asked but do we need a regression test for this?

@eVoloshchak

$250 approved for @eVoloshchak

@eVoloshchak

@eVoloshchak can you let us know about a regression test? Then I think this is good to close!

Yes, a regression test would be useful and easy to perform

Regression Test Proposal

Navigate to staging.new.expensify.com
Open a chat and type a one-line text and create a few empty lines

test

Select all using keyboard ctrl + A and cut the text
Paste it inside the composer
Verify the cursor is positioned at the end of the pasted text

Do we agree 👍 or 👎

Regression test is created - https://github.com/Expensify/Expensify/issues/422290

Closing!

@AndrewGable

@AndrewGable @Christinadobrzyn Be sure to fill out the Contact List!

Navigation Menu

Repository navigation

[Pay meow][$250] Web - Composer - Cursor positioned at the start if pasting text which contains a new line #42216

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

82 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	range.setStart(node, node.length);
	range.setEnd(node, node.length);

[Pay meow][$250] Web - Composer - Cursor positioned at the start if pasting text which contains a new line #42216

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on May 15, 2024

kbecciv commented on May 15, 2024

kbecciv commented on May 15, 2024

Christinadobrzyn commented on May 16, 2024

MOONSTAR-TOP-DEV commented on May 16, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on May 16, 2024

Christinadobrzyn commented on May 20, 2024

melvin-bot commented on May 20, 2024

82 remaining items

mallenexpensify commented on Aug 19, 2024

melvin-bot commented on Aug 19, 2024

Christinadobrzyn commented on Aug 19, 2024

rakhaxor commented on Aug 20, 2024

eVoloshchak commented on Aug 20, 2024

Christinadobrzyn commented on Aug 20, 2024

JmillsExpensify commented on Aug 20, 2024

Christinadobrzyn commented on Aug 20, 2024

eVoloshchak commented on Aug 21, 2024

Christinadobrzyn commented on Aug 21, 2024

melvin-bot commented on Aug 21, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions