Skip to content

[HOLD for payment 2024-04-25] [$250] Web - IOU - User is navigated back to the same IOU details report conversation #39613

Closed

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.60-1
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition: Tax feature should be enabled on the workspace

  1. Navigate to a workspace chat
  2. Create a workspace with 5% rate
  3. Click on 'IOU preview component'
  4. Click on 'Tax' filed
  5. Change value to 'Tax exempt'
  6. Click on 'From' link

Expected Result:

User should be navigated to main report

Actual Result:

User is navigated back to the same IOU details report conversation

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6437922_1712233910382.Screen_Recording_2024-04-04_at_11.09.15_in_the_morning.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014d0fba2ba353ff02
  • Upwork Job ID: 1777307266227351552
  • Last Price Increase: 2024-04-08

Activity

  1. melvin-bot commented on Apr 4, 2024

    @melvin-bot

    Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. github-actions commented on Apr 4, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. changed the title [-]IOU report - User is navigated back to the same IOU details report conversation[/-] [+]Web - IOU - User is navigated back to the same IOU details report conversation[/+] on Apr 4, 2024
  4. kbecciv commented on Apr 4, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave-collect - Release 1

  5. stitesExpensify commented on Apr 4, 2024

    @stitesExpensify
    Contributor

    Most likely related to #33927

  6. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Apr 4, 2024
  7. MonilBhavsar commented on Apr 4, 2024

    @MonilBhavsar
    Contributor

    Demoting from blocker as not a critical issue and only happens with tax rate field where component is getting remounted. cc @teeneto

  8. self-assigned this
    on Apr 4, 2024
  9. teneeto commented on Apr 5, 2024

    @teneeto
    Contributor

    Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.

  10. 14 remaining items

  11. MonilBhavsar commented on Apr 8, 2024

    @MonilBhavsar
    Contributor

    @ikevin127 the PR is ready for review and test #39723

  12. ikevin127 commented on Apr 8, 2024

    @ikevin127
    Contributor

    @MonilBhavsar I'm on it!

  13. MonilBhavsar commented on Apr 8, 2024

    @MonilBhavsar
    Contributor

    Thanks!

    First, I realised that most logic and edit money request pages/components which where initially handled within the EditRequestPage.js where removed. Instead all where moved to there respective IOURequestStep... page and then the routes where changed to accommodate both create and edit actions and then all logic where handled in one page.
    In our case, we had our pages still residing in EditRequestPage.js which caused those route change behaviour and also because we used Navigation.dismiss() (edited)

    I figured out aligning with the current changes would make things better and my guess was right.

    Here is the explanation from @teneeto for the refactor change. If you have any questions, let's chat here!

  14. melvin-bot commented on Apr 10, 2024

    @melvin-bot

    ⚠️ Looks like this issue was linked to a Deploy Blocker here

    If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

    If a regression has occurred and you are the assigned CM follow the instructions here.

    If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

  15. melvin-bot commented on Apr 15, 2024

    @melvin-bot

    @teneeto, @MonilBhavsar, @ikevin127 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  16. melvin-bot commented on Apr 17, 2024

    @melvin-bot

    @teneeto, @MonilBhavsar, @ikevin127 Huh... This is 4 days overdue. Who can take care of this?

  17. MonilBhavsar commented on Apr 17, 2024

    @MonilBhavsar
    Contributor

    Closing. Payment is handled in #39823

  18. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Apr 18, 2024
  19. changed the title [-][$250] Web - IOU - User is navigated back to the same IOU details report conversation[/-] [+][HOLD for payment 2024-04-25] [$250] Web - IOU - User is navigated back to the same IOU details report conversation[/+] on Apr 18, 2024
  20. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  21. melvin-bot commented on Apr 18, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-04-25. 🎊

    For reference, here are some details about the assignees on this issue:

    • @teneeto does not require payment (Contractor)
    • @ikevin127 requires payment (Needs manual offer from BZ)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionEngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions