You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-04-25] [$250] Web - IOU - User is navigated back to the same IOU details report conversation #39613
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]IOU report - User is navigated back to the same IOU details report conversation[/-][+]Web - IOU - User is navigated back to the same IOU details report conversation[/+]on Apr 4, 2024
First, I realised that most logic and edit money request pages/components which where initially handled within the EditRequestPage.js where removed. Instead all where moved to there respective IOURequestStep... page and then the routes where changed to accommodate both create and edit actions and then all logic where handled in one page.
In our case, we had our pages still residing in EditRequestPage.js which caused those route change behaviour and also because we used Navigation.dismiss() (edited)
I figured out aligning with the current changes would make things better and my guess was right.
Here is the explanation from @teneeto for the refactor change. If you have any questions, let's chat here!
changed the title [-][$250] Web - IOU - User is navigated back to the same IOU details report conversation[/-][+][HOLD for payment 2024-04-25] [$250] Web - IOU - User is navigated back to the same IOU details report conversation[/+]on Apr 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
melvin-bot commentedon Apr 4, 2024
Triggered auto assignment to @stitesExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 4, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
[-]IOU report - User is navigated back to the same IOU details report conversation[/-][+]Web - IOU - User is navigated back to the same IOU details report conversation[/+]kbecciv commentedon Apr 4, 2024
We think that this bug might be related to #wave-collect - Release 1
stitesExpensify commentedon Apr 4, 2024
Most likely related to #33927
MonilBhavsar commentedon Apr 4, 2024
Demoting from blocker as not a critical issue and only happens with tax rate field where component is getting remounted. cc @teeneto
teneeto commentedon Apr 5, 2024
Hi, I'm Eto from Callstack - expert contributor group - and I would like to take care of this issue.
14 remaining items
MonilBhavsar commentedon Apr 8, 2024
@ikevin127 the PR is ready for review and test #39723
ikevin127 commentedon Apr 8, 2024
@MonilBhavsar I'm on it!
MonilBhavsar commentedon Apr 8, 2024
Thanks!
Here is the explanation from @teneeto for the refactor change. If you have any questions, let's chat here!
melvin-bot commentedon Apr 10, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
melvin-bot commentedon Apr 15, 2024
@teneeto, @MonilBhavsar, @ikevin127 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
melvin-bot commentedon Apr 17, 2024
@teneeto, @MonilBhavsar, @ikevin127 Huh... This is 4 days overdue. Who can take care of this?
MonilBhavsar commentedon Apr 17, 2024
Closing. Payment is handled in #39823
[-][$250] Web - IOU - User is navigated back to the same IOU details report conversation[/-][+][HOLD for payment 2024-04-25] [$250] Web - IOU - User is navigated back to the same IOU details report conversation[/+]melvin-bot commentedon Apr 18, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-25. 🎊
For reference, here are some details about the assignees on this issue: