Repository navigation
[HOLD for payment 2024-04-25] Tax - Maximum tax amount is 0 error msg on updating currency for non-default tax rate #40036
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.62-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+1088ck@applause.expensifail.com
Issue reported by: Applause - Internal Team
Issue found when executing PR #39562
Action Performed:
Precondition : Add tax rates for any WS apart from the default one
- Tap on FAB button >> Request money
- Select Manual option & enter amount
- Select workspace with enabled taxes
- On the confirm screen choose a different tax rate
- Click on Tax amount option
- Change currency to a different option & tap on Save button (Note: Error message appears)
- Change back currency to USD & tap on save button
Expected Result:
No error message appear & tax amount get saved on changing currency for a non-default rate
Actual Result:
Maximum tax amount is 0 error msg on updating currency for non-default tax rate
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Activity
melvin-bot commentedon Apr 10, 2024
Triggered auto assignment to @luacmartins (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Apr 10, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Apr 10, 2024
@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Apr 10, 2024
We think that this bug might be related to #wave-collect - Release 1
mountiny commentedon Apr 10, 2024
@akinwale @ZhenjaHorbach can you please check as this might be coming from your PR. Thanks!
ZhenjaHorbach commentedon Apr 10, 2024
I'm not sure if this is related to our PR)
Since in my PR we did not change any logic
We simply deleted unnecessary routes and component that were no longer used)
But I'll try to help and find where is the problem)
luacmartins commentedon Apr 10, 2024
I can reproduce on staging, but not locally anymore
luacmartins commentedon Apr 10, 2024
Hmm it only happens with certain currencies
luacmartins commentedon Apr 10, 2024
I think it might be coming from #39723
luacmartins commentedon Apr 10, 2024
Yea, found the cause
luacmartins commentedon Apr 10, 2024
Left a comment here - #39723 (comment)
1 remaining item
luacmartins commentedon Apr 10, 2024
I put up a PR, but I'm unsure if the logic makes sense. Asked the original authors for a review
MonilBhavsar commentedon Apr 11, 2024
CP'ing here https://expensify.slack.com/archives/C07J32337/p1712828884534849
MonilBhavsar commentedon Apr 11, 2024
Works fine!
Screen.Recording.2024-04-11.at.5.54.09.PM.mov
[-]Tax - Maximum tax amount is 0 error msg on updating currency for non-default tax rate[/-][+][HOLD for payment 2024-04-25] Tax - Maximum tax amount is 0 error msg on updating currency for non-default tax rate[/+]melvin-bot commentedon Apr 18, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.62-17 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-25. 🎊
luacmartins commentedon Apr 19, 2024
This was fixed internally and there was no C+ review, so we can close this.