[HOLD] IOU - Missing Hold request, Replace and Delete receipt option when there is one IOU request

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.59-3
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to staging.new.expensify.com
Go to 1:1 DM with user that has no unsettled IOU.
Create a manual request with receipt.
Click on the IOU preview.
Click 3-dot menu.

Expected Result:

Hold request option will be present.

Actual Result:

Hold request option is not present.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6436285_1712120121764.bandicam_2024-04-03_12-49-20-306.mp4

View all open jobs on GitHub

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@arosiclair

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hold request, Replace and Delete receipt option are missing when there is only one IOU request.

What is the root cause of that problem?

We don't add hold or uphold option into three-dot menu items of MoneyReportHeader

App/src/components/MoneyReportHeader.tsx

Line 164 in ebc8de8

if (canDeleteRequest && !isEmptyObject(transactionThreadReport)) {

For three-dot in receipt, this is dupe of #39436 (comment)

What changes do you think we should make in order to solve the problem?

We should use the same approach in MoneyRequestHeader to add hold or unhold option to three-dot menu item.

App/src/components/MoneyRequestHeader.tsx

Line 125 in ebc8de8

if (!isOnHold && (isRequestIOU || canModifyStatus)) {

App/src/components/MoneyRequestHeader.tsx

Line 118 in ebc8de8

if (isOnHold && (isHoldCreator || (!isRequestIOU && canModifyStatus))) {

App/src/components/MoneyReportHeader.tsx

Line 164 in ebc8de8

if (canDeleteRequest && !isEmptyObject(transactionThreadReport)) {

What alternative solutions did you explore? (Optional)

NA

@stephanieelliott

@stephanieelliott I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #collect project.

I wouldn't expect Hold request to be in the 3-dot menu for the receipt image. I would expect Replace and Delete though. If we are going to address Replace and Delete in #39436, then I think we can close this out.

Still held

I'm gonna put a hold on this since there's no UI to show which expenses are held.

Still held

Still holding

We have a design for the UI pattern now, this scenario has been incorporated into the design: #39989

Navigation Menu

Repository navigation

[HOLD] IOU - Missing Hold request, Replace and Delete receipt option when there is one IOU request #39491

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

25 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD] IOU - Missing Hold request, Replace and Delete receipt option when there is one IOU request #39491

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Apr 3, 2024

melvin-bot commented on Apr 3, 2024

github-actions commented on Apr 3, 2024

nkdengineer commented on Apr 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

izarutskaya commented on Apr 3, 2024

izarutskaya commented on Apr 3, 2024

arosiclair commented on Apr 3, 2024

25 remaining items

stephanieelliott commented on May 3, 2024

stephanieelliott commented on May 16, 2024

stephanieelliott commented on May 25, 2024

stephanieelliott commented on Jun 4, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions