Repository navigation
[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] [$250] [One expense reports] Update the UI for Held transactions in Single Transaction Report Preview / MoneyRequestAction #39989
Description
Slack discussion here
Goal
Expand upon the new UI pattern introduced as part of the Wave 5/6: Update how we display / report expenses doc to include reports where all transactions that are on HOLD (including reports with only one transaction where we show only one expense) using the copy "All requests were put on hold. Review the comments for next steps."
Note 1: that a report could be in two states simultaneously: the receipt could be scanning and the transaction(s) on the report could be on hold
Note 2: One-transaction reports currently do not show an option to hold an expense, but this is easily rectified by including the logic from here in src/components/MoneyReportHeader.tsx
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~017ed767635e9fa640
- Upwork Job ID: 1777965895318855680
- Last Price Increase: 2024-05-10
- Automatic offers:
- dukenv0307 | Reviewer | 0
- tienifr | Contributor | 0
Activity
melvin-bot commentedon Apr 10, 2024
Job added to Upwork: https://www.upwork.com/jobs/~017ed767635e9fa640
melvin-bot commentedon Apr 10, 2024
Triggered auto assignment to Contributor Plus for review of internal employee PR - @dukenv0307 (
Internal)NikkiWines commentedon Apr 10, 2024
Adding design so we can get some mocks of how this should ideally look 🙇
melvin-bot commentedon Apr 10, 2024
Triggered auto assignment to @shawnborton (
Design), see these Stack Overflow questions for more details.shawnborton commentedon Apr 10, 2024
My understanding was that this isn't possible for a one-expense report: you can't hold a scanning receipt. Is that right @trjExpensify @JmillsExpensify ?
trjExpensify commentedon Apr 10, 2024
Doesn't look like we block the
Hold requestaction on a scanning receipt today, so we double up:.. but I think it makes sense to not allow it, because we're going to apply the "pending" pattern to a scanning receipt anyway and it can't be approved/paid. It'll be moved to another report if that action is taken.
shawnborton commentedon Apr 10, 2024
I believe @dragnoir is in the process of fixing that. @dragnoir can you provide an update?
shawnborton commentedon Apr 10, 2024
In terms of the banner style, I posted to Slack but I think it might look something like this:
JmillsExpensify commentedon Apr 10, 2024
Can't think of a reason why we'd block holding a scanning receipt, though I'm not super passionate.
shawnborton commentedon Apr 10, 2024
Ah, you said the opposite over here:
96 remaining items
[-][HOLD for payment 2024-07-10] [$250] [One expense reports] Update the UI for Held transactions in Single Transaction Report Preview / MoneyRequestAction[/-][+][HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] [$250] [One expense reports] Update the UI for Held transactions in Single Transaction Report Preview / MoneyRequestAction[/+]melvin-bot commentedon Jul 10, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 10, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] [$250] [One expense reports] Update the UI for Held transactions in Single Transaction Report Preview / MoneyRequestAction[/-][+][HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [HOLD for payment 2024-07-10] [$250] [One expense reports] Update the UI for Held transactions in Single Transaction Report Preview / MoneyRequestAction[/+]melvin-bot commentedon Jul 15, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-07-22. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jul 15, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
JmillsExpensify commentedon Jul 23, 2024
@alexpensify are we paying this PR via your issue or this one?
alexpensify commentedon Jul 23, 2024
I started the payment process in my GH. We can combine the two since it was one PR.
JmillsExpensify commentedon Jul 24, 2024
Ok cool, so then I'll just close this one out. Someone please comment if you disagree.