Skip to content

[$500] Share code - Tapping reply in thread share code URL directs to page loading infinitely #39415

Closed
Closed
[$500] Share code - Tapping reply in thread share code URL directs to page loading infinitely#39415
Assignees
slafortunehungvu193cristipavallaurenreidexpensifynkdengineer
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Description

@lanitochka17
lanitochka17
opened on Apr 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.59
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Open a report
  3. Send a message
  4. Long press the message and select reply in thread
  5. Send a message
  6. Tap header
  7. Copy share code
  8. Login app with different account
  9. Open a report
  10. Paste copied URL and send the message
  11. Tap URL link

Expected Result:

Tapping reply in thread share code URL must not direct to page loading infinitely

Actual Result:

Tapping reply in thread share code URL directs to page loading infinitely

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435622_1712066286508.repl.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~012acca0fb0a485001
  • Upwork Job ID: 1775461423696654336
  • Last Price Increase: 2024-04-03
  • Automatic offers:
    • hungvu193 | Reviewer | 0
Issue OwnerCurrent Issue Owner: @laurenreidexpensify

Activity

  1. lanitochka17
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Apr 2, 2024

  2. melvin-bot commented on Apr 2, 2024

    @melvin-bot
    melvin-botBot
    on Apr 2, 2024 – with Melvin Bot

    Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. melvin-bot
    assigned
    laurenreidexpensify
    on Apr 2, 2024

  4. lanitochka17 commented on Apr 2, 2024

    @lanitochka17
    lanitochka17
    on Apr 2, 2024
    Author

    We think that this bug might be related to #vip-vsp

  5. lanitochka17 commented on Apr 2, 2024

    @lanitochka17
    lanitochka17
    on Apr 2, 2024
    Author

    @laurenreidexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  6. nkdengineer commented on Apr 2, 2024

    @nkdengineer
    nkdengineer
    on Apr 2, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Tapping reply in thread share code URL directs to page loading infinitely

    What is the root cause of that problem?

    We wrap the condition to show not found page with the check !shouldShowSkeleton so the not found page will not show if shouldShowSkeleton is true.

    App/src/pages/home/ReportScreen.tsx

    Line 363 in c550afd

    !shouldShowSkeleton &&

    When we open the report which we cannot access, OpenReport API only returns the errorFields so isCurrentReportLoadedFromOnyx is false that leads shouldShowSkeleton is always true and then infinite skeleton appears

    App/src/pages/home/ReportScreen.tsx

    Line 346 in c550afd

    const isCurrentReportLoadedFromOnyx = useMemo((): boolean => {

    What changes do you think we should make in order to solve the problem?

    We should remove !shouldShowSkeleton from this check

    App/src/pages/home/ReportScreen.tsx

    Line 363 in c550afd

    !shouldShowSkeleton &&

    and to fix the issue not found page appears briefly after signing, we can replace reportActionIDFromRoute here to the current reportID param of the route

    currentReportIDFormRoute = route.params?.reportID
(!! currentReportIDFormRoute && !ReportUtils.isValidReportIDFromPath(currentReportIDFormRoute))),

    App/src/pages/home/ReportScreen.tsx

    Line 371 in c550afd

    (!!reportIDFromRoute && !ReportUtils.isValidReportIDFromPath(reportIDFromRoute))),

    What alternative solutions did you explore? (Optional)

    NA

  7. laurenreidexpensify
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Apr 3, 2024
  8. melvin-bot
    changed the title [-]Share code - Tapping reply in thread share code URL directs to page loading infinitely[/-] [+][$500] Share code - Tapping reply in thread share code URL directs to page loading infinitely[/+] on Apr 3, 2024

  9. melvin-bot commented on Apr 3, 2024

    @melvin-bot
    melvin-botBot
    on Apr 3, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~012acca0fb0a485001

  10. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Apr 3, 2024
  11. melvin-bot
    assigned
    hungvu193
    on Apr 3, 2024

  12. melvin-bot commented on Apr 3, 2024

    @melvin-bot
    melvin-botBot
    on Apr 3, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

  13. laurenreidexpensify
    added this to [#whatsnext] #vip-vsbon Apr 3, 2024

  14. hungvu193 commented on Apr 4, 2024

    @hungvu193
    hungvu193
    on Apr 4, 2024
    Contributor

    It was originally fixed here, however it caused this DB, so it was revert here

    Ideally, we should implement #38955 again with the suggestion fix in this discussion

    cc @roryabraham @ishpaul777

  15. 33 remaining items

  16. laurenreidexpensify commented on Apr 30, 2024

    @laurenreidexpensify
    laurenreidexpensify
    on Apr 30, 2024
    Contributor

    Payment Summary:

    C+ @hungvu193 $500 - payment issued in upwork
    Contributor @nkdengineer $500 - please accept offer in upwork

  17. laurenreidexpensify commented on Apr 30, 2024

    @laurenreidexpensify
    laurenreidexpensify
    on Apr 30, 2024
    Contributor

    @hungvu193 pls advise on any regression steps etc here thanks

  18. hungvu193 commented on May 2, 2024

    @hungvu193
    hungvu193
    on May 2, 2024
    Contributor

    As I mentioned above:

    It was originally fixed here, however it caused this DB, so it was revert here

    Regression test:

    1. Open a report
    2. Send an invalid report url and click on it.
    3. Verify that NotFoundPage will show.

    Do we 👍 or 👎 ?

  19. laurenreidexpensify
    closed this as completedon May 2, 2024

  20. nkdengineer commented on May 2, 2024

    @nkdengineer
    nkdengineer
    on May 2, 2024
    Contributor

    Contributor @nkdengineer $500 - please accept offer in upwork

    @laurenreidexpensify Offer accepted, thanks!

  21. nkdengineer commented on Jul 1, 2024

    @nkdengineer
    nkdengineer
    on Jul 1, 2024
    Contributor

    Sorry @laurenreidexpensify It seems I wasn't paid here, could you please reopen the issue to help with this?

    TIA

  22. cristipaval
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jul 1, 2024

  23. melvin-bot commented on Jul 1, 2024

    @melvin-bot
    melvin-botBot
    on Jul 1, 2024 – with Melvin Bot

    Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  24. melvin-bot
    assigned
    slafortune
    on Jul 1, 2024

  25. cristipaval commented on Jul 1, 2024

    @cristipaval
    cristipaval
    on Jul 1, 2024
    Contributor

    Applied the Bug label again to get another bug-zero member, since @laurenreidexpensify is OOO

  26. cristipaval
    reopened this on Jul 1, 2024

  27. cristipaval commented on Jul 1, 2024

    @cristipaval
    cristipaval
    on Jul 1, 2024
    Contributor

    @slafortune could you please verify whether @nkdengineer was paid? 🙏

  28. slafortune commented on Jul 1, 2024

    @slafortune
    slafortune
    on Jul 1, 2024
    Contributor

    @nkdengineer sorry that happened! Paid now ✅

  29. slafortune
    closed this as completedon Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorReviewingHas a PR in review

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions