Repository navigation
[HOLD for payment 2024-04-09] [$500] Infinite skeleton loader appears when manually changing URL to an invalid report #39029
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.56-6
Reproducible in staging?: yes
Reproducible in production?: not currently, but we're not treating this as a blocker so it will be soon.
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1711496796142069?thread_ts=1711394610.825829&cid=C01GTK53T8Q
Action Performed:
- Open any chat in NewDot web
- Manually change the reportID in the URL to a random number (not the ID of a report you have access to).
- Alternatively, manually change the reportID in the URL to 0. It's the same bug.
Expected Result:
After a brief loading period, you should see a 404 "not found" page.
Actual Result:
you see an infinite skeleton indicator
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~0113ef219591bbf681
- Upwork Job ID: 1772775589885202432
- Last Price Increase: 2024-03-27
- Automatic offers:
- ishpaul777 | Reviewer | 0
- alitoshmatov | Contributor | 0
Activity
[-]Infinite skeleton loader appears when manually changing URL to an invalid report[/-][+][$500] Infinite skeleton loader appears when manually changing URL to an invalid report[/+]melvin-bot commentedon Mar 27, 2024
Job added to Upwork: https://www.upwork.com/jobs/~0113ef219591bbf681
melvin-bot commentedon Mar 27, 2024
Current assignee @ishpaul777 is eligible for the External assigner, not assigning anyone new.
melvin-bot commentedon Mar 27, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.roryabraham commentedon Mar 27, 2024
no help needed here, @ishpaul777 is going to complete the PR and I will act as C+ and reviewer
roryabraham commentedon Mar 27, 2024
also, no additional payment needs to be due here, because this was technically a regression from Comment Linking.
ishpaul777 commentedon Mar 27, 2024
PR is ready ☝️ @roryabraham
12 remaining items
roryabraham commentedon Mar 31, 2024
PR was merged, closing this out since no additional payments are due
melvin-bot commentedon Apr 1, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
[-][$500] Infinite skeleton loader appears when manually changing URL to an invalid report[/-][+][HOLD for payment 2024-04-09] [$500] Infinite skeleton loader appears when manually changing URL to an invalid report[/+]melvin-bot commentedon Apr 2, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Apr 2, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-04-09. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Apr 2, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
cristipaval commentedon Apr 5, 2024
The fix for this issue was reverted, correct? Should we reopen it?
shahinyan11 commentedon Apr 5, 2024
I had a proposal, but I deleted it because the issue was assigned to another contributor. Does it make sense to publish my proposal again ?
roryabraham commentedon Apr 15, 2024
requested retest: https://expensify.slack.com/archives/C9YU7BX5M/p1713202486899949
kavimuru commentedon Apr 15, 2024
Issue reproduced
Recording.809.mp4
RPReplay_Final1713204176.MP4
Record_2024-04-15-20-55-58.mp4