Repository navigation
HIGH [$750]: Clean up the payment options on Pay button in New Dot #36301
Description
Activity
Triggered auto assignment to @joekaufmanexpensify (
NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.Let's run with this issue!
Let's hunt down proposals @joekaufmanexpensify 🦾
177 remaining items
Going to bring next steps to slack very soon.
- Reacted by Brandon Henry
Okay, we discussed this internally and here's where we landed. We're going to:
- Pay out the fully bounty here to both the @brandonhenry and @allroundexperts. A lot of work went into this one, and in hindsight, this was a much more complex change than initially described in the OP of the issue. Any issues with the implementation would have likely been obviated had we designed this most holistically, rather than going straight to a GH issue.
- Close the GH issue.
- Take a fresh look at this internally, with a full design doc to make sure we handle all of the permutations of the various impacted flows before moving to implementation.
LMK if anyone has questions on that. Otherwise will tackle the payment steps later today!
Payment summary here:
- @brandonhenry - $750 for PR via Upwork.
- @allroundexperts - $750 for C+ via NewDot.
@brandonhenry offer for $750 sent via Upwork
Reacted by Brandon Henry@allroundexperts you're good to request payment here
@joekaufmanexpensify thank you!!
@brandonhenry $750 sent and contract ended!
Upwork job closed.
Closing this one out as all that's left is for @allroundexperts to request payment in Newdot. We'll be continuing discussion on the longer term solution for this in Slack!
Reacted by Brandon Henry$750 approved for @allroundexperts
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v1.4.39-7
Reproducible in staging?: Y
Reproducible in production?: Y
Expensify/Expensify Issue URL: #33967
Issue reported by: @anmurali
Slack conversation: NA -
Action Performed:
Expected Result:
The same options should be presented when clicking "Pay with Expensify" or the “⌄” down chevron beside it.
This is the new design we want to implement lifted from #33967:
Actual Result:
Two different sets of options are presented to the user:
A:
B:
Workaround:
None
Platforms:
Which of our officially supported platforms is this issue occurring on?
View all open jobs on GitHub
Upwork Automation - Do Not Edit