Repository navigation
Clean up the payment options on Pay button in New Dot #33967
Description
Problem:
The Pay button in New Dot has seemingly two sets of options
Pressing the button brings up payment options
Pressing on the drop down brings up options to pay elsewhere
This UX is pretty confusing.
Solution:
Pull all the options into one single dropdown labeled Pay <currency><amount>, which when pressed opens for the user to choose:
Pay with business bank account
Pay with personal bank account
Pay with debit card
Pay elsewhere
- Let's remember payment preference based on the first payment by request type. E.g. IOUs vs Expenses.
Said another way, if you paid an IOU using a debit card, then next time you pay an IOU, unless you pressed on the down caret (dropdown), we assume you mean the same payment device and process the payment with the debit card. But if you then pay an expense in a workspace, we don't assume but ask you to choose a payment method.
- When defaulting payment method for expenses, use the workspace default if one is set in workspace settings.
If there is a default at the workspace level, and the admin has access to that, use that.
- When defaulting payment method for expenses, make it workspace specific.
Said another way, if you pay an expense on workspace A, we default you to that payment device the next time (unless you press the dropdown). But then if you go to pay an expense on workspace B for the first time, we do not assume.
Activity
melvin-bot commentedon Jan 4, 2024
Triggered auto assignment to @yuwenmemon (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.yuwenmemon commentedon Jan 4, 2024
Would this be the same for all admins on the workspace? Or would it be unique per admin?
yuwenmemon commentedon Jan 5, 2024
Oh, one more question - let's say you haven't paid using any of the options before (this is your first time paying) what do we do when you click the left side of the button? Do we show you a dropdown or do we default to some payment method?
anmurali commentedon Jan 5, 2024
We show you a dropdown
So in Classic, policies have a default reimbursement account set in their policy NVPs. We only show the
Reimbursebutton to admins with access to that BBA (or a copy of that BBA). In New Dot, this behavior is totally different and @luacmartins has a GH to refactor that. Once that's done, we need to figure out what changes we need to make so ND behaves like Classic as I just described, for workspace defaulted BBAs. More on this here, in Slackyuwenmemon commentedon Jan 8, 2024
@luacmartins do you know if once that's done, all admins will have access to the default reimbursement account? Or, if not, what will admins who don't have access to the default reimbursement account be able to see/do?
luacmartins commentedon Jan 8, 2024
@yuwenmemon they should have access yea. That issue aims to make storing bank accounts in NewDot consistent with OldDot, so instead of storing the bank account in the
FREE_PLAN_BANK_ACCOUNT_IDNVP, we'd store it in the workspace NVP.tgolen commentedon Jan 17, 2024
I talked with @marcaaron on Slack and we decided to put this into the Wave9 unassigned bucket. I was able to make a little progress on it, so I am leaving a draft PR behind in hopes that it might be useful for whoever picks this up next. The PR contains:
Pay <formattedamount>I left off trying to figure out what to do with the KYCPaywall and how that works... I'm not sure what needs to happen with it.
#34689
anmurali commentedon Jan 26, 2024
@tgolen
I don't quite get this comment. We are just cleaning up the dropdown options such that there's one single menu of payment options when you press
Pay-- we're not actually changing the behavior when you selectPay with Expensify, so why would you need to figure this out?tgolen commentedon Jan 29, 2024
There are multiple sets of options as mentioned in the original description. One set of options is in front of the KYCPaywall (pay with expensify, pay elsewhere), and one set of options is behind the KYCPaywall (bank account, personal bank account, debit card). In order to have all options in a single dropdown, then the way the dropdown interacts with the KYCPaywall needs to be refactored.
MitchExpensify commentedon Feb 14, 2024
Closing in favor of: #36301