Repository navigation
Deploy Checklist: New Expensify 2024-02-08 #36168
Description
Release Version: 1.4.39-8
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [TS migration] Migrate 'MoneyRequestHeader.js' component to TypeScript #34106
- fix: unify TBD-related logic for Distance requests #34135
- 33546 visual viewport deplay #34254
- [No QA] Create Automation for when main fail #34262
- [TS Migration] Migrate FlagCommentPage #34734
- [TS migration] Migrate 'WorkspaceInitial' page to TypeScript #34893
- feat: add additional full screen engagement modal to NewDot #35019
- Fix/34609: Remove old description page #35137
- Delete docs/articles/expensify-classic/getting-started/Using-The-App.md #35191
- 26401 avoid scroll on virtual viewport #35256
- [No QA] [TS migration] Migrate 'Jest' files to TypeScript #35316
- Grey out report preview and IOU report's header when paying request offline #35456
- [No QA] [TS migration] Migrate 'react-native-dev-menu.js' mock to TypeScript #35466
- Hide approved button if report on policy that's on "instant submit" and "Submit and closed" mode #35470
- [No QA] [TS migration] Migrate 'react-freeze.js' mock to TypeScript #35474
- [TS migration] Migrate @react-native-firebase/perf.js mock #35485
- [No QA][TS migration] Migrate @react-native-firebase/crashlytics mock #35542
- [Update Account Settings] Header: icons, height, and font changes #35564
- Update account settings/profile #35662
- Don't allow employee to delete submitted request #35744
- Live Markdown Preview for web #35837
- Fix/34546: Remove Zoom and Googel Meet Feature #35844
- Fix doing text selection on money request amount input swipes the tab #35875
- Fix workspace detail page is open when clicking on the 3-dots popover #35891
- Fix setting tag for split requests #35913
- [No QA] Add errors to Category type #35917
- [NoQA] e2e tests: improve logging in error case #35985
- onStartReached fix #35987
- [NoQA] Skip the SearchPage test until its refactored #35992
- [NO QA] Update AdHoc provision profiles with new device #35995
- [NoQA] Post slack message when e2e tests fail or a regression has been detected #36004
- [NoQA] e2e tests: continue when test is hanging #36025
- Web Only - Remove "free" marketing copy from meta tags #36029
- [No QA] Fix permission error for assigning the new issue for main failure notification #36042
- Update redirects.csv #36052
- Style fix on empty receipt state component #36076
- fix: add page theme for onboard engagement screen root #36144
- Update
@expensify/react-native-live-markdownto 0.1.15 to fix iOS build issue #36194 - Revert "Live Markdown Preview for web" #36197
- Revert "Fix doing text selection on money request amount input swipes the tab" #36282
- [CP Staging] Dismiss onboard flow when selecting option #36283
- [CP Staging] Remove
backTofor money request view #36287 - [CP Staging] Patch welcome logic so that we do not get redirected to the workspace chat #36289
- [CP Staging] Add nav backup back so we can CP to staging #36329
Deploy Blockers:
- [$500] [HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] Request Money - The close button linked to "Request money. Get $250" is not functioning #36032
- [HOLD for payment 2024-02-20] [HOLD for payment 2024-02-19] [HOLD for payment 2024-02-15] [$500] Camera doesn't load when trying to smartscan a receipt #36098
- [HOLD https://github.com/Expensify/react-native-live-markdown/pull/175]Web - Composer - Composer is highlighted but there is no Insertion Pointer ( | ) in composer #36172
- Comment - Pressing up key doesn't open editing composer on owned message #36173
- [$500] IOU - Composer is hidden when opening Distance IOU reports details page #36174
- Chat - To enter link name in multi line, tapping enter key changes link to text #36180
- mWeb - Settings – Banner in About, Preference and Security is partly visible when open it Offline #36183
- Web - IOU - Wrong values for Amount and Total fields in Offline #36184
- [$500] Unable to paste image in the composer with a message text #36185
- [$500] Composer - Insertion pointer jumps to the end when entering emoji in the middle of message #36199
- [HOLD https://github.com/Expensify/react-native-live-markdown/pull/175][$500] Highlight applied on editing and main composer #36200
- [$500] IOU - "Missing Tag" error is not display on Admin's side #36201
- [HOLD E/E #359760] [$500] No "Hold Request" and "Add a receipt" option on workspace expense report as Admin #36202
- [$500] No "Delete Request" and "Add a receipt" option on workspace expense report as Admin #36215
- [$500] Android - Chat - App crashes when pasting text after returning from IOU details page #36217
- [$500] IOU - Save button does not save and return to details page, only dismisses keyboard #36218
- Chat - Preview shows | > | > | when adding multiple > in the composer #36227
- Android - Request Money - Unable to select amount numbers on the Request Money page for Pixel device #36230
- Wokspace - WS background is now white and shows sharp corners #36246
- Composer - Email is not turned to a clickable link, and GitHub link is not parsed to number #36253
- [HOLD #36071][$500] Chat - Chat is partially scrolled down when editing message #36254
- [$500] Deleted IOU on Empoyee's Workspace chat shows "Currency 0.00" on IOU Card #36260
- [$500] Theme - "Security" and "Preferences" title is black in dark-colored background in light mode #36263
- [HOLD for payment 2024-02-20] Login - Welcome modal is not dismissed after selecting an option #36265
- [$500] Chat - Text is always pasted as plain text when editing messages #36268
- [HOLD for payment 2024-02-20] [HOLD for payment 2024-02-19] [$500] Workspace - Creation of Free WS in OD by new acc doesn't redirect to WS settings page #36270
- Chat - Header markdown has bigger font-size in compose box than in chat history #36272
- [HOLD for payment 2024-02-20] [HOLD for payment 2024-02-19] Request money - App reopens request details page after saving description #36175
- [HOLD for payment 2024-02-20] [HOLD for payment 2024-02-19] Web - IOU - LHN can be seen twice when navigating back #36306
- [HOLD for payment 2024-02-20] [HOLD for payment 2024-02-19] IOU - The chat window is blank after I edit the description #36307
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Feb 8, 2024
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.39-0 🚀
dangrous commentedon Feb 8, 2024
Closed #36174 - dupe of #33114 and reproducible on prod
marcaaron commentedon Feb 9, 2024
Checked off #36183 as it is niche (Android mWeb while offline) and doesn't affect app usability.
Julesssss commentedon Feb 9, 2024
Checked off #36218 as a blocker as it's a very minor problem.
kbecciv commentedon Feb 9, 2024
Regression is 2% left
#34135 is pending validation in Desktop
#35137 is failing #36175
#35470 is pending validation in Desktop and Android
#35744 is pending validation in Desktop
#35837 is pending validation in Desktop and Web
#35875 is pending validation in Android and mWeb
Deploy Blockers:
#36173
#36175
#36180
#36185
#36199
#36200
#36201
#36202
#36217
#36227
kbecciv commentedon Feb 9, 2024
Regression is completed!
#34135 is failing #36184, closed - not a bug, checking Off
#35137 is failing #36175
#35744 is failing #36215
#35837 is failing #36253 in Desktop and Web
#35875 is failing #36230 in Android app, and #35436 in mWeb/safari, left a comment - #35875 (comment)
Deploy Blockers:
#36173
#36175
#36180
#36185
#36199
#36200
#36201
#36202
#36217
#36227
#36230
#36246
#36253
#36254
#36260
#36263
#36265
#36268
#36270
#36272
neil-marcellini commentedon Feb 9, 2024
Checking off #36272 because it's very minor, and I rather release the new feature first.
thienlnam commentedon Feb 9, 2024
Checked off all the ones that were related to live markdown
marcaaron commentedon Feb 9, 2024
Blocker was removed for #36246
marcaaron commentedon Feb 9, 2024
Looks like #36201 was closed
marcaaron commentedon Feb 9, 2024
Fixed #36265 with a CP
marcaaron commentedon Feb 9, 2024
Fixed #36230 with a CP
marcaaron commentedon Feb 9, 2024
Removing blocker on #36202 as you would need to be on the policy expense chat beta to experience it.
kbecciv commentedon Feb 11, 2024
CP #36287 is failing #36306 and #36307
Deploy Blockers:
#36175
#36270
#36306
#36307
Beamanator commentedon Feb 12, 2024
Created PR #36329 to hopefully fix 3 blockers - CPing to staging soon, then will test
Beamanator commentedon Feb 12, 2024
Checking off #36270 because the fix is on staging & tests well
Beamanator commentedon Feb 12, 2024
Checking off #36287 for fixing #36175
And checking off #36329 for fixing #36306 and #36307
Beamanator commentedon Feb 12, 2024
Github is only having a few copilot issues, let's ship!
Beamanator commentedon Feb 12, 2024