[HOLD for payment 2024-02-20] Login - Welcome modal is not dismissed after selecting an option

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.39-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Log in with a new account.
Select the first item in the welcome modal.
Go back using device navigation (not app back button).

Expected Result:

The welcome modal is closed and user is redirected to LHN.

Actual Result:

The welcome modal is not closed.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6373563_1707484177351.Screen_Recording_20240209_134842_New_Expensify.mp4

View all open jobs on GitHub

@abekkala

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think this bug might be related to #vip-vsb

@rlinoz

Triggered auto assignment to @rlinoz (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@teneeto

@teneeto curious if this could be related to our recent changes 🤔

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Dismiss onboard flow when selecting option #36283

If no regressions arise, payment will be issued on 2024-02-19. 🎊

@marcaaron

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
[@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@marcaaron] Determine if we should create a regression test for this bug.
[@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

NAB b/c #36283 got to prod yesterday!

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.40-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Dismiss onboard flow when selecting option #36283

If no regressions arise, payment will be issued on 2024-02-20. 🎊

@marcaaron

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@marcaaron] The PR that introduced the bug has been identified. Link to the PR:
[@marcaaron] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@marcaaron] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@marcaaron] Determine if we should create a regression test for this bug.
[@marcaaron] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@marcaaron

@marcaaron I want to make sure I'm not overlooking a contributor (for payment purposes) but it appears that you implemented the fix and @rlinoz did the PR review so this was fully internal?

@abekkala

You are correct @abekkala 😄

Yep you got it. I think we can close this one out.

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-20] Login - Welcome modal is not dismissed after selecting an option #36265

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

13 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-02-20] Login - Welcome modal is not dismissed after selecting an option #36265

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 9, 2024

github-actions commented on Feb 9, 2024

kavimuru commented on Feb 9, 2024

melvin-bot commented on Feb 9, 2024

marcaaron commented on Feb 9, 2024

13 remaining items

melvin-bot commented on Feb 12, 2024

melvin-bot commented on Feb 12, 2024

melvin-bot commented on Feb 12, 2024

Beamanator commented on Feb 13, 2024

melvin-bot commented on Feb 13, 2024

melvin-bot commented on Feb 13, 2024

abekkala commented on Feb 13, 2024

rlinoz commented on Feb 13, 2024

marcaaron commented on Feb 14, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions