[$500] Workspace-Some workspaces are shown in bold and some not

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.36
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team
Slack conversation:

Action Performed:

Pre-condition: open account with many workspaces created

Go to https://staging.new.expensify.com/
Tap in top right icon
Scroll down list of workspaces

Expected Result:

All workspaces should be displayed in same manner.

Actual Result:

Some workspaces are shown in bold and some not.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6366196_1706985592680.az_recorder_20240203_015705.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~015db9082b5dbefc79
Upwork Job ID: 1753900794333388800
Last Price Increase: 2024-02-03

Job added to Upwork: https://www.upwork.com/jobs/~015db9082b5dbefc79

@situchan

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@marcaaron

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@quinthar

We think that this bug might be related to #vip-vsb
CC @quinthar

@ZhenjaHorbach

@ZhenjaHorbach then the actual bug is that some workspace names are not getting the bold font even after having a green or red dot, meanwhile some have bold text even without a dot.

@puneet2715

📣 @puneet2715! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Make sure you've read and understood the contributing guidelines.
Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Proposal

Please re-state the problem that we are trying to solve in this issue.

Some workspaces are shown in bold and some not.

What is the root cause of that problem?

There might be a delay from onyx when new data is returned for a policy in
This line

App/src/pages/WorkspaceSwitcherPage.tsx

Line 139 in 3ab4e6e

boldStyle: hasUnreadData(policy?.id),

What changes do you think we should make in order to solve the problem?

We could pass a false type to the hasBoldStyle or remove it altogether since the unread have their own green/red dots.

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue

Some workspaces names are not shown in bold text when they are supposed to due to either having red / green brick indicators.

What is the root cause of that problem?

App/src/libs/ReportUtils.ts

Lines 3569 to 3578 in 3ab4e6e

    
           function isUnread(report: OnyxEntry<Report>): boolean { 
        
               if (!report) { 
        
                   return false; 
        
               } 
        
               // lastVisibleActionCreated and lastReadTime are both datetime strings and can be compared directly 
        
               const lastVisibleActionCreated = report.lastVisibleActionCreated ?? ''; 
        
               const lastReadTime = report.lastReadTime ?? ''; 
        
               return lastReadTime < lastVisibleActionCreated; 
        
           }

Both getWorkspacesUnreadStatuses and ReportUtils.isUnread functions are working as expected. If there's any unread report within a workspace (policy) based on the code block above -> the isUnread will return true for that said report which is part of the workspace -> therefore we will see the workspace name text having the bold style.

If what we want here as expected result is to keep the workspace name in bold style when there's no unread reports, but we have red / green brick indicators present then the problem is we're missing an additional condition where we set the boldStyle: hasUnreadData(policy?.id).

What changes do you think we should make in order to solve the problem?

Within the WorkspaceSwitcherPage component, add additional condition to boldStyle as follows:

boldStyle: hasUnreadData(policy?.id) || !!getIndicatorTypeForPolicy(policy?.id)

this way if within any of that workspace's reports there's any kind of indicator present -> the workspace name text will have the bold style until the indicator is resolved by the user within the report that is causing it.

Videos

iOS: Native

Before	After
Screen.Recording.2024-02-04.at.15.53.24.mov	b89f75a4-a9fb-467c-b867-5a44fabd4d3f.mp4

This is not a blocker, I actually think this is expected behaviour

This is a dupe of existing issue with better issue body/ repro steps here #35682

Right, if the workspace in question has chats with unread messages, the row should be bold. We don't add a GBR for unread messages.

That said, I think there's a bug with the bold rows, as logged here: #35682

Perhaps this issue is just a dupe.

Navigation Menu

Repository navigation

[$500] Workspace-Some workspaces are shown in bold and some not #35766

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Videos

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function isUnread(report: OnyxEntry<Report>): boolean {
	if (!report) {
	return false;
	}

	// lastVisibleActionCreated and lastReadTime are both datetime strings and can be compared directly
	const lastVisibleActionCreated = report.lastVisibleActionCreated ?? '';
	const lastReadTime = report.lastReadTime ?? '';
	return lastReadTime < lastVisibleActionCreated;
	}

[$500] Workspace-Some workspaces are shown in bold and some not #35766

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Feb 3, 2024

melvin-bot commented on Feb 3, 2024

melvin-bot commented on Feb 3, 2024

github-actions commented on Feb 3, 2024

melvin-bot commented on Feb 3, 2024

izarutskaya commented on Feb 3, 2024

ZhenjaHorbach commented on Feb 3, 2024

puneet2715 commented on Feb 3, 2024

melvin-bot commented on Feb 3, 2024

muas19 commented on Feb 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

ikevin127 commented on Feb 4, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Videos

mountiny commented on Feb 5, 2024

mountiny commented on Feb 5, 2024

trjExpensify commented on Feb 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions