[HOLD for payment 2024-04-05] [Wave Collect] [Ideal Nav] Issues with the bold (unread) status on Workspace Item

[hayata-suenaga]

Action Performed:

The workspace item on the Workspace Switcher should be bold when there are any unread chat/report in that workspace. This indicator, however, isn't working consistently.

Sometimes, the workspace item is bold even when there is no unread chat in that workspace. And sometimes, it's not bold when there is a unread chat/report.

The following is the reproduction step for the latter issue.

1. Create a workspace if you don't have one yet.
2. Go to a workspace (not Expensify one).
3. Right click (or long press) a chat and click Mark as unread on the popover that appears
4. Click the Workspace Switcher.
5. Look for the current workspace name. Confirm that the workspace name is bold.
6. Go back to the workspace.
7. Right click the same chat and click Mark as read
8. Go back to Workspace Switcher
9. Confirm the current workspace is not bold

Screen.Recording.2024-01-22.at.7.26.44.PM.mov

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Vides are attached above.

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0183bc22eb2779a4b0
• Upwork Job ID: 1763580448153239552
• Last Price Increase: 2024-03-01

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[hayata-suenaga]

@mateuuszzzzz I believe you're working on this regression? can you comment on this GH issue so that I can assign you?

[Christinadobrzyn]

Ah good catch! I can reproduce this - we'll see if @mateuuszzzzz is working on this!

[cdOut]

Hello, I'll be working on this one and take it from @mateuuszzzzz.

[trjExpensify]

Nice, assigned you @cdOut!

[ikevin127]

While debugging a similar issue (#35766) which was closed as a dupe of this one I noticed the following:

• within the ReportUtils.isUnread function we're checking the lastReadTime which if undefined will fallback to empty string
• in WorkspacesSettingsUtils we're using Onyx.connect to get allReports
• sometimes for certain workspaces -> reports within that workspace will initially have the lastReadTime as undefined
• undefined lastReadTime defaults to empty string which when compared to an existing lastVisibleActionCreated date string, isUnread always returns true

Considering these, I tend to think that the RC here might come from the Onyx.connect -> allReports data which might first initialize some report variables as undefined - while shortly after to become defined but the function doesn't register the data change and remains with initial isUnread status.

Hope this helps w/ debugging ✌️