Skip to content

[$500] Web - Workspace - Workspace created in offline mode is not grayed out on Choose a workspace page #35732

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.36-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Go offline
  2. Create new workspace
  3. Navigate to the Choose a workspace page

Expected Result:

Newly created workspace in offline should be grayed out

Actual Result:

Workspace created in offline mode is not grayed out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365353_1706909617540.Recording__2017.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0124a63474e95d7dc5
  • Upwork Job ID: 1753546948780208128
  • Last Price Increase: 2024-02-02

Activity

  1. github-actions commented on Feb 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. kbecciv commented on Feb 2, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave8-collect-admins
    CC @zanyrenney

  4. changed the title [-]Workspace - Workspace created in offline mode is not grayed out on Choose a workspace page[/-] [+]Web - Workspace - Workspace created in offline mode is not grayed out on Choose a workspace page[/+] on Feb 2, 2024
  5. francoisl commented on Feb 2, 2024

    @francoisl
    Contributor

    Sounds somewhat similar to #35702.

  6. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 2, 2024
  7. changed the title [-]Web - Workspace - Workspace created in offline mode is not grayed out on Choose a workspace page[/-] [+][$500] Web - Workspace - Workspace created in offline mode is not grayed out on Choose a workspace page[/+] on Feb 2, 2024
  8. melvin-bot commented on Feb 2, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 2, 2024
  10. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

  11. 32 remaining items

  12. mananjadhav commented on Feb 14, 2024

    @mananjadhav
    Collaborator

    Folks I was finishing up some PRs, and I'll be focusing on this one today. Please bear with me for one day.

  13. melvin-bot commented on Feb 16, 2024

    @melvin-bot

    @tylerkaraszewski @mananjadhav @kevinksullivan this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

  14. melvin-bot commented on Feb 19, 2024

    @melvin-bot

    @tylerkaraszewski, @mananjadhav, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

  15. mananjadhav commented on Feb 19, 2024

    @mananjadhav
    Collaborator

    I checked the comments/proposals again, and I can see the code has changed since we last reviewed. @Tony-MK @ZhenjaHorbach do either of you want to revise their proposals?

  16. mvtglobally commented on Feb 21, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  17. kevinksullivan commented on Feb 22, 2024

    @kevinksullivan
    Contributor

    Closing out unless this is reproducible again after the mentioned changes.

  18. Tony-MK commented on Feb 25, 2024

    @Tony-MK
    Contributor

    @kevinksullivan, this issue is still reproducible on the latest main branch.

    Furthermore, once a workspace is created, the workspace settings page should grayed out.

    Similar to when a workspace name is updated.

    Could we confirm this?

    Thank you

  19. kevinksullivan commented on Mar 1, 2024

    @kevinksullivan
    Contributor

    Hm I'm actually not sure what's going on here. I am seeing some workspaces I created previously grayed out, and some aren't while offline. What is the expected behavior?

    image
  20. Tony-MK commented on Mar 5, 2024

    @Tony-MK
    Contributor

    The expected result of graying out the options in the workspace switcher is wrong.

    I suppose there was confusion about highlighting the focused option and pending action.

    However, is it true that when the workspace is created, the workspace's initial page should grayed out?

    Similarly, when a workspace name is updated.

    Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions