Repository navigation
[Payment 2/21] [$500] [Wave 8] [Ideal Nav] WS - When deleting a WS offline, it is not crossed out #35702
Description
Activity
Triggered auto assignment to @CortneyOfstad (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @puneetlath (
Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.We think that this bug might be related to #wave6
CC @greg-schroederHmm. This isn't really a Wave 6 specific issue, it's kind of just general to the app
It should obviously be fixed, but I don't think it needs to be tracked on the Wave 6 board
@puneetlath Just let me know if there is anything you need from me as BZ! 👍
39 remaining items
@CortneyOfstad This should be ready for payout. Can you help with the payout summary?
Added a comment on the offending PR.
@hayata-suenaga @CortneyOfstad Can one of you confirm if a test exists for the offline feedback of WS deletion already? If not, then I think it makes sense to add a regression test here.
Copied the steps from the PR for regression test proposal.
- Tap on the wrench on bottom tab
- Turn off internet
- Tap on 3 dots menu next to any workspace and delete it while offline
- Verify that deleted workspace is crossed out
- Tap on 3 dots menu again
- Verify that 3 dots menu is disabled and not clickable
@mananjadhav I did not see a regression test in relation to this, so I believe that creating one should be fine. If you're confident in those steps, I'll get regression test created 👍
Other Offline Mode tests were available in TestRail, but not removing a workspace, so would recommend adding here
Payment summary incoming!
Payment Summary
@mkhutornyi (Contributor) — paid $500 via Upwork
@mananjadhav (C+) — to be paid $500 via NewDotYes we used the same steps to test the PR and they worked fine.
Perfect! Regression test has been created here
Also updated the title to reflect the payment date 👍
Reacted by Manan and Hayata SuenagaReacted by Manan and Hayata Suenaga- changed the title
[-][$500] [Wave 8] [Ideal Nav] WS - When deleting a WS offline, it is not crossed out[/-][+][Payment 2/21] [$500] [Wave 8] [Ideal Nav] WS - When deleting a WS offline, it is not crossed out[/+]on Feb 21, 2024 @mananjadhav has a pay request been sent in NewDot yet?
⚠️ Looks like this issue was linked to a Deploy Blocker hereIf you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.
yeah above Melvin comment is false alarm. That's because I referenced this issue here
Reacted by Hayata SuenagaThis is good to close! @mananjadhav if you have any trouble getting the NewDot request through because this is closed, feel free to reopen 👍
- moved this from Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) to Done in [#whatsnext] Wave 08 - Collect Plan Admins
on Feb 23, 2024 $500 approved for @mananjadhav based on this summary.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4278525&group_by=cases:section_id&group_order=asc&group_id=229065
Email or phone of affected tester (no customers): applausetester+emilio@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
User expects the WS to be crossed out when deleted offline and then after returning online to disappear
Actual Result:
The WS instantly disappears
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6365190_1706899405908.WS_deleted_offline_is_not_crossed_out_.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit