Skip to content

[HOLD for payment 2024-02-14] [$125] Web - Profile icon and wrench at the bottom have the same tooltips #35728

Description

@kbecciv

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.36-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Login in to New Expensify
  2. Hover over Profile icon
  3. Hover over wrench icon at the bottom
  4. Note that the tooltips are the same

Expected Result:

The tooltips should differ, and describe the pages to which they lead.

Actual Result:

For both icons the tooltip is: "Settings". Even though one leads to Account Settings, and the other to Workspaces Settings.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6365300_1706906365717.2024-02-02_21-26-46.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011391fcb0d4fa84f7
  • Upwork Job ID: 1753532395165429760
  • Last Price Increase: 2024-02-02
  • Automatic offers:
    • alitoshmatov | Reviewer | 28142751

Activity

  1. github-actions commented on Feb 2, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. kbecciv commented on Feb 2, 2024

    @kbecciv
    Author

    We think that this bug might be related to #wave8-collect-admins
    CC @zanyrenney

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Feb 2, 2024
  5. changed the title [-]Web - Profile icon and wrench at the bottom have the same tooltips[/-] [+][$500] Web - Profile icon and wrench at the bottom have the same tooltips[/+] on Feb 2, 2024
  6. melvin-bot commented on Feb 2, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 2, 2024
  8. 32 remaining items

  9. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-14. 🎊

    For reference, here are some details about the assignees on this issue:

  11. melvin-bot commented on Feb 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
    • [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@alitoshmatov] Determine if we should create a regression test for this bug.
    • [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. twisterdotcom commented on Feb 7, 2024

    @twisterdotcom
    Contributor

    @Amarparab2024 can you share your Upwork profile link please?

  13. aeioual commented on Feb 7, 2024

    @aeioual
    Contributor
  14. aeioual commented on Feb 7, 2024

    @aeioual
    Contributor

    also @luacmartins , similar #35507, #35683 has compensation of $500/$250, so i was wondering whether this is also eligible for that bounty? 🤔

    referring to the comments above, if possible can you please match the bounty of this issue same at par with similar other mentioned issues :)

    If not then no problem this is just fine

  15. twisterdotcom commented on Feb 7, 2024

    @twisterdotcom
    Contributor

    I think this will remain as Carlos agreed here: #35728 (comment)

  16. aeioual commented on Feb 7, 2024

    @aeioual
    Contributor

    No problem :)

  17. twisterdotcom commented on Feb 14, 2024

    @twisterdotcom
    Contributor

    @alitoshmatov I need you to accept your offer: https://www.upwork.com/nx/wm/offer/28142751
    @Amarparab2024 I need you to accept your offer: https://www.upwork.com/nx/wm/offer/100905317

  18. twisterdotcom commented on Feb 14, 2024

    @twisterdotcom
    Contributor

    Payment Summary:

    We do not need a Test for this.

  19. moved this from Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) to Done in [#whatsnext] Wave 08 - Collect Plan Adminson Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions