[HOLD for payment 2024-02-26] [$250] Workspace switcher - No tooltip when hovering over + button next to Workspaces

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4-36.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

Open workspace switcher
Hover over + button next to Workspaces

Expected Result:

Tooltip will show up

Actual Result:

No tooltip when hovering over + button next to Workspaces

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6365095_1706894912514.20240202_233253__1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cb8f425174a88fd1
Upwork Job ID: 1753484365389684736
Last Price Increase: 2024-02-02
Automatic offers:

neonbhai | Contributor | 28142987

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@luacmartins

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@Quinter

We think that this bug might be related to #vip-vsp
CC @Quinter

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace switcher - No tooltip when hovering over + button next to Workspaces

What is the root cause of that problem?

We are missing the logic for showing a tooltip.

What changes do you think we should make in order to solve the problem?

We should wrap the icon here with Tooltip:

App/src/pages/WorkspaceSwitcherPage.tsx

Lines 215 to 231 in e6ea03b

    
           <PressableWithFeedback 
        
               accessible={false} 
        
               role={CONST.ROLE.BUTTON} 
        
               onPress={() => { 
        
                   App.createWorkspaceWithPolicyDraftAndNavigateToIt(); 
        
               }} 
        
           > 
        
               {({hovered}) => ( 
        
                   <Icon 
        
                       src={Expensicons.Plus} 
        
                       width={12} 
        
                       height={12} 
        
                       additionalStyles={[styles.buttonDefaultBG, styles.borderRadiusNormal, styles.p2, hovered && styles.buttonHoveredBG]} 
        
                       fill={theme.icon} 
        
                   /> 
        
               )} 
        
           </PressableWithFeedback>

<Tooltip text={translate('common.new')}>
...
</Tooltip>

I don't think this is a blocker. Added to the project board and gonna follow the regular process.

@slafortune

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

same as above

@rushatgabhane

$250 approved for @rushatgabhane based on this summary.

@rushatgabhane

@rushatgabhane will you be able to complete the checklist today? Seems like it will be pretty straight forward?

Still waiting on payments

@rushatgabhane

@rushatgabhane needs to complete the checklist -payments have all been made.

checklist updated - #35683 (comment)

Navigation Menu

Repository navigation

[HOLD for payment 2024-02-26] [$250] Workspace switcher - No tooltip when hovering over + button next to Workspaces #35683

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

41 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<PressableWithFeedback
	accessible={false}
	role={CONST.ROLE.BUTTON}
	onPress={() => {
	App.createWorkspaceWithPolicyDraftAndNavigateToIt();
	}}
	>
	{({hovered}) => (
	<Icon
	src={Expensicons.Plus}
	width={12}
	height={12}
	additionalStyles={[styles.buttonDefaultBG, styles.borderRadiusNormal, styles.p2, hovered && styles.buttonHoveredBG]}
	fill={theme.icon}
	/>
	)}
	</PressableWithFeedback>

[HOLD for payment 2024-02-26] [$250] Workspace switcher - No tooltip when hovering over + button next to Workspaces #35683

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Feb 2, 2024

melvin-bot commented on Feb 2, 2024

lanitochka17 commented on Feb 2, 2024

neonbhai commented on Feb 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

luacmartins commented on Feb 2, 2024

melvin-bot commented on Feb 2, 2024

41 remaining items

luacmartins commented on Mar 1, 2024

JmillsExpensify commented on Mar 1, 2024

slafortune commented on Mar 4, 2024

luacmartins commented on Mar 6, 2024

slafortune commented on Mar 7, 2024

rushatgabhane commented on Mar 7, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions