[$125] Android - Login - Status bar on login screen has black background on launch

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.36.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - internal Team
Slack conversation:

Issue found when executing PR #35215

Action Performed:

Kill the app if it is open
Launch the app

Expected Result:

The status bar on the login screen has a green background as the rest of the screen

Actual Result:

The status on the login screen has a black background on launch.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01cb64d3936a4a4d09
Upwork Job ID: 1753535889231740928
Last Price Increase: 2024-02-02

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@jasperhuangg

Triggered auto assignment to @jasperhuangg (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@quinthar

We think that this bug might be related to #vip-vsb
CC @quinthar

I don't think this is a blocker. Demoting.

Job added to Upwork: https://www.upwork.com/jobs/~01cb64d3936a4a4d09

@getusha

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

Upwork job price has been updated to $125

@ishpaul777

@ishpaul777 i am confused a little bit about the rca and the solution.
4696731#diff-997a5cfe9a560b7061a768c52d18b7ec49fe0c102367eb7eff720874e55869e2R22
based on the commit the name was SCREENS.HOME and SCREENS.RIGHT_MODAL.SIGN_IN is not touched RightModalNavigator, could you please explain it a bit more?

Withdrawing my proposal for now as this requires a complete refactor for custom statusbar logic with the navigation refactor the logic seems broken specifically currentRoute name part

App/src/components/CustomStatusBarAndBackground/index.tsx

Lines 75 to 86 in 1642c5d

    
           if (currentRoute && 'name' in currentRoute && currentRoute.name in theme.PAGE_THEMES) { 
        
               const pageTheme = theme.PAGE_THEMES[currentRoute.name]; 
        
               newStatusBarStyle = pageTheme.statusBarStyle; 
        
               const backgroundColorFromRoute = 
        
                   currentRoute?.params && 'backgroundColor' in currentRoute.params && typeof currentRoute.params.backgroundColor === 'string' && currentRoute.params.backgroundColor; 
        
               // It's possible for backgroundColorFromRoute to be empty string, so we must use "||" to fallback to backgroundColorFallback. 
        
               // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing 
        
               currentScreenBackgroundColor = backgroundColorFromRoute || pageTheme.backgroundColor; 
        
           }

and i think we might not need a different statusbar colors for most pages with these updates so its better to hold off for now, the only pages i think we might need a different status bar is sign in page so maybe we just pass a background color as prop.

Waiting for proposals.

Also this is dupe of #35632

@ishpaul777

Ah thanks for the flag @ishpaul777! Gonna close this issue in favor of #35632

Navigation Menu

Repository navigation

[$125] Android - Login - Status bar on login screen has black background on launch #35724

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (currentRoute && 'name' in currentRoute && currentRoute.name in theme.PAGE_THEMES) {
	const pageTheme = theme.PAGE_THEMES[currentRoute.name];

	newStatusBarStyle = pageTheme.statusBarStyle;

	const backgroundColorFromRoute =
	currentRoute?.params && 'backgroundColor' in currentRoute.params && typeof currentRoute.params.backgroundColor === 'string' && currentRoute.params.backgroundColor;

	// It's possible for backgroundColorFromRoute to be empty string, so we must use "\|\|" to fallback to backgroundColorFallback.
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	currentScreenBackgroundColor = backgroundColorFromRoute \|\| pageTheme.backgroundColor;
	}

[$125] Android - Login - Status bar on login screen has black background on launch #35724

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

github-actions commented on Feb 2, 2024

melvin-bot commented on Feb 2, 2024

kbecciv commented on Feb 2, 2024

luacmartins commented on Feb 2, 2024

melvin-bot commented on Feb 2, 2024

melvin-bot commented on Feb 2, 2024

melvin-bot commented on Feb 2, 2024

ishpaul777 commented on Feb 2, 2024

getusha commented on Feb 4, 2024

ishpaul777 commented on Feb 4, 2024

getusha commented on Feb 6, 2024

ishpaul777 commented on Feb 6, 2024

luacmartins commented on Feb 6, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions