Skip to content

[HOLD for payment 2024-02-19] [$500] [Wave 8] [Ideal Nav] The color of Status Bar (top part of the background) is not consistent #35632

Description

@hayata-suenaga

Action Performed:

  1. Open the app on a mobile browser
  2. Go to Chat page (Chat icon on the bottom tab)
  3. Go to Settings page (🔧 icon on the bottom tab)
  4. Go to Settings page > Workspaces

Expected Result:

The color should be consistent

Actual Result:

The colors are different across different pages

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

screenshots -> #33280 (comment)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f7200068e359bb73
  • Upwork Job ID: 1753450480673206272
  • Last Price Increase: 2024-02-02

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 2, 2024
  2. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  3. changed the title [-]The color of Status Bar (top part of the background) is not consistent[/-] [+][Wave 8] [Ideal Nav] The color of Status Bar (top part of the background) is not consistent[/+] on Feb 2, 2024
  4. moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Adminson Feb 2, 2024
  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Feb 2, 2024
  6. changed the title [-][Wave 8] [Ideal Nav] The color of Status Bar (top part of the background) is not consistent[/-] [+][$500] [Wave 8] [Ideal Nav] The color of Status Bar (top part of the background) is not consistent[/+] on Feb 2, 2024
  7. melvin-bot commented on Feb 2, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 2, 2024
  9. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

  10. hayata-suenaga commented on Feb 2, 2024

    @hayata-suenaga
    ContributorAuthor

    Please hold a little bit before posting proposals until I confirm that this issue is handled independently (there is a possibility that this issue is combined with this issue)

  11. 17 remaining items

  12. hayata-suenaga commented on Feb 9, 2024

    @hayata-suenaga
    ContributorAuthor

    @hayata-suenaga It's not fixed yet for the home page #35632 (comment)

    checking here

  13. hayata-suenaga commented on Feb 9, 2024

    @hayata-suenaga
    ContributorAuthor

    @kosmydel could you check this comment when you have time please? 🙇

  14. kosmydel commented on Feb 9, 2024

    @kosmydel
    Contributor

    @kosmydel could you check this comment when you have time please? 🙇

    Changing this in config broke the android insets. That's why I haven't changed it. Here is more details:
    #35564 (comment)

  15. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Feb 12, 2024
  16. changed the title [-][$500] [Wave 8] [Ideal Nav] The color of Status Bar (top part of the background) is not consistent[/-] [+][HOLD for payment 2024-02-19] [$500] [Wave 8] [Ideal Nav] The color of Status Bar (top part of the background) is not consistent[/+] on Feb 12, 2024
  17. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  18. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-02-19. 🎊

    For reference, here are some details about the assignees on this issue:

  19. melvin-bot commented on Feb 12, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
    • [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rushatgabhane] Determine if we should create a regression test for this bug.
    • [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  20. hayata-suenaga commented on Feb 12, 2024

    @hayata-suenaga
    ContributorAuthor

    @kosmydel could you check #35632 (comment) when you have time please? 🙇

    Changing this in config broke the android insets. That's why I haven't changed it. Here is more details:
    #35564 (comment)

    @kosmydel Thank you for reminding me of that. Are you working on this in a separate issue or should I create a new issue for you?

  21. kosmydel commented on Feb 13, 2024

    @kosmydel
    Contributor

    @kosmydel Thank you for reminding me of that. Are you working on this in a separate issue or should I create a new issue for you?

    I can have a look at this, but I found a PR (#34409) that addresses a mWeb status bar issue. The author of the PR suggests that he found a solution for that. In case this doesn't solve our problem, I can surely investigate it.

  22. hayata-suenaga commented on Feb 13, 2024

    @hayata-suenaga
    ContributorAuthor

    okay let's see if the PR will solve the issue 👍

  23. ishpaul777 commented on Feb 27, 2024

    @ishpaul777
    Contributor

    Unfortunately there was other PR on which my suggested changes depends #34637 to fully solve the problem and that PR had some blockers (might have been resolved now) so i decided not to include the suggested change in my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions