Skip to content

[$500] Web - Total Split amount is not displayed on participant LHN #35679

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.36-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4263495
Email or phone of affected tester (no customers): gocemate@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:Precondition:

User A and User B (gmail accounts) does not have previous conversation

  1. User A creates group chat with User B and User C
  2. User A creates Split bill
  3. Take a look at User's B LHN

Expected Result:

Total Split bill amount should be present on User's B LHN

Actual Result:

Only shared Split bill amount is present on User's B LHN. Total can only be seen in Search results list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6364978_1706889102957.Recording__2007.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01b4ee716715d2a5b2
  • Upwork Job ID: 1753469336800477184
  • Last Price Increase: 2024-02-02

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 2, 2024
  2. changed the title [-]IOU - Total Split amount is not displayed on participant LHN[/-] [+][$500] IOU - Total Split amount is not displayed on participant LHN[/+] on Feb 2, 2024
  3. melvin-bot commented on Feb 2, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 2, 2024
  5. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  6. melvin-bot commented on Feb 2, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  7. lanitochka17 commented on Feb 2, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #vip-split-p2p-chat-groups

  8. cjoshidev commented on Feb 2, 2024

    @cjoshidev

    What is expected out of it it should show the total amount only. and not the requested amount?

  9. promisingcoder commented on Feb 2, 2024

    @promisingcoder

    solution :
    In IOU.js, ensure that the total amount is correctly calculated and included in the splitData:
    javascript
    const totalAmount = calculateTotalAmount(participants, amount);
    const {splitData, splits, onyxData} = createSplitsAndOnyxData(participants, currentUserLogin, currentUserAccountID, totalAmount, comment, currency, category, existingSplitChatReportID);

    In MoneyRequestPreview.js, update the component to display the total amount:
    javascript
    const totalAmount = props.iouReport.totalAmount || '';
    // ...
    {totalAmount}

  10. s77rt commented on Feb 2, 2024

    @s77rt
    Member

    @cjoshi-zeals Both reports should be in LHN

  11. s77rt commented on Feb 2, 2024

    @s77rt
    Member

    @promisingcoder Please follow the proposal template (check contributing guide)

  12. 6 remaining items

  13. getusha commented on Feb 5, 2024

    @getusha
    Contributor

    Looks like this is a dupe of #35537, if it is internal it can be handled here.

  14. cristipaval commented on Feb 7, 2024

    @cristipaval
    Contributor

    haven't had the chance to look at this one yet.

  15. cristipaval commented on Feb 7, 2024

    @cristipaval
    Contributor

    Melv?

  16. changed the title [-][$500] IOU - Total Split amount is not displayed on participant LHN[/-] [+][$500] Web - Total Split amount is not displayed on participant LHN[/+] on Feb 9, 2024
  17. stephanieelliott commented on Feb 13, 2024

    @stephanieelliott
    Contributor

    Hey @cristipaval, will you have a chance to look at this one this week?

  18. cristipaval commented on Feb 14, 2024

    @cristipaval
    Contributor

    I can't reproduce this one. It has been fixed. Could you confirm?

  19. s77rt commented on Feb 16, 2024

    @s77rt
    Member

    Seems fixed

  20. stephanieelliott commented on Feb 16, 2024

    @stephanieelliott
    Contributor

    Yep, no longer able to repro. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions