Skip to content

[$500] Names missing in LHN for a group chat #35537

Closed
Closed
[$500] Names missing in LHN for a group chat#35537
Assignees
stephanieelliottgetusha
Labels
BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Description

@m-natarajan
m-natarajan
opened on Feb 1, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.4.35-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @mallenexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1706727753588069

Action Performed:

  1. Sent message to group chat
  2. Noticed names were missing when searching
  3. Scroll through the LHN and again search

Expected Result:

Group chat members name should appear when searching

Actual Result:

members name does not show immediately when searching after sending a message. Has to scrolldown the LHN to appear the name when searching

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/Expensify/App/assets/38435837/923fb458-3193-46b5-a858-436b25649efa
image
image (1)
image (2)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01a6b3d85f01d11739
  • Upwork Job ID: 1752910067363061760
  • Last Price Increase: 2024-02-01

Activity

  1. m-natarajan
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 1, 2024

  2. melvin-bot commented on Feb 1, 2024

    @melvin-bot
    melvin-botbot
    on Feb 1, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~01a6b3d85f01d11739

  3. melvin-bot
    changed the title [-]Names missing in LHN for a group chat[/-] [+][$500] Names missing in LHN for a group chat[/+] on Feb 1, 2024
  4. melvin-bot
    added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Feb 1, 2024
  5. melvin-bot
    assigned
    getusha
    on Feb 1, 2024

  6. melvin-bot commented on Feb 1, 2024

    @melvin-bot
    melvin-botbot
    on Feb 1, 2024 – with Melvin Bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

  7. melvin-bot
    assigned
    stephanieelliott
    on Feb 1, 2024

  8. melvin-bot commented on Feb 1, 2024

    @melvin-bot
    melvin-botbot
    on Feb 1, 2024 – with Melvin Bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  9. pc6n commented on Feb 1, 2024

    @pc6n
    pc6n
    on Feb 1, 2024

    I do not understand the problem, seems to work for me.
    Also in the attached video nothing is being searched?

  10. melvin-bot commented on Feb 1, 2024

    @melvin-bot
    melvin-botbot
    on Feb 1, 2024 – with Melvin Bot

    📣 @pc11000! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

  11. pc6n commented on Feb 1, 2024

    @pc6n
    pc6n
    on Feb 1, 2024

    Contributor details
    Your Expensify account email: pad.christen@gmail.com
    Upwork Profile Link: https://www.upwork.com/freelancers/~0142d332960f6aa256

  12. melvin-bot commented on Feb 1, 2024

    @melvin-bot
    melvin-botbot
    on Feb 1, 2024 – with Melvin Bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  13. melvin-bot commented on Feb 1, 2024

    @melvin-bot
    melvin-botbot
    on Feb 1, 2024 – with Melvin Bot

    ⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

  15. melvin-bot commented on Feb 1, 2024

    @melvin-bot
    melvin-botbot
    on Feb 1, 2024 – with Melvin Bot

    ✅ Contributor details stored successfully. Thank you for contributing to Expensify!

  16. nebiyuelias1 commented on Feb 1, 2024

    @nebiyuelias1
    nebiyuelias1
    on Feb 1, 2024

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    After creating a chat group, the names of the members are not shown on the search result page.

    What is the root cause of that problem?

    This is happening because of inconsistent report data inside Onyx. In particular to construct the search result options, the report's visibleChatMemberAccountIDs field is accessed in https://github.com/nebiyuelias1/App/blob/aeb8638a46bbc50013e263f037a45c7c3b7af8ad/src/libs/OptionsListUtils.ts#L1441. But this is sometimes empty array and as a result, the names of the members are not shown.

    What changes do you think we should make in order to solve the problem?

    If the visibleChatMemberAccountIDs field is an empty array it's better to use a fallback field: participantAccountIDs like this:

     const accountIDs = (report.visibleChatMemberAccountIDs?.length ?? 0) > 0 ? report.visibleChatMemberAccountIDs : report.participantAccountIDs ?? [];

    What alternative solutions did you explore? (Optional)

    We can directly use participanetAccountIDs field all the time if it's possible.

  17. getusha commented on Feb 2, 2024

    @getusha
    getusha
    on Feb 2, 2024
    Contributor

    Trying to reproduce the issue.

  18. mallenexpensify commented on Feb 3, 2024

    @mallenexpensify
    mallenexpensify
    on Feb 3, 2024
    Contributor

    Maybe create the group chat, don't comment on it, navigate away, the search in lhn for it?
    image

  19. getusha commented on Feb 4, 2024

    @getusha
    getusha
    on Feb 4, 2024
    Contributor

    Thanks @mallenexpensify, i'm able to reproduce it.
    Reviewing @nebiyuelias1's proposal.

  20. getusha commented on Feb 4, 2024

    @getusha
    getusha
    on Feb 4, 2024
    Contributor

    @nebiyuelias1 your solution works, about the RCA could we try to find why the onyx data is being inconsistent, sometimes the names are correctly displayed?

  21. nebiyuelias1 commented on Feb 4, 2024

    @nebiyuelias1
    nebiyuelias1
    on Feb 4, 2024

    @nebiyuelias1 your solution works, about the RCA could we try to find why the onyx data is being inconsistent, sometimes the names are correctly displayed?

    I believe the BE sends incomplete data for some reports and the FE would periodically send an OpenReport action for some inconsistent reports. That's why I suggest using a fallback.

  22. nebiyuelias1 commented on Feb 4, 2024

    @nebiyuelias1
    nebiyuelias1
    on Feb 4, 2024

    @nebiyuelias1 your solution works, about the RCA could we try to find why the onyx data is being inconsistent, sometimes the names are correctly displayed?
    @getusha This is from the readme:

    image

  23. Tony-MK commented on Feb 4, 2024

    @Tony-MK
    Tony-MK
    on Feb 4, 2024
    Contributor

    This issue has the same root cause as #35679.

  24. nebiyuelias1 commented on Feb 4, 2024

    @nebiyuelias1
    nebiyuelias1
    on Feb 4, 2024

    This issue has the same root cause as #35679.

    Apparently yes. Which means this is sorta a dupe issue.

  25. stephanieelliott commented on Feb 6, 2024

    @stephanieelliott
    stephanieelliott
    on Feb 6, 2024
    Contributor

    Ah ok yes, let's close this in favor of #35537 since we already have a proposal and a PR being worked on there.

  26. stephanieelliott
    closed this as completedon Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions