Repository navigation
[$500] Web - Searching for rooms for the first time without hashtags does not work. #34475
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.24-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @justinpersaud
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1705002380962489
Action Performed:
- Create a room with workspace visibility as account A
- Invite user B
- Login as user B
- Search for the room created in step 1 without hashtag
Expected Result:
Room is able to find
Actual Result:
It does not show the result
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
2024-01-12_09-09-56.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~015f0d8aaddbf938d1
- Upwork Job ID: 1747032811175395328
- Last Price Increase: 2024-02-05
Activity
melvin-bot commentedon Jan 13, 2024
Triggered auto assignment to @muttmuure (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.melvin-bot commentedon Jan 15, 2024
Job added to Upwork: https://www.upwork.com/jobs/~015f0d8aaddbf938d1
[-]searching for rooms for the first time without hashtags does not work. [/-][+][$500] searching for rooms for the first time without hashtags does not work. [/+]melvin-bot commentedon Jan 15, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (
External)mallenexpensify commentedon Jan 15, 2024
Hoping/guessing this can be External. @getusha , comment if you disagree. Thx
shubham1206agra commentedon Jan 16, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue
Searching for rooms for the first time without hashtags does not work
What is the root cause of that problem?
This happens because we have provided full room name with
#, which might make the search different from anticipated.Function call
OptionsListUtils.getSearchText(report, reportName, participantPersonalDetailList, result.isChatRoom || result.isPolicyExpenseChat, result.isThread);What changes do you think we should make in order to solve the problem?
We can add a stripped version of title in searchText here (similarly in other places too)
App/src/libs/OptionsListUtils.js
Line 332 in 8e2fb67
We can use similar approach to
App/src/libs/OptionsListUtils.js
Line 320 in 8e2fb67
The motivation behind this is #33029 will perform similar stripping before doing sorting on the display name. So its natural to add a stripped version in search text. We will also keep the original version in case user tries to search with stripped symbols.
What alternative solutions did you explore? (Optional)
shubham1206agra commentedon Jan 16, 2024
@mallenexpensify Can you add this to
#vip-vsb, and maybe same priority as #33029?30 remaining items
melvin-bot commentedon Feb 3, 2024
@allroundexperts @muttmuure this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!
melvin-bot commentedon Feb 5, 2024
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸
muttmuure commentedon Feb 5, 2024
I can still reproduce this. I can't remember the last time I searched for this room, but I did it now:
Then after searching for it once, I searched again and it worked:
I remember we made some changes to
OptionListwhere we were limiting the number of chats returned by search, and we added a debounce.It's just a theory, but I wonder if the debounce before querying the full list is engaged AFTER the initial input, and then if you search again we are actually querying from your "full" list. This would make sense in terms of the expected behavior here, because we can all retrieve a result that we have searched for recently.
muttmuure commentedon Feb 5, 2024
asked about this here: https://expensify.slack.com/archives/C03UK30EA1Z/p1707158970024939
waterim commentedon Feb 6, 2024
Hello, Im Artem from Callstack and would like to help with this issue!
mallenexpensify commentedon Feb 6, 2024
Thanks @waterim , assigned!
waterim commentedon Feb 7, 2024
Was trying to reproduce it for quite some time, but nothing.
I think after sidebar refactor something was changed, because now it works good with newly created rooms, also tried old, can't reproduce too.
Can someone who could reproduce try it once again?
Uploaded two repro steps which I found here:
8mb.video-8Il-kJcR8OQg.mp4
8mb.video-bRs-kl6Kd7Gy.mp4
mallenexpensify commentedon Feb 7, 2024
Thanks @waterim , I'm unsure if I'm able to reproduce either.
@muttmuure can you try to search for this without the # and see if it shows?
Also.. can you create a new test room on the
Expensify Chatworkspace and drop in the name here and I can try to search too. If neither of us can reproduce, we can likely close thismallenexpensify commentedon Feb 8, 2024
Gonna close this, just tested again with a room I'm 99% I've never searched for or visited and it showed in search, so I think it might have magically been fixed. Comment/reopen if you disagree.
2024-02-08_15-22-13.mp4