Repository navigation
HIGH: [Polish] [$500] Finalize order of LHN in #focus mode #33029
Description
Problem:
When the LHN is in "focus" mode, its sorting should be:
- All pinned reports, alphabetically
- Everything else, alphabetically
However, it doesn't seem to be. Here's from @iwiznia:
Solution:
Review the LHN logic for sorting in focus mode to understand what it's currently doing, and verify it's correct. The correct behavior should be:
#focus mode:
- All pinned chats (alphabetically)
- Everything else (alphabetically)
most recent mode:
- All pinned chats (alphabetically)
- Everything else (most recent sorting)
Additionally:
- When sorting alphabetically, it should only sort the alphanumeric characters -- other characters should be ignored.
- "pinned chats" refers to chats that are actually pinned, as well as any chat with a "green/red brick road" (GBR/RBR), which are treated as if they are pinned.
So, for this issue please:
- Review the existing sorting code
- Update it to match the logic above
- Update the sort comparator to ignore non-alphanumeric characters when sorting
- Verify that GBR chats are showing as pinned
- Verify that RBR chats are showing as pinned
You up to the challenge? Let's see those proposals!!
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~01432274cc2b58438c
- Upwork Job ID: 1744194942807576576
- Last Price Increase: 2024-01-08
Activity
[-]MEDIUM: Finalize order of LHN in #focus mode[/-][+]HIGH: Finalize order of LHN in #focus mode[/+]quinthar commentedon Dec 28, 2023
Upgrading to HIGH as it's fundamentally about making it work correctly.
[-]HIGH: Finalize order of LHN in #focus mode[/-][+][$500] HIGH: Finalize order of LHN in #focus mode[/+]melvin-bot commentedon Jan 8, 2024
Job added to Upwork: https://www.upwork.com/jobs/~01432274cc2b58438c
154 remaining items
shubham1206agra commentedon May 4, 2024
@youssef-lr Can we restart discussion on this issue?
youssef-lr commentedon May 7, 2024
Yes I think we should. I'll get back to you this week @shubham1206agra as I'm busying finalizing a new feature.
luacmartins commentedon Jun 27, 2024
What's the latest here? I think we merged a fix for this issue and it's done? Are we missing payments?
youssef-lr commentedon Jun 27, 2024
@luacmartins we need to redo the fix, it caused performance issues and we reverted it.
shubham1206agra commentedon Aug 13, 2024
@youssef-lr Should we redo the fix now? Or is something blocking us now?
youssef-lr commentedon Aug 13, 2024
I think let's redo it and see if reassure-perf complains
melvin-bot commentedon Oct 10, 2024
@JmillsExpensify, @youssef-lr, @luacmartins, @fedirjh, @shubham1206agra, this Monthly task hasn't been acted upon in 6 weeks; closing.
If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.
shubham1206agra commentedon Oct 16, 2024
@youssef-lr Please repoen this.
JmillsExpensify commentedon Nov 26, 2024
Is this being actively worked on? If not, my preference is to close.
luacmartins commentedon Nov 26, 2024
I don't think so, but @youssef-lr would be able to confirm
JmillsExpensify commentedon Nov 27, 2024
Youssef please open back up if it's being worked on. Otherwise, I think we have more important priorities to focus on.