Repository navigation
[HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account #31797
Description
Activity
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
📣 @github-actions[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:- Make sure you've read and understood the contributing guidelines.
- Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
- Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
- Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
Format:
Contributor details Your Expensify account email: <REPLACE EMAIL HERE> Upwork Profile Link: <REPLACE LINK HERE>Triggered auto assignment to @hayata-suenaga (
Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.Commented on offending PR - https://github.com/Expensify/App/pull/30582/files#r1403715597
@situchan do you have a solution for this?
From that PR's OP:
choose to pay p2p IOU report with business bank account
So it seems like we need to start allowing that payment method and launching the VBBA setup
I'm not sure how to handle that from the wallet page because in NewDot we tie the bank account to a specific policy (we have this issue to fix that). Maybe in the meantime we just select a random policy the user has stored?
In this case we should just normally open the BBA flow, I havent tested this flow before
Ok, I'll put up a PR to fix it
7 remaining items
- changed the title
[-]Wallet - App crashes when selecting Wallet > Add bank account > Business bank account[/-][+][HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account[/+]on Nov 27, 2023 Reviewinglabel has been removed, please complete the "BugZero Checklist".The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.3-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-04. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
- changed the title
[-][HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account[/-][+][HOLD for payment 2023-12-06] [HOLD for payment 2023-12-04] Wallet - App crashes when selecting Wallet > Add bank account > Business bank account[/+]on Nov 29, 2023 The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.4-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2023-12-06. 🎊
After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
- External issue reporter
- Contributor that fixed the issue
- Contributor+ that helped on the issue and/or PR
No payment is due here. We're good to close.
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.3.0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
User can continue connecting the bank account
Actual Result:
App crashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6288925_1700770710020.Desktop-Crash-Wallet-BA.mp4
View all open jobs on GitHub