[HOLD for payment 2023-12-21] [$500] [Wave 6: Categories] - Unexpected error when requesting money with a very long category in workspace chat

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 1.3.94.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #30264

Action Performed:

Precondition:
The following long category is set up on OldDot.

Meals: Level 2 nesting and a category name that could span two lines: Level 3 nesting and a category name that could span two lines: Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.

Go to workspace chat > + Request money > Manual.
Create a money request with no category.
Note that the request is successful.
Repeat Step 2 with a very long category name from the precondition.

Expected Result:

The request is successful.

Actual Result:

The request is not successful. It shows an unexpected error message.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6259289_1698837857753.20231101_100027.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~018cfdce1c85555976
Upwork Job ID: 1719689005334507520
Last Price Increase: 2023-11-01
Automatic offers:

Ollyws | Reviewer | 27576838

@stephanieelliott

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Job added to Upwork: https://www.upwork.com/jobs/~018cfdce1c85555976

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@Ollyws

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

I was able to reproduce this and I confirm that the RequestMoney call fails with the following error:

Which means that the long category created on OldDot turns out to be exceeding maximum size when the NewDot's RequestMoney is called with that category. I think this is a BE related issue.

Hey there shouldn't be any proper handling for requesting money with category. We can use if and AND condition to solve this issue. Let me know if you need a help.

Contributor details
Your Expensify account email: nisarg.k.amin@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01149c9659573bccce

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Made PR ready for review: #32394

Got you, makes sense. Thank you 🙂

This issue didn't update but the PR was pushed to prod on 12/14. Adjusting title to remember to issue payment after 7 day hold.

@dylanexpensify

Issue is ready for payment but no BZ is assigned. @dylanexpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

@rezkiy37

Summarizing payment on this issue:

Contributor: no payment, @rezkiy37 with Callstack
Contributor+: $500, to pay via Upwork - @Ollyws I've extended the offer to you on Upwork, can you please accept?

Upwork job is here: https://www.upwork.com/jobs/~018cfdce1c85555976

Accepted, thanks!

All paid, thank you!

Navigation Menu

Repository navigation

[HOLD for payment 2023-12-21] [$500] [Wave 6: Categories] - Unexpected error when requesting money with a very long category in workspace chat #30683

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Bug0 Triage Checklist (Main S/O)

71 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-12-21] [$500] [Wave 6: Categories] - Unexpected error when requesting money with a very long category in workspace chat #30683

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Nov 1, 2023

melvin-bot commented on Nov 1, 2023

melvin-bot commented on Nov 1, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Nov 1, 2023

ikevin127 commented on Nov 1, 2023

NisargDeveloper commented on Nov 2, 2023

melvin-bot commented on Nov 2, 2023

71 remaining items

aldo-expensify commented on Dec 5, 2023

rezkiy37 commented on Dec 5, 2023

stephanieelliott commented on Dec 19, 2023

melvin-bot commented on Dec 21, 2023

stephanieelliott commented on Dec 21, 2023

Ollyws commented on Dec 21, 2023

stephanieelliott commented on Dec 22, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions