Repository navigation
Deploy Checklist: New Expensify 2023-09-11 #27120
Description
Release Version: 1.3.67-0
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Apply Onyx updates in an ordered fashion #25455
- [No QA] [TS migration] Migrate 'spacing.js' style to TypeScript #25829
- 25714 stop using report participants #26102
- [No QA] add support for device selection when running ios #26230
- [24321] Large amounts are no longer cut off on smaller widths. #26280
- Android App Notification Logo Update #26381
- Emoji Suggestions Adjustments + Remove Duplicates #26507
- [No QA] [TS migration] Migrate 'RoomNameInputUtils.js' lib to TypeScript #26640
- Checking ToS box before filling fields throws error in mweb but not in android app #26699
- Fix: Thread - No space between message and compose box when sender leave thread #26770
- Fix money request getting paid on selecting emoji with 'enter' #26840
- Fix composer invisible text covered up the chat/report screen #26847
- fix: 25709 drop container does not add opacity to entire height of the drawer #26849
- Fix Deeplinks except chat reports are not working on web #26856
- [No QA][TS migration] Migrate 'ControlSelection' lib to TypeScript #26870
- [NO QA] Add policyRecentlyUsedCategories_ as collection key #26920
- 26222: Fix padding jump when isComposerFullSize #26926
- [NO QA] Fix: Dev: console error if we open RHN page directly #26980
- [CP Staging] iPad layout fix (by forcing narrow layout) #27004
- [No QA] Adjust Github lint workflow name #27005
- [NO QA] Update reference to deprecated provisioning profile #27007
- fix: android app - expand icon doesn't disappear immediately after sending the message #27015
- [CP Staging] [NoQA] Require full screen for iOS #27016
Deploy Blockers:
- [Awaiting C+ payment] [HOLD for payment 2023-09-15] [$500] [Distance] App crashes while creating Distance Request money #26953
- [HOLD for payment 2023-09-20] Android - The updated Expensify logo has no background on Android notification #27145
- Dev: Web - Closing the manual request currency selector opens the distance request tab. #27157
- Dev: Web - Incorrect Screen when Clicking CMD+K while Year Selection Modal is opened. #27160
- [HOLD for payment 2023-09-27] Unable to send attachment and new message is not shown in LHN after sending attachment #27163
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Activity
OSBotify commentedon Sep 11, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.67-0 🚀
OSBotify commentedon Sep 11, 2023
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.67-0 🚀
Julesssss commentedon Sep 11, 2023
I checked off #26381 as it is a minor notification logo colour change
Julesssss commentedon Sep 11, 2023
#26953 is not a blocker, the fix is already on prod so I removed the label and checked it off.
Julesssss commentedon Sep 11, 2023
Verified and checked off #26980 as it's a dev-only issue.
mountiny commentedon Sep 11, 2023
Closing #27157, not repro
arosiclair commentedon Sep 11, 2023
#27160 is reproducible on prod. Checked it off
cristipaval commentedon Sep 11, 2023
Checked off #27145 as the PR that introduced the regression was reverted and I tested and can confirm that the blocker is now fixed.
kavimuru commentedon Sep 11, 2023
@AndrewGable Regression only 4 steps to go
PR #26856 - Desktop slot is blocked with this issue #25790
Web is failing with this issue #26852 for these 2 deeplinks https://staging.new.expensify.com/enable-payments and https://staging.new.expensify.com/sbe
kavimuru commentedon Sep 11, 2023
Regression completed.
PR #26856 - Desktop slot is blocked with this issue #25790 which is known
Web failing with known issue #26021 - checking it off
AndrewGable commentedon Sep 11, 2023