Skip to content

[HOLD for payment 2023-09-20] Android - The updated Expensify logo has no background on Android notification #27145

Closed
Closed
[HOLD for payment 2023-09-20] Android - The updated Expensify logo has no background on Android notification#27145
Assignees
AndrewGablecristipavalmiljakljajic
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Description

@lanitochka17
lanitochka17
opened on Sep 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue foung when executing PR #26381

Action Performed:

  1. Log in to New Expensify app as User A
  2. Background the app
  3. As User B from another device, send a message to User A

Expected Result:

The updated logo has green as background color and the icon can be dark/white

Actual Result:

The updated logo has no background

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.67-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6196094_Screenshot_20230911_195513

Bug6196094_26381_Android.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. lanitochka17
    added
    DeployBlockerCashThis issue or pull request should block deployment
    on Sep 11, 2023
  2. github-actions
    added
    Engineering
    HourlyKSv2
    on Sep 11, 2023

  3. OSBotify commented on Sep 11, 2023

    @OSBotify
    OSBotify
    on Sep 11, 2023
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot
    assigned
    cristipaval
    on Sep 11, 2023

  5. melvin-bot commented on Sep 11, 2023

    @melvin-bot
    melvin-botBot
    on Sep 11, 2023

    Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  6. AndrewGable
    self-assigned this
    on Sep 11, 2023
  7. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed
    HourlyKSv2
    WeeklyKSv2
    on Sep 11, 2023
  8. melvin-bot
    changed the title [-] Android - The updated Expensify logo has no background on Android notification[/-] [+][HOLD for payment 2023-09-18] Android - The updated Expensify logo has no background on Android notification[/+] on Sep 11, 2023
  9. melvin-bot
    removed
    ReviewingHas a PR in review
    on Sep 11, 2023

  10. 13 remaining items

  11. cristipaval commented on Sep 20, 2023

    @cristipaval
    cristipaval
    on Sep 20, 2023
    Contributor

    I think C+ review is the only payment due here, correct @AndrewGable? Should we apply Bug label to have someone pay?

  12. melvin-bot
    removed
    Overdue
    on Sep 20, 2023

  13. aimane-chnaif commented on Sep 20, 2023

    @aimane-chnaif
    aimane-chnaif
    on Sep 20, 2023
    Contributor

    yes for me

  14. AndrewGable
    added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 21, 2023
  15. melvin-bot
    assigned
    miljakljajic
    on Sep 21, 2023

  16. melvin-bot commented on Sep 21, 2023

    @melvin-bot
    melvin-botBot
    on Sep 21, 2023

    Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  17. melvin-bot commented on Sep 21, 2023

    @melvin-bot
    melvin-botBot
    on Sep 21, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  18. AndrewGable commented on Sep 21, 2023

    @AndrewGable
    AndrewGable
    on Sep 21, 2023
    Contributor

    @miljakljajic - @aimane-chnaif needs to get paid 🤑 - Thanks!

  19. miljakljajic commented on Sep 21, 2023

    @miljakljajic
    miljakljajic
    on Sep 21, 2023
    Contributor

    Contract sent @aimane-chnaif !

  20. melvin-bot
    added
    Overdue
    on Sep 25, 2023

  21. cristipaval commented on Sep 25, 2023

    @cristipaval
    cristipaval
    on Sep 25, 2023
    Contributor

    Is this one paid? Could we close this issue? 👀

  22. melvin-bot
    removed
    Overdue
    on Sep 25, 2023

  23. miljakljajic commented on Sep 26, 2023

    @miljakljajic
    miljakljajic
    on Sep 26, 2023
    Contributor

    I sent a contract to @aimane-chnaif in Upwork but I realise now that some of our C+ are being paid through newDot (I took a hiatus from this team). I'll get this resolved today!

  24. miljakljajic commented on Sep 26, 2023

    @miljakljajic
    miljakljajic
    on Sep 26, 2023
    Contributor

    Paid and contract ended.

  25. miljakljajic
    closed this as completedon Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions