[HOLD for payment 2023-09-04] [$1000] BUG: Rectangular white container surrounds the Google sign-in button

@rayane-djouah

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open the app (or log out if already logged in).
Navigate to the sign-in page.

Expected Result:

The Google sign-in is surrounded by a rectangular white container.

Actual Result:

The Google sign-in is not surrounded by a rectangular white container.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @rayane-djouah
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692656259550869

2023-08-21.23-02-55.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~013a33ff67a596f404
Upwork Job ID: 1693788285544824832
Last Price Increase: 2023-08-22
Automatic offers:

rayane-djouah | Contributor | 26251929
rayane-djouah | Reporter | 26251930

@greg-schroeder

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Job added to Upwork: https://www.upwork.com/jobs/~013a33ff67a596f404

@greg-schroeder

Current assignee @greg-schroeder is eligible for the External assigner, not assigning anyone new.

@parasharrajat

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Sign in with Google" button, when embedded in the Expensify web application, displayed an unwanted white background. This visual discrepancy was inconsistent with the desired dark theme of the application.

What is the root cause of that problem?

The root (:root) of the Expensify web application's document has the color-scheme: dark property set. This indicates to the browser that the content is optimized for dark color themes. The Google Sign-in button, being a third-party component rendered within an iframe, adapts its appearance based on the surrounding context's color scheme. Due to the color-scheme: dark property, the dynamically generated iframe for the Google Sign-in button defaulted to a white background, leading to the observed issue.

App/web/index.html

Lines 34 to 36 in e3074c4

    
           :root { 
        
               color-scheme: dark !important; 
        
           }

What changes do you think we should make in order to solve the problem?

To address this visual discrepancy, the following code change need to be implemented:

In the styles for the container of the Google Sign-in button,

App/src/styles/styles.js

Lines 3638 to 3648 in e3074c4

    
           googleButtonContainer: { 
        
               width: 40, 
        
               height: 40, 
        
               marginLeft: 12, 
        
               alignItems: 'center', 
        
           }, 
        
           googlePillButtonContainer: { 
        
               height: 40, 
        
               width: 219, 
        
           },

we need to introduce color-scheme property and set it to light.

googleButtonContainer: {
    ...,
    colorScheme: 'light', /* This line ensures the element uses a light color theme */
},

googlePillButtonContainer: {
    colorScheme: 'light',
...
},

By setting the color-scheme to light for the specific container of the Google Sign-in button, it is influenced to adopt a light theme, ensuring its appearance is consistent with the expected design and eliminating the unwanted white background.

Result:

What alternative solutions did you explore? (Optional)

N/A

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Reviewing label has been removed, please complete the "BugZero Checklist".

@parasharrajat

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.57-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix iframe for Google Sign-In #25645

If no regressions arise, payment will be issued on 2023-09-04. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@parasharrajat does not require payment (Eligible for Manual Requests)
@rayane-djouah requires payment offer (Contributor)
@rayane-djouah requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@parasharrajat] Determine if we should create a regression test for this bug.
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Yesterday was a holiday, will take care of this today!

@parasharrajat

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: Apple & Google Sign In #23673
[@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Apple & Google Sign In #23673 (comment)
[@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA, it seems this issue was known during the PR review.
[@parasharrajat] Determine if we should create a regression test for this bug. Yes
[@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

Go to the sign-in page.
Notice the google sign-in button on the dark theme.
Verify that no rectangular white container surrounds the Google sign-in button.

Do you agree 👍 or 👎 ?

@rayane-djouah

Issue Participants:

Issue reported by: @rayane-djouah
Contributor: @rayane-djouah
C+: @parasharrajat

Was this issue merged in time to be eligible for the speed bonus? ✅
Were their any regressions? ❌

Payment summary:

Reporter: $250
Contributor: $1,500
C+: 1,500

@parasharrajat

Filing regression test. You're in the clear to make a manual request for payment @parasharrajat. Closing.

Payment requested as per #25638 (comment)

@parasharrajat

$1,500 payment for @parasharrajat approved based on BZ summary.

Navigation Menu

Repository navigation

[HOLD for payment 2023-09-04] [$1000] BUG: Rectangular white container surrounds the Google sign-in button #25638

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

15 remaining items

Regression Test Steps

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	googleButtonContainer: {
	width: 40,
	height: 40,
	marginLeft: 12,
	alignItems: 'center',
	},

	googlePillButtonContainer: {
	height: 40,
	width: 219,
	},

[HOLD for payment 2023-09-04] [$1000] BUG: Rectangular white container surrounds the Google sign-in button #25638

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Aug 22, 2023

melvin-bot commented on Aug 22, 2023

Bug0 Triage Checklist (Main S/O)

melvin-bot commented on Aug 22, 2023

melvin-bot commented on Aug 22, 2023

melvin-bot commented on Aug 22, 2023

rayane-d commented on Aug 22, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Aug 22, 2023

15 remaining items

melvin-bot commented on Aug 28, 2023

melvin-bot commented on Aug 28, 2023

melvin-bot commented on Aug 28, 2023

greg-schroeder commented on Sep 5, 2023

parasharrajat commented on Sep 5, 2023

Regression Test Steps

greg-schroeder commented on Sep 6, 2023

greg-schroeder commented on Sep 6, 2023

parasharrajat commented on Sep 11, 2023

JmillsExpensify commented on Sep 21, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions