Skip to content

Log in - Apple & Google Sign in buttons are too close and are touching outlines #25637

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Access staging.new.epensify.com
  2. Observe sign in methods

Expected Result:

The two methods should be spaced correctly and the background should be the same as the Expensify page

Actual Result:

The two sign in methods are touching the white outline

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.56-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6172850_Log_in_methods_are_touching (1)

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Activity

  1. OSBotify commented on Aug 22, 2023

    @OSBotify
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  2. melvin-bot commented on Aug 22, 2023

    @melvin-bot

    Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

  3. marcaaron commented on Aug 22, 2023

    @marcaaron
    Contributor

    @marcochavezf seems related to #23673

  4. marcaaron commented on Aug 22, 2023

    @marcaaron
    Contributor

    Is this behind a beta? If so, maybe it is not a blocker?

  5. marcochavezf commented on Aug 22, 2023

    @marcochavezf
    Contributor

    We're already working on a solution here, I will close this one in favor of #25638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions