[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Incomplete Member Information Displayed When Hovering Over Photos in Admin Rooms

@tewodrosGirmaA

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Open app settings.
Go to the workspace section.
Create a new workspace.
Click the three-dot icon and go to the admin section.
Click the header and go to members.
Hover over member email and photos. Only email is displayed when hovering over photos, while both name and email are displayed when hovering over email.
Note: Display name must be set in settings>profile>display name with a desired first name to reproduce.

Expected Result:

Hovering over member photos should display both name and email like when hovering over email.

Actual Result:

Hovering over member photos only displays email.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.29-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
screen-capture (4).webm

Recording.1004.mp4

Expensify/Expensify Issue URL:
Issue reported by: @tewodrosGirmaA
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687003462951499

View all open jobs on GitHub

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

@flodnv

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mallenexpensify

dupe and known issue solved here @mallenexpensify #20801

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@flodnv

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@flodnv] The PR that introduced the bug has been identified. Link to the PR:
[@flodnv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@flodnv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@flodnv] Determine if we should create a regression test for this bug.
[@flodnv] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix avatar tooltip issues across the app #21026

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@flodnv

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@flodnv] The PR that introduced the bug has been identified. Link to the PR:
[@flodnv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@flodnv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@flodnv] Determine if we should create a regression test for this bug.
[@flodnv] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@mallenexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@flodnv

Greetings @flodnv, I believe the bug has been resolved. May I know if I am eligible for payment? Kindly inform me. Thank you.

@tewodrosGirmaA

📣 @tewodrosGirmaA! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.

Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@tewodrosGirmaA

@tewodrosGirmaA payment will be handled in #20822
#20822 (comment)

Thank You

Contributor details
Your Expensify account email: israeltesema45@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0142af0eda23e59363

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

Contributor details
Your Expensify account email: israeltesama45@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0142af0eda23e59363

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

Navigation Menu

Repository navigation

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Incomplete Member Information Displayed When Hovering Over Photos in Admin Rooms #20981

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

11 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Incomplete Member Information Displayed When Hovering Over Photos in Admin Rooms #20981

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 18, 2023

melvin-bot commented on Jun 18, 2023

Bug0 Triage Checklist (Main S/O)

OSBotify commented on Jun 18, 2023

melvin-bot commented on Jun 18, 2023

dhairyasenjaliya commented on Jun 19, 2023

melvin-bot commented on Jun 19, 2023

11 remaining items

melvin-bot commented on Jun 21, 2023

melvin-bot commented on Jun 22, 2023

melvin-bot commented on Jun 22, 2023

tewodrosGirmaA commented on Jun 24, 2023

melvin-bot commented on Jun 24, 2023

0xmiroslav commented on Jun 24, 2023

tewodrosGirmaA commented on Jun 24, 2023

tewodrosGirmaA commented on Jun 24, 2023

melvin-bot commented on Jun 24, 2023

tewodrosGirmaA commented on Jun 24, 2023

melvin-bot commented on Jun 24, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions