[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Name is missing in LHN tooltip

@gadhiyamanan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

Hover over profiles in LHN

Expected Result:

Should show display name w/ email in tooltip

Actual Result:

Only email / login is shown, no display name

Workaround:

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: main
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686828398711369

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0137b40d29cb6cb326
Upwork Job ID: 1669375642469900288
Last Price Increase: 2023-06-15

@Christinadobrzyn

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Hi I'm Bartek from Callstack - expert contributor group - I can work on this issue.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When hovering over avatars in LHN, display name is not displayed in the tooltio

What is the root cause of that problem?

The issue is caused by the incorrect implementation of the ReportUtils.getAccountIDForLogin method that probably left while working on switching to using accountID as keys in the personalDetails login.

What changes do you think we should make in order to solve the problem?

The root cause is here:

App/src/libs/ReportUtils.js

Lines 824 to 832 in d396430

    
           /** 
        
            * Gets the accountID for a login by looking in the ONYXKEYS.PERSONAL_DETAILS Onyx key (stored in the local variable, allPersonalDetails). If it doesn't exist in Onyx, 
        
            * then an empty string is returned. 
        
            * @param {String} login 
        
            * @returns {String} 
        
            */ 
        
           function getAccountIDForLogin(login) { 
        
               return lodashGet(allPersonalDetails, [login, 'accountID'], ''); 
        
           }

As we can see, it tries to access the personalDetails object by the login as the key. It should be changed as below:

function getAccountIDForLogin(login) {
    const keys = lodashKeys(allPersonalDetails);
    const result = lodashFind(keys, (key) => allPersonalDetails[key].login === login) || '0';
    return Number(result);
}

What alternative solutions did you explore? (Optional)

n/a

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@burczu

@burczu yeppp good catch 👍 Though I think at the end of the 3rd line we want to default to 0, not '0'

Though you did that in the return, so it's probably fine either way 👍

Actually, it must be '0' because lodashKeys returns an array of strings, so the result of lodashFind will also be a string - the fallback type should be consistent here.

PR is ready for review!

Job added to Upwork: https://www.upwork.com/jobs/~0137b40d29cb6cb326

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Reviewing label has been removed, please complete the "BugZero Checklist".

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix avatar tooltip issues across the app #21026

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@Beamanator

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
[@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.30-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix avatar tooltip issues across the app #21026

If no regressions arise, payment will be issued on 2023-06-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

@Beamanator

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
[@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@burczu] Determine if we should create a regression test for this bug.
[@burczu] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

Navigation Menu

Repository navigation

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Name is missing in LHN tooltip #20801

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

14 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	/**
	* Gets the accountID for a login by looking in the ONYXKEYS.PERSONAL_DETAILS Onyx key (stored in the local variable, allPersonalDetails). If it doesn't exist in Onyx,
	* then an empty string is returned.
	* @param {String} login
	* @returns {String}
	*/
	function getAccountIDForLogin(login) {
	return lodashGet(allPersonalDetails, [login, 'accountID'], '');
	}

[HOLD for payment 2023-06-29] [HOLD for payment 2023-06-28] Name is missing in LHN tooltip #20801

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 15, 2023

melvin-bot commented on Jun 15, 2023

Bug0 Triage Checklist (Main S/O)

burczu commented on Jun 15, 2023

burczu commented on Jun 15, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Beamanator commented on Jun 15, 2023

burczu commented on Jun 15, 2023

burczu commented on Jun 15, 2023

melvin-bot commented on Jun 15, 2023

14 remaining items

melvin-bot commented on Jun 19, 2023

melvin-bot commented on Jun 19, 2023

melvin-bot commented on Jun 21, 2023

melvin-bot commented on Jun 21, 2023

melvin-bot commented on Jun 21, 2023

melvin-bot commented on Jun 22, 2023

melvin-bot commented on Jun 22, 2023

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions