Skip to content

[Hold App#20404] 2 factor authentiaction code dissappear when switch to small screen #20611

Closed
Closed
[Hold App#20404] 2 factor authentiaction code dissappear when switch to small screen#20611
Assignees
MitchExpensify
Labels
BugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Description

@kavimuru
kavimuru
opened on Jun 12, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Action Performed:

  1. Go to Setting--> Security --> Two factor authentication
  2. Observe Recovery codes appear
  3. Resize the window to mobile view

Expected Result:

Recovery codes still display

Actual Result:

Recovery codes disappear

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-06-07.at.15.42.20.mov
Recording.946.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686127296080609

View all open jobs on GitHub

Activity

  1. kavimuru
    added
    DailyKSv2
    BugSomething is broken. Auto assigns a BugZero manager.
    on Jun 12, 2023
  2. melvin-bot
    assigned
    MitchExpensify
    on Jun 12, 2023

  3. melvin-bot commented on Jun 12, 2023

    @melvin-bot
    melvin-botBot
    on Jun 12, 2023

    Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

  4. melvin-bot commented on Jun 12, 2023

    @melvin-bot
    melvin-botBot
    on Jun 12, 2023

    Bug0 Triage Checklist (Main S/O)

    • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
    • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
      • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
    • This bug is reproducible using the reproduction steps in the OP. S/O
      • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
      • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
    • This issue is filled out as thoroughly and clearly as possible
      • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
    • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

  5. kavimuru commented on Jun 12, 2023

    @kavimuru
    kavimuru
    on Jun 12, 2023
    Author

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Two factor auth code disappear when change the screen size

    What is the root cause of that problem?

    When users press Two factor authentication in Security page, we call API EnableTwoFactorAuth to fetch recoveryCodes and show it in TwoFactorAuthentication page.
    In this page, if users change the screen size from large to small, the modal will be unmounted then mounted again, that make this function is called

    App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

    Line 54 in 79f18ec

    TwoFactorAuthActions.clearTwoFactorAuthData();

    So we clear recoveryCodes without the logic to fetch it again

    What changes do you think we should make in order to solve the problem?

    We should move this function Session.toggleTwoFactorAuth(true); from SecuritySettingsPage to below this line

    App/src/pages/settings/Security/TwoFactorAuth/CodesPage.js

    Line 52 in 79f18ec

    useEffect(() => {

    like what DisablePage component did with Session.toggleTwoFactorAuth(false);
    So when the component is mounted, we can fetch recoveryCodes again

  6. kushu7 commented on Jun 12, 2023

    @kushu7
    kushu7
    on Jun 12, 2023
    Contributor

    Related to :
    #20404
    #20522

  7. roryabraham commented on Jun 12, 2023

    @roryabraham
    roryabraham
    on Jun 12, 2023
    Contributor

    Thanks for flagging that @kushu7. Let's put this on HOLD for #20404

  8. roryabraham
    changed the title [-] 2 factor authentiaction code dissappear when switch to small screen[/-] [+][HOLD] 2 factor authentiaction code dissappear when switch to small screen[/+] on Jun 12, 2023
  9. MitchExpensify
    added
    WeeklyKSv2
    and removed
    DailyKSv2
    on Jun 13, 2023

  10. MitchExpensify commented on Jun 13, 2023

    @MitchExpensify
    MitchExpensify
    on Jun 13, 2023
    Contributor

    Switching to weekly while on hold 👍

  11. melvin-bot
    added
    Overdue
    on Jun 21, 2023

  12. MitchExpensify commented on Jun 21, 2023

    @MitchExpensify
    MitchExpensify
    on Jun 21, 2023
    Contributor

    On hold

  13. melvin-bot
    removed
    Overdue
    on Jun 21, 2023

  14. 13 remaining items

  15. mountiny commented on Jul 25, 2023

    @mountiny
    mountiny
    on Jul 25, 2023
    Contributor

    It does, that PR should resolve this issue 🤝

  16. MitchExpensify commented on Jul 25, 2023

    @MitchExpensify
    MitchExpensify
    on Jul 25, 2023
    Contributor

    🤝

  17. melvin-bot
    added
    Overdue
    on Aug 3, 2023

  18. MitchExpensify commented on Aug 9, 2023

    @MitchExpensify
    MitchExpensify
    on Aug 9, 2023
    Contributor

    Still on hold for #20404

  19. melvin-bot
    removed
    Overdue
    on Aug 9, 2023
  20. melvin-bot
    added
    Overdue
    on Aug 21, 2023

  21. MitchExpensify commented on Aug 21, 2023

    @MitchExpensify
    MitchExpensify
    on Aug 21, 2023
    Contributor

    Still on hold for #20404

    Same

  22. melvin-bot
    removed
    Overdue
    on Aug 21, 2023
  23. melvin-bot
    added
    Overdue
    on Aug 30, 2023

  24. MitchExpensify commented on Aug 30, 2023

    @MitchExpensify
    MitchExpensify
    on Aug 30, 2023
    Contributor

    Still on hold for #20404

    Same

  25. melvin-bot
    removed
    Overdue
    on Aug 30, 2023
  26. melvin-bot
    added
    Overdue
    on Sep 11, 2023

  27. MitchExpensify commented on Sep 13, 2023

    @MitchExpensify
    MitchExpensify
    on Sep 13, 2023
    Contributor

    Whoop! This was resolved in #20404

  28. MitchExpensify
    closed this as completedon Sep 13, 2023
  29. melvin-bot
    removed
    Overdue
    on Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

BugSomething is broken. Auto assigns a BugZero manager.WeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions