[HOLD #10894] Windows - Chat -Photo preview screen disappears after resizing window to full screen

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Issue found when executing PR #20440

Action Performed:

Go to https://staging.new.expensify.com/
Resize the window to a smaller window
Drag and drop a photo to the chat
On photo preview screen, resize the window to full screen

Expected Result:

Photo preview screen does not disappear

Actual Result:

Photo preview screen disappears

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.26.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6086774_bandicam_2023-06-09_22-19-16-181.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause Internal Team

Slack conversation:

View all open jobs on GitHub

@JmillsExpensify

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

Proposal

Please re-state the problem that we are trying to solve in this issue.

Image preview screen disappears after resizing window from small to full screen or vice versa

What is the root cause of that problem?

For responsiveness, we use withWindowDimensions HOC in the project.
AttachModal component is remounted when isSmallScreenWidth props(from withWindowDimensions) is changed due to the following code lines.

App/src/libs/Navigation/NavigationRoot.js

Line 66 in 035783a

key={props.isSmallScreenWidth ? 'small' : 'big'}

App/src/libs/Navigation/AppNavigator/createResponsiveStackNavigator/index.js

Lines 36 to 56 in 035783a

    
           return props.isSmallScreenWidth ? ( 
        
               <NavigationContent> 
        
                   <StackView 
        
                       // eslint-disable-next-line react/jsx-props-no-spreading 
        
                       {...props} 
        
                       state={state} 
        
                       descriptors={descriptors} 
        
                       navigation={navigation} 
        
                   /> 
        
               </NavigationContent> 
        
           ) : ( 
        
               <NavigationContent> 
        
                   <ThreePaneView 
        
                       // eslint-disable-next-line react/jsx-props-no-spreading 
        
                       {...props} 
        
                       state={state} 
        
                       descriptors={descriptors} 
        
                       navigation={navigation} 
        
                   /> 
        
               </NavigationContent> 
        
           );

This is the root cause of this issue.

What changes do you think we should make in order to solve the problem?

We store draft comments in Oynx store. Similarly, we can store the attachment in Oynx store and load attachment info when page refreshing or remounting.
In order to do this

Add Oynx key for storing pending attachment
Store the attachment in Oynx store when picked file is valid
Load the attachment info from Oynx store when mounting

Result

20522_mac_chrome.mp4

What alternative solutions did you explore? (Optional)

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

@JmillsExpensify

@JmillsExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Beamanator

Similarly, we can store the attachment in Oynx store and load attachment info when page refreshing or remounting

I like the idea, but I don't think we have a straightforward way to do that for now. I believe that this should be on HOLD for something in #10894. @Beamanator can you confirm / help find the specific issue this should be on HOLD for that will enable us to support offline image caching?

Yes, I agree. Doing that now, in fact.

Huh, I don't quite understand why this is an "offline image caching" issue - it seems like it's just about resizing the browser, right?

@JmillsExpensify

This issue has not been updated in over 15 days. @JmillsExpensify eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Still on hold for the image improvements.

Still held on image improvements

Holding for image initiative.

Same

Closing this issue in line with our decision to not prioritize resizing issues anytime soon.

Navigation Menu

Repository navigation

[HOLD #10894] Windows - Chat -Photo preview screen disappears after resizing window to full screen #20522

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Bug0 Triage Checklist (Main S/O)

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

22 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	return props.isSmallScreenWidth ? (
	<NavigationContent>
	<StackView
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...props}
	state={state}
	descriptors={descriptors}
	navigation={navigation}
	/>
	</NavigationContent>
	) : (
	<NavigationContent>
	<ThreePaneView
	// eslint-disable-next-line react/jsx-props-no-spreading
	{...props}
	state={state}
	descriptors={descriptors}
	navigation={navigation}
	/>
	</NavigationContent>
	);

[HOLD #10894] Windows - Chat -Photo preview screen disappears after resizing window to full screen #20522

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Activity

melvin-bot commented on Jun 9, 2023

melvin-bot commented on Jun 9, 2023

Bug0 Triage Checklist (Main S/O)

dummy-1111 commented on Jun 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot commented on Jun 11, 2023

melvin-bot commented on Jun 12, 2023

roryabraham commented on Jun 12, 2023

JmillsExpensify commented on Jun 14, 2023

Beamanator commented on Jun 14, 2023

22 remaining items

melvin-bot commented on Oct 6, 2023

JmillsExpensify commented on Oct 12, 2023

JmillsExpensify commented on Oct 24, 2023

JmillsExpensify commented on Nov 24, 2023

JmillsExpensify commented on Dec 13, 2023

JmillsExpensify commented on Jan 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions