Repository navigation
[Due for payment 2026-10-07] Expense - Automatic is shown on Category row when Auto-categorize new expenses is disabled #102603
Description
If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.
Version Number: 9.4.97-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #100248
Email or phone of affected tester (no customers): jsdoijnodsdisojo@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Money Requests
Action Performed:
Precondition:
- Disable Auto-categorize new expenses in Categories settings.
- Set Category to not required in Rules settings.
- Go to staging.new.expensify.com
- Open FAB > Create expense > Manual.
Expected Result:
Category field will not show Automatic because Auto-categorize new expenses is disabled.
Actual Result:
Category field shows Automatic when Auto-categorize new expenses is disabled.
Workaround:
Unknown
Platforms:
- Android: App
- Android: mWeb Chrome
- iOS: App
- iOS: mWeb Safari
- iOS: mWeb Chrome
- Windows: Chrome
- MacOS: Chrome Safari
Screenshots/Videos
Bug7273070_1790732047909.1.mp4
Applause Internal Information
Exported by: Mita Rachim
Bug ID: 7273070
Issue Owner
Current Issue Owner: @truph01Metadata
Metadata
Type
Projects
- Status
Activity
applause-bot commentedon Sep 30, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/c3bce1c884e75f7d9d544d792ca92114637afb54df7084e89e278b7da1e9af8f
melvin-bot commentedon Sep 30, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #100248
github-actions commentedon Sep 30, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Sep 30, 2026
@JmillsExpensify @truph01 you have been assigned to this deploy blocker because you reviewed the offending PR: #100248
melvin-bot commentedon Sep 30, 2026
@dukenv0307 you have been assigned to this deploy blocker because you authored the offending PR: #100248
melvin-bot commentedon Sep 30, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Sep 30, 2026
Proposal
Causing PR: [Payment due @truph01] Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization". It is in the current staging checklist. Recommendation: quick fix, not revert.
What is the root cause of that problem?
The PR added the
policy.autoCategorizeNewExpensesflag. It connected the flag only toisCategoryBeingAnalyzed(). It never connected the flag to the confirmation form's Category row.That row shows "Automatic" whenever
willAutoFillis true and the category is not required. See CategoryField.tsx:68-74. For manual expenses,willAutoFillis always true and does not check the policy. See TransactionUtils/index.ts:2820-2823.What changes do you think we should make in order to solve the problem?
In
CategoryField, stop promising "Automatic" for a manual expense whenpolicy?.autoCategorizeNewExpenses === false. An unset flag means "on". The component already receivespolicy, so this change stays in one file.The PR author (
dukenv0307) should confirm one thing. When the setting is off, does SmartScan still pick a category? If it doesn't, apply the same check to the scan case. Also apply it to theshouldKeepRightLabelWhenFilledprop.What alternative solutions did you explore? (Optional)
You could revert the PR, but it changes 27 files, including an API command, an Onyx type and a changelog action. It is also already a re-land. Revert only if the fix can't merge quickly.
The "Automatic" label itself came from [CFI] Update the Manual create expense form to use dropdown-style rows and a compact add-receipt button. That PR is already on production, so reverting it won't help.
Where the flag is and isn't respected
isCategoryBeingAnalyzed(), whichMoneyRequestViewand the missing-category violation grace period use.willFieldBeAutomaticallyFilled,categoryStateSelectorandCategoryField. These are the only places that render "Automatic" for category.Next Steps for Contributor+ team:
To accept:
@MelvinBot implement thisto create a draft PR.To refine:
@MelvinBot <your feedback>To reject: Explain why you are rejecting Melvin's proposal.
view run
m-natarajan commentedon Sep 30, 2026
Not repro, Win 11 / Chrome, v9.4.99-2
Recording.3624.mp4
[-]Expense - Automatic is shown on Category row when Auto-categorize new expenses is disabled[/-][+][Due for payment 2026-10-07] Expense - Automatic is shown on Category row when Auto-categorize new expenses is disabled[/+]melvin-bot commentedon Sep 30, 2026
@truph01
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-07. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]