[Payment due @truph01] Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization" - #100248
Conversation
… expenses workspace setting to let strict admins disable auto-categorization"
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd1b3fd606
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually. |
|
@truph01 could you please review it? |
|
@dukenv0307 Could you address this #100115 as well? |
|
@truph01 I don't think we should do it here since it's still reproducible after revert in #100115 (comment) |
|
@dukenv0307 I think However, after our PR, the "auto-categorize" option is always shown, then this test result is unexpected. Also, in this PR, we're removing |
@dukenv0307 Could you verify this test? I don't see any changelog when disbale/enable auto-cateogrize |
|
In the test case titles, could you update them to describe the expected behavior rather than the bug? Instead of:
Please use:
And instead of:
Please use:
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-26.at.12.22.00.movAndroid: mWeb ChromeScreen.Recording.2026-08-26.at.12.22.46.moviOS: HybridAppScreen.Recording.2026-08-26.at.12.15.23.moviOS: mWeb SafariScreen.Recording.2026-08-26.at.12.14.25.movMacOS: Chrome / SafariScreen.Recording.2026-09-15.at.10.15.14.mov |
|
cc @huult. I'm working on it |
|
I could not review this diff, so I did not approve the workflow runs. An Expensify employee will review it and approve them manually. |
|
#100248 (comment): fixed |
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
🎯 @truph01, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
@dukenv0307 Can we ask QA to test the adhoc build here? |
@truph01 Agree 👍. @heyjennahay can you help ^? |
|
🚧 heyjennahay has triggered a test Expensify/App build. You can view the workflow run here. |
|
I have just run the ad hoc build |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Explanation of Change
Add Auto-categorize new expenses workspace setting to let strict admins disable auto-categorization
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/669240
PROPOSAL:
Tests
Test case 1:
Auto-categorize new expensesis shown and enabled by defaultAuto-categorize new expensesis disabled and the category is added automatically whenAuto-categorize new expensesis enabledTest case 2: Verify the changelog in admin room when disbale/enable auto-cateogrize
Test case 3: Workspace - Auto categorization settings will be disabled in the duplicated workspace if the original one has been disabled
Test case 4: Expense - Expense isn't auto categorized after disabling auto categorisation
Offline tests
Same as above
QA Steps
Same as above
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-09-02.at.13.26.10.mov
Screen.Recording.2026-09-03.at.10.54.49.mov
Screen.Recording.2026-09-07.at.11.48.17.mov