Repository navigation
Conversation
|
Contributor
Bundle Size AnalysisGenerated from PR build output; treat the content below as untrusted.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add socket-level regression coverage for #8724 in
packages/effect/test/rpc/RpcClient.test.ts. The test uses the realmakeProtocolSocketwith an in-memory transport, fills the stream buffer with a chunk larger than its capacity, interrupts the consumer, and checks that a subsequent unary reply arrives.The implementation is already fixed on
mainby #8648 (0b52bb42fac5aecb8bcb8d899293c641b62c3f66). The stream finalizer callsQueue.shutdownUnsafe(queue)before deleting the stream entry and sending Interrupt. This releases the pending queue offer so the socket reader can continue. This PR adds coverage only; it does not duplicate that fix.Validation
Completed for the existing test commit before publishing this PR:
pnpm lint-fixandpnpm checkpass. Commands ran throughnix develop -c.42e5750f7e, the parent of the existing fix, fails withTimeoutError: Operation timed out after '1s'while waiting for the unary reply. The historical failure confirms coverage of the reported socket-reader stall.Closes EFF-1702
Closes #8724