Skip to content

Release a blocked stream chunk when its RpcClient consumer is interrupted - #8648

Merged
tim-smart merged 3 commits into
Effect-TS:mainfrom
dv-waynehaffenden:fix/rpc-client-abandoned-stream
Oct 1, 2026
Merged

tim-smart merged 3 commits into
Effect-TS:mainfrom
dv-waynehaffenden:fix/rpc-client-abandoned-stream

Conversation

@dv-waynehaffenden

@dv-waynehaffenden dv-waynehaffenden commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Problem

A streaming request's chunks are delivered with Queue.offerAll into a bounded buffer (streamBufferSize, 16 by default). When a chunk is larger than the space left, that offer suspends until the consumer takes. If the consumer is interrupted at that moment, the request's finalizer removes the entry and sends Interrupt, but nothing ever takes from the queue again — the offer stays suspended forever.

With a socket protocol that offer runs inside the single receive loop, so every other request on the connection stalls with it. That includes Pong: the pinger then reports a ping timeout (surfaced as SocketOpenError: timeout waiting for "open", since the message ignores the cause), the socket is torn down and reconnected, and the cycle repeats whenever a UI re-subscribes a stream while a chunk is in flight.

Fix

Shut the stream's queue down in the request finalizer. Queue.shutdownUnsafe resumes the pending offer, so the receive loop moves on. The queue is now created before the finalizer is registered so the finalizer can reach it.

Test

releases a chunk blocked on a full buffer when its stream consumer is interrupted delivers a three-value chunk into a one-slot buffer whose consumer never finishes, interrupts the consumer, and asserts the delivery completes and the Interrupt is sent. It hangs without the fix.

Closes EFF-1638

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Bundle Size Analysis

Generated from PR build output; treat the content below as untrusted.

File Name Current Size Previous Size Difference
arbitrary-combinators.ts 38.90 KB 38.90 KB 0.00 KB (0.00%)
basic.ts 7.04 KB 7.04 KB 0.00 KB (0.00%)
batching.ts 10.13 KB 10.13 KB 0.00 KB (0.00%)
brand.ts 6.72 KB 6.72 KB 0.00 KB (0.00%)
cache.ts 10.84 KB 10.84 KB 0.00 KB (0.00%)
config.ts 22.15 KB 22.15 KB 0.00 KB (0.00%)
differ.ts 21.29 KB 21.29 KB 0.00 KB (0.00%)
http-client.ts 22.27 KB 22.27 KB 0.00 KB (0.00%)
http-router.ts 33.52 KB 33.52 KB 0.00 KB (0.00%)
logger.ts 11.08 KB 11.08 KB 0.00 KB (0.00%)
metric.ts 9.02 KB 9.02 KB 0.00 KB (0.00%)
optic.ts 6.95 KB 6.95 KB 0.00 KB (0.00%)
pubsub.ts 15.16 KB 15.16 KB 0.00 KB (0.00%)
queue.ts 12.08 KB 12.08 KB 0.00 KB (0.00%)
schedule.ts 11.18 KB 11.18 KB 0.00 KB (0.00%)
schema-bigdecimal.ts 13.73 KB 13.73 KB 0.00 KB (0.00%)
schema-binary.ts 39.92 KB 39.92 KB 0.00 KB (0.00%)
schema-class.ts 21.03 KB 21.03 KB 0.00 KB (0.00%)
schema-fromJsonSchemaDocument.ts 32.06 KB 32.06 KB 0.00 KB (0.00%)
schema-representation-roundtrip.ts 27.24 KB 27.24 KB 0.00 KB (0.00%)
schema-string-transformation.ts 14.46 KB 14.46 KB 0.00 KB (0.00%)
schema-string.ts 11.99 KB 11.99 KB 0.00 KB (0.00%)
schema-template-literal.ts 16.05 KB 16.05 KB 0.00 KB (0.00%)
schema-toArbitrary.ts 38.44 KB 38.44 KB 0.00 KB (0.00%)
schema-toCodeDocument.ts 25.26 KB 25.26 KB 0.00 KB (0.00%)
schema-toCodecJson.ts 20.21 KB 20.21 KB 0.00 KB (0.00%)
schema-toEquivalence.ts 20.41 KB 20.41 KB 0.00 KB (0.00%)
schema-toFormatter.ts 20.54 KB 20.54 KB 0.00 KB (0.00%)
schema-toJsonSchemaDocument.ts 25.00 KB 25.00 KB 0.00 KB (0.00%)
schema-toRepresentation.ts 20.50 KB 20.50 KB 0.00 KB (0.00%)
schema.ts 20.25 KB 20.25 KB 0.00 KB (0.00%)
stm.ts 13.08 KB 13.08 KB 0.00 KB (0.00%)
stream.ts 9.98 KB 9.98 KB 0.00 KB (0.00%)

@changeset-bot

changeset-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b08cf9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
effect Patch
@effect/opentelemetry Patch
@effect/vitest Patch
@effect/ai-anthropic Patch
@effect/ai-openai-compat Patch
@effect/ai-openai Patch
@effect/ai-openrouter Patch
@effect/ai-typesafe Patch
@effect/atom-react Patch
@effect/atom-solid Patch
@effect/atom-vue Patch
@effect/platform-browser Patch
@effect/platform-bun Patch
@effect/platform-deno Patch
@effect/platform-node-shared Patch
@effect/platform-node Patch
@effect/sql-clickhouse Patch
@effect/sql-d1 Patch
@effect/sql-libsql Patch
@effect/sql-mssql Patch
@effect/sql-mysql2 Patch
@effect/sql-pg Patch
@effect/sql-pglite Patch
@effect/sql-sqlite-bun Patch
@effect/sql-sqlite-do Patch
@effect/sql-sqlite-node Patch
@effect/sql-sqlite-react-native Patch
@effect/sql-sqlite-wasm Patch
@effect/docgen Patch
@effect/doctest Patch
@effect/openapi-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tim-smart
tim-smart merged commit 0b52bb4 into Effect-TS:main Oct 1, 2026
8 of 10 checks passed
@effect-bot effect-bot mentioned this pull request Oct 1, 2026

This branch is waiting to be deployed

1 waiting deployment
fork — b08cf9dd Waiting Oct 1, 2026 by tim-smart via approval-gate #16994
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.0 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants