chore(antithesis): Pin all rig container dependencies#2017
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This comment has been minimized.
This comment has been minimized.
Regression Detector (Agent Data Plane)Run ID: Optimization Goals: ✅ No significant changes detectedFine details of change detection per experiment (5)Experiments configured
Bounds Checks: ✅ Passed (5)
ExplanationA change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression ( |
f116dac to
c2c153c
Compare
c545860 to
a41b667
Compare
c2c153c to
eb51b1e
Compare
a41b667 to
60b0777
Compare
tobz
left a comment
There was a problem hiding this comment.
Hmmm, do you have any examples of what things looked like before this?
It would make sense to me if we had an out-of-date pinned version of ca-certificates, but I'm not seeing how the versionless dependency reference would end up giving us an out-of-date version... and given that, pinning everything feels a bit labored/fragile.
eb51b1e to
672554d
Compare
60b0777 to
321d5b0
Compare
672554d to
e9fb9a3
Compare
321d5b0 to
2dbcec5
Compare
e9fb9a3 to
c5cbc5a
Compare
2dbcec5 to
83e3b6f
Compare
c5cbc5a to
732b36f
Compare
83e3b6f to
f820609
Compare
732b36f to
65c8858
Compare
0a91d85 to
8bfacdd
Compare
65c8858 to
896334b
Compare
8bfacdd to
4b25d9b
Compare
ec739c1 to
5b529b3
Compare
4b25d9b to
58adc65
Compare
5b529b3 to
c727931
Compare
58adc65 to
342357b
Compare
c727931 to
e8b9907
Compare
e8b9907 to
4b59000
Compare
342357b to
dabe522
Compare
4b59000 to
3800920
Compare
dabe522 to
174ee7e
Compare
This commit updates the harness driver to build dogstatsd to a byte limit, in the manner of datadog/lading. I have been unable to investigate SMPTNG-7611 well owing to the error log emission by Datadog Agent. I've added property tests to assert the payload limit is obeyed, accepting that this means making the dogstatsd generator pure with regard to Rng and may not use antithesis SDK's random_* directly.
3800920 to
9fe3971
Compare
3e468fb to
51b0168
Compare
@tobz Ah yeah so this is me misunderstanding the deal with AWS-LC, agreed on your read. I'm going to rework this PR to address the artifact mismatch under test, will ping when this is ready to go. |
e9baf6d to
4eb20eb
Compare
Binary Size Analysis (Agent Data Plane)Baseline: dff1654 · Comparison: bc500ec · diff ✅ Binary size difference within thresholdChanges by Module
Detailed Symbol Changes |
f23db7c to
6f51ee0
Compare
This commit modifies the rig so that we are always using Datadog Agent + ADP as the SUT. In the general case this is ADP-on and in the differential case this is between ADP-off and ADP-on. We make one small modification to the Datadog Agent container in that we do not restart ADP if it faults, giving antithesis a cleaner exit signal. I have tried to make all our containers sync'ed properly with the rest of the project, as they had drifted. If I understand the auto-update proecess correctly this should all stay square from now on. From Vector I have ported the launch script and, hopefully, this makes it a little more clear how to launch these things. Of interest I have changed the endpoint and turned OFF node faults for both scenarios as we cannot ensure that, especially in the differential case, that faults happen at the same instant and are fair.
6f51ee0 to
bc500ec
Compare

Summary
This commit modifies the rig so that we are always using Datadog Agent +
ADP as the SUT. In the general case this is ADP-on and in the
differential case this is between ADP-off and ADP-on. We make one small
modification to the Datadog Agent container in that we do not restart
ADP if it faults, giving antithesis a cleaner exit signal.
I have tried to make all our containers sync'ed properly with the rest
of the project, as they had drifted. If I understand the auto-update
proecess correctly this should all stay square from now on. From Vector
I have ported the launch script and, hopefully, this makes it a little
more clear how to launch these things. Of interest I have changed the
endpoint and turned OFF node faults for both scenarios as we cannot
ensure that, especially in the differential case, that faults happen at
the same instant and are fair.
Change Type
How did you test this PR?
References