Skip to content

chore(antithesis): Add Pyld25, series are not empty#1961

Draft
blt wants to merge 1 commit into
blt/chore_antithesis_add_two_new_pyld_propertiesfrom
blt/chore_antithesis_add_pyld25_series_are_not_empty
Draft

chore(antithesis): Add Pyld25, series are not empty#1961
blt wants to merge 1 commit into
blt/chore_antithesis_add_two_new_pyld_propertiesfrom
blt/chore_antithesis_add_pyld25_series_are_not_empty

Conversation

@blt

@blt blt commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

How did you test this PR?

References

This commit adds a new simple payload property asserting that
series if shipped are not empty. It's not really a correctness
bug per se but it is wasteful.

blt commented Jul 1, 2026

Copy link
Copy Markdown
Contributor Author

@dd-octo-sts dd-octo-sts Bot added the area/test All things testing: unit/integration, correctness, SMP regression, etc. label Jul 1, 2026
@datadog-datadog-us1-prod

This comment has been minimized.

@pr-commenter

pr-commenter Bot commented Jul 1, 2026

Copy link
Copy Markdown

Binary Size Analysis (Agent Data Plane)

Baseline: 4b4f85a · Comparison: 4b011df · diff
Analysis Configuration: stripped binaries · Pass/Fail Threshold: +5%
Sizes: 40.85 MiB (baseline) vs 40.86 MiB (comparison)
Size Change: +1.15 KiB (+0.00%)

✅ Binary size difference within threshold

Changes by Module
Module File Size Symbols
anon.42e3673cf5fb968fa55278145836f476.0.llvm.16455624338754674644 +9.46 KiB 1
anon.d35bf39ab8c1a6f621834974fe00c369.0.llvm.18152056829563145063 -9.46 KiB 1
anon.3e8abb0d43609c327bb6ada2c11ec275.490.llvm.14782171952218218241 +4.39 KiB 1
anon.6400dc8986801d1eb1eac2dc4ae4b571.19.llvm.14359594917004869863 -4.39 KiB 1
anon.91b5edabbe6da643347782939de6a341.560.llvm.1974641926617444469 +3.89 KiB 1
anon.0cdb6c17c6f65ce5d46409fbadd031b9.210.llvm.2224256004584807259 -3.89 KiB 1
anon.fbb1dc57653c0fdbc830c6923948c66d.1513.llvm.16751650923260521783 +2.38 KiB 1
anon.8f296a3c82e85bd0d7746bc6848d9ce4.845.llvm.11000487001760752350 -2.38 KiB 1
anon.fbb1dc57653c0fdbc830c6923948c66d.512.llvm.16751650923260521783 +1.77 KiB 1
anon.fbb1dc57653c0fdbc830c6923948c66d.512.llvm.441118841613340164 -1.77 KiB 1
anon.3e8abb0d43609c327bb6ada2c11ec275.577.llvm.14782171952218218241 +1.69 KiB 1
anon.07c4bb9ce5ce61a5c762f558e396468b.71.llvm.14285062802314426476 -1.69 KiB 1
anon.3e8abb0d43609c327bb6ada2c11ec275.610.llvm.14782171952218218241 +1.51 KiB 1
anon.18e25a28d88f8b7e1c6e94d661c677b2.630.llvm.9221751006608382098 -1.51 KiB 1
anon.f1e6606b43835830977b2bd85c935a67.347.llvm.18167608181582160845 -1.40 KiB 1
anon.81a3afd6b60d98862100d32091c6256b.17.llvm.13563810541694556600 +1.40 KiB 1
anon.42e3673cf5fb968fa55278145836f476.85.llvm.16455624338754674644 +1.26 KiB 1
anon.0f0acd27514c68ee01ad19c408265557.90.llvm.17649990376026517311 +1.26 KiB 1
anon.0f0acd27514c68ee01ad19c408265557.94.llvm.17649990376026517311 -1.26 KiB 1
anon.3e8abb0d43609c327bb6ada2c11ec275.72.llvm.10747916521025211526 -1.26 KiB 1
Detailed Symbol Changes
    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [NEW] +9.46Ki  [NEW]     +81    anon.42e3673cf5fb968fa55278145836f476.0.llvm.16455624338754674644
  [NEW] +4.75Ki  [NEW]     +49    core::ptr::drop_in_place<tower::util::map_future::MapFuture<axum::util::MapIntoResponse<tower::util::map_request::MapRequest<otlp_protos::otlp_include::opentelemetry::proto::collector::metrics::v1::metrics_service_server::MetricsServiceServer<saluki_components::common::otlp::GrpcServiceImpl<saluki_components::sources::otlp::SourceHandler>>,tonic::service::router::Routes::add_service<otlp_protos::otlp_include::opentelemetry::proto::collector::metrics::v1::metrics_service_server::MetricsServiceServer<saluki_components::common::otlp::GrpcServiceImpl<saluki_components::sources::otlp::SourceHandler>>>::{{closure}}>>,tower::util::boxed_clone_sync::BoxCloneSyncService<http::request::Request<axum_core::body::Body>,http::response::Response<axum_core::body::Body>,core::convert::Infallible>::new<axum::util::MapIntoResponse<tower::util::map_request::MapRequest<otlp_protos::otlp_include::opentelemetry::proto::collector::met
  [NEW] +4.39Ki  [NEW]     +74    anon.3e8abb0d43609c327bb6ada2c11ec275.490.llvm.14782171952218218241
  [NEW] +3.89Ki  [NEW]     +96    anon.91b5edabbe6da643347782939de6a341.560.llvm.1974641926617444469
  [NEW] +2.38Ki  [NEW]     +76    anon.fbb1dc57653c0fdbc830c6923948c66d.1513.llvm.16751650923260521783
  [NEW] +1.77Ki  [NEW] +1.68Ki    anon.fbb1dc57653c0fdbc830c6923948c66d.512.llvm.16751650923260521783
  [NEW] +1.69Ki  [NEW]     +90    anon.3e8abb0d43609c327bb6ada2c11ec275.577.llvm.14782171952218218241
  [NEW] +1.51Ki  [NEW]     +91    anon.3e8abb0d43609c327bb6ada2c11ec275.610.llvm.14782171952218218241
  [NEW] +1.40Ki  [NEW]     +74    anon.81a3afd6b60d98862100d32091c6256b.17.llvm.13563810541694556600
  [NEW] +1.26Ki  [NEW]     +22    anon.42e3673cf5fb968fa55278145836f476.85.llvm.16455624338754674644
  [NEW] +1.26Ki  [NEW]     +22    anon.0f0acd27514c68ee01ad19c408265557.90.llvm.17649990376026517311
  -0.1% -1.39Ki  -0.0%     -44    [2769 Others]
  [DEL] -1.40Ki  [DEL]     -74    anon.f1e6606b43835830977b2bd85c935a67.347.llvm.18167608181582160845
  [DEL] -1.51Ki  [DEL]     -91    anon.18e25a28d88f8b7e1c6e94d661c677b2.630.llvm.9221751006608382098
  [DEL] -1.69Ki  [DEL]     -90    anon.07c4bb9ce5ce61a5c762f558e396468b.71.llvm.14285062802314426476
  [DEL] -1.77Ki  [DEL] -1.68Ki    anon.fbb1dc57653c0fdbc830c6923948c66d.512.llvm.441118841613340164
  [DEL] -2.38Ki  [DEL]     -76    anon.8f296a3c82e85bd0d7746bc6848d9ce4.845.llvm.11000487001760752350
  [DEL] -3.89Ki  [DEL]     -96    anon.0cdb6c17c6f65ce5d46409fbadd031b9.210.llvm.2224256004584807259
  [DEL] -4.39Ki  [DEL]     -74    anon.6400dc8986801d1eb1eac2dc4ae4b571.19.llvm.14359594917004869863
  [DEL] -4.74Ki  [DEL]     -49    core::ptr::drop_in_place<tower::util::map_future::MapFuture<axum::util::MapIntoResponse<tower::util::map_request::MapRequest<otlp_protos::otlp_include::opentelemetry::proto::collector::trace::v1::trace_service_server::TraceServiceServer<saluki_components::common::otlp::GrpcServiceImpl<saluki_components::sources::otlp::SourceHandler>>,tonic::service::router::Routes::add_service<otlp_protos::otlp_include::opentelemetry::proto::collector::trace::v1::trace_service_server::TraceServiceServer<saluki_components::common::otlp::GrpcServiceImpl<saluki_components::sources::otlp::SourceHandler>>>::{{closure}}>>,tower::util::boxed_clone_sync::BoxCloneSyncService<http::request::Request<axum_core::body::Body>,http::response::Response<axum_core::body::Body>,core::convert::Infallible>::new<axum::util::MapIntoResponse<tower::util::map_request::MapRequest<otlp_protos::otlp_include::opentelemetry::proto::collector::trace::v1::trac
  [DEL] -9.46Ki  [DEL]     -81    anon.d35bf39ab8c1a6f621834974fe00c369.0.llvm.18152056829563145063
  +0.0% +1.15Ki  [ = ]       0    TOTAL

@pr-commenter

pr-commenter Bot commented Jul 1, 2026

Copy link
Copy Markdown

Regression Detector (Agent Data Plane)

Run ID: 8d7a3a7e-cfe6-426b-bc4e-3e2f69f096a5
Baseline: 4b4f85ac · Comparison: 4b011df3 · diff

Optimization Goals: ✅ No significant changes detected

Fine details of change detection per experiment (5)

Experiments configured erratic: true are tagged (ignored) and skipped when determining which experiments regressed or improved. Experiments which are detected as erratic at runtime are tagged (erratic) to flag that the run's sample dispersion was high, but their regression / improvement signal still counts.

experiment goal Δ mean % links
quality_gates_rss_dsd_low memory ⚪ +0.29 metrics profiles logs
quality_gates_rss_dsd_medium memory ⚪ +0.02 metrics profiles logs
quality_gates_rss_idle memory ⚪ -0.01 metrics profiles logs
quality_gates_rss_dsd_heavy memory ⚪ -0.13 metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory ⚪ -0.18 metrics profiles logs
Bounds Checks: ✅ Passed (5)
experiment check replicates observed links
quality_gates_rss_dsd_heavy memory_usage 10/10 ✅ 131 MiB ≤ 140 MiB metrics profiles logs
quality_gates_rss_dsd_low memory_usage 10/10 ✅ 42.9 MiB ≤ 50 MiB metrics profiles logs
quality_gates_rss_dsd_medium memory_usage 10/10 ✅ 64.7 MiB ≤ 75 MiB metrics profiles logs
quality_gates_rss_dsd_ultraheavy memory_usage 10/10 ✅ 191 MiB ≤ 200 MiB metrics profiles logs
quality_gates_rss_idle memory_usage 10/10 ✅ 28.5 MiB ≤ 40 MiB metrics profiles logs
Explanation

A change is flagged as a regression when |Δ mean %| > 5.00% in the regressing direction for its optimization goal AND SMP marks the experiment as a regression (is_regression: true). Improvements use the matching criteria for the improving direction. Experiments configured erratic: true (tagged (ignored)) are skipped outright; experiments detected as erratic at runtime (tagged (erratic)) still count, since that flag describes sample dispersion rather than directional certainty. The Δ mean % cell is colored accordingly: 🟢 = improvement, 🔴 = regression, ⚪ = neutral. Reduction in CPU or memory is an improvement; reduction in ingress throughput is a regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test All things testing: unit/integration, correctness, SMP regression, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant