[RUM-16633] Add wildcard host pattern matching to WebView tracking by barboraplasovska · Pull Request #2963 · DataDog/dd-sdk-ios

barboraplasovska · 2026-06-01T15:02:43Z

What and why?

Adds a new WebViewTracking.enable(webView:hostPatterns:[String]) overload that accepts wildcard pattern strings like "*.example.com" or "preview-*.shopist.io". Customers currently cannot configure WebView tracking for dynamic hostnames (ephemeral preview URLs, multi-tenant subdomain fleets) — the existing hosts: API only supports exact matches and subdomain-suffix matching.

This is the iOS side of RUM-15826. Browser SDK counterpart: DataDog/browser-sdk#4703

How?

A new optional getAllowedWebViewHostPatterns?() method is injected into the bridge alongside the existing getAllowedWebViewHosts(), which keeps its current shape forever. Browser SDK detects the new method via typeof === 'function' and evaluates patterns using plain string operations — no regex engine involved on any platform.

Patterns with more than one * are dropped with a console warning. Patterns are lowercased. The existing enable(webView:hosts:) path is byte-for-byte unchanged.

Review checklist

Feature or bugfix MUST have appropriate tests (unit, integration)
Make sure each commit and the PR mention the Issue number or JIRA reference
Add CHANGELOG entry for user facing changes
Add Objective-C interface for public APIs - see our guidelines (internal)
Run make api-surface when adding new APIs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3554605ce8

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

gonzalezreal

Could you also update api-surface-objc for the new Obj-C overload?

api-surface-swift has enable(webView:hostPatterns:logsSampleRate:in:), but api-surface-objc still only has the old hosts: overload.

kikoveiga · 2026-06-08T11:24:30Z

+
+        injectUserScript(on: webView, in: core, using: elements, isTraceSampled: isTraceSampled)
+
+        core.telemetry.usage(event: .trackWebView)


We can't distinguish the usage of the new vs old API. Should we think about adding a flag usesPatterns to the event?

Good idea! We can do this in a follow-up PR since it required a schema change.

…f a separate method

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 195ddc5c8a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-06-08T13:24:34Z

+        let allowedWebViewHostsString = validPatterns
+            .map { "\"\($0)\"" }
+            .joined(separator: ",")


Expose patterns through the bridge's pattern API

When enable(webView:hostPatterns:) is used, these wildcard values are serialized into the existing hosts payload, so the injected bridge still only exposes getAllowedWebViewHosts(). The Browser SDK side distinguishes wildcard patterns via the new optional getAllowedWebViewHostPatterns() hook (leaving getAllowedWebViewHosts() for exact/suffix hosts), so pages on hosts like preview-123.example.com will continue evaluating "preview-*.example.com" as a literal host and the WebView bridge will be disabled for the main use case of this API.

Useful? React with 👍 / 👎.

This is not correct, there's no getAllowedWebViewHostPatterns() in the browser-sdk PR.

gonzalezreal

LGTM!
One small changelog issue remains: this PR is listed under 3.12.0, which is already released, and it also duplicates the #2859 and #2956 entries.

Could you move the #2963 entry to Unreleased and remove the duplicate lines

barboraplasovska force-pushed the bplasovska/RUM-15826/webview-wildcard-matching branch from 2bfc211 to 3554605 Compare June 2, 2026 13:52

This comment has been minimized.

Sign in to view

barboraplasovska marked this pull request as ready for review June 4, 2026 11:39

barboraplasovska requested review from a team as code owners June 4, 2026 11:39

barboraplasovska mentioned this pull request Jun 4, 2026

✨RUM-16635 Add wildcard host pattern matching to WebView event bridge DataDog/browser-sdk#4703

Merged

5 tasks

chatgpt-codex-connector Bot reviewed Jun 4, 2026

View reviewed changes

Comment thread DatadogWebViewTracking/Sources/WebViewTracking.swift Outdated

Comment thread DatadogWebViewTracking/Sources/ObjC/WebViewTracking+objc.swift

barboraplasovska changed the title ~~[RUM-15826] Add wildcard host pattern matching to WebView tracking~~ [RUM-16633] Add wildcard host pattern matching to WebView tracking Jun 4, 2026

barboraplasovska force-pushed the bplasovska/RUM-15826/webview-wildcard-matching branch from 3554605 to b5fd77c Compare June 4, 2026 13:01

gonzalezreal reviewed Jun 4, 2026

View reviewed changes

Comment thread DatadogWebViewTracking/Sources/WebViewTracking.swift

Comment thread CHANGELOG.md Outdated

barboraplasovska force-pushed the bplasovska/RUM-15826/webview-wildcard-matching branch from c6520c8 to 2e27429 Compare June 5, 2026 08:47

barboraplasovska requested a review from gonzalezreal June 5, 2026 08:48

gonzalezreal reviewed Jun 5, 2026

View reviewed changes

barboraplasovska requested a review from gonzalezreal June 5, 2026 09:29

gonzalezreal previously approved these changes Jun 5, 2026

View reviewed changes

barboraplasovska requested a review from maxep June 8, 2026 11:25

kikoveiga reviewed Jun 8, 2026

View reviewed changes

barboraplasovska dismissed gonzalezreal’s stale review via 60ce6a0 June 8, 2026 13:18

barboraplasovska added 6 commits June 8, 2026 15:18

[RUM-16633] Add wildcard host pattern matching to WebView tracking

f1bfe79

[RUM-16633] Put wildcard patterns in getAllowedWebViewHosts instead o…

71ed7ec

…f a separate method

RUM-15826 Fix CHANGELOG

99dc862

RUM-15826: Validate patterns

c1cef65

RUM-15826 Update api surface

022d783

RUM-15826 Extract repeating code

195ddc5

barboraplasovska force-pushed the bplasovska/RUM-15826/webview-wildcard-matching branch from 60ce6a0 to 195ddc5 Compare June 8, 2026 13:18

barboraplasovska requested review from gonzalezreal and kikoveiga June 8, 2026 13:23

chatgpt-codex-connector Bot reviewed Jun 8, 2026

View reviewed changes

gonzalezreal previously approved these changes Jun 9, 2026

View reviewed changes

RUM-15826 Fix changelog after rebase

d43e0a1

barboraplasovska dismissed gonzalezreal’s stale review via d43e0a1 June 9, 2026 07:24

barboraplasovska requested a review from gonzalezreal June 9, 2026 07:24

gonzalezreal approved these changes Jun 9, 2026

View reviewed changes

kikoveiga approved these changes Jun 9, 2026

View reviewed changes

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: waiting label Jun 9, 2026

barboraplasovska mentioned this pull request Jun 9, 2026

RUM-16667 Add wildcard host pattern matching to first-party hosts tracing #2981

Open

5 tasks

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: waiting mergequeue-status: queued labels Jun 9, 2026

gh-worker-dd-mergequeue-cf854d Bot merged commit e9c127d into develop Jun 9, 2026
21 checks passed

gh-worker-dd-devflow-36fce6 Bot removed the mergequeue-status: in_progress label Jun 9, 2026

gh-worker-dd-mergequeue-cf854d Bot deleted the bplasovska/RUM-15826/webview-wildcard-matching branch June 9, 2026 16:59

gh-worker-dd-devflow-36fce6 Bot added the mergequeue-status: done label Jun 9, 2026

This was referenced Jun 12, 2026

RUM-16634: Add wildcard host pattern matching to WebViewTracking DataDog/dd-sdk-android#3537

Closed

RUM-16634: Add wildcard host pattern matching to WebViewTracking DataDog/dd-sdk-android#3540

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[RUM-16633] Add wildcard host pattern matching to WebView tracking#2963

[RUM-16633] Add wildcard host pattern matching to WebView tracking#2963
gh-worker-dd-mergequeue-cf854d[bot] merged 7 commits into
developfrom
bplasovska/RUM-15826/webview-wildcard-matching

barboraplasovska commented Jun 1, 2026 •

edited by atlassian Bot

Loading

Uh oh!

This comment has been minimized.

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gonzalezreal left a comment

Uh oh!

Uh oh!

Uh oh!

kikoveiga Jun 8, 2026

Uh oh!

barboraplasovska Jun 8, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 8, 2026

Uh oh!

kikoveiga Jun 9, 2026

Uh oh!

gonzalezreal left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		injectUserScript(on: webView, in: core, using: elements, isTraceSampled: isTraceSampled)

		core.telemetry.usage(event: .trackWebView)

Conversation

barboraplasovska commented Jun 1, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What and why?

How?

Review checklist

Uh oh!

This comment has been minimized.

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gonzalezreal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kikoveiga Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

barboraplasovska Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 8, 2026

Choose a reason for hiding this comment

Uh oh!

kikoveiga Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

gonzalezreal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

barboraplasovska commented Jun 1, 2026 •

edited by atlassian Bot

Loading