RUM-16634: Add wildcard host pattern matching to WebViewTracking#3540
Draft
kikoveiga wants to merge 1 commit into
Draft
RUM-16634: Add wildcard host pattern matching to WebViewTracking#3540kikoveiga wants to merge 1 commit into
WebViewTracking#3540kikoveiga wants to merge 1 commit into
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3030c6a1ba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3540 +/- ##
===========================================
+ Coverage 72.40% 72.43% +0.03%
===========================================
Files 967 968 +1
Lines 35717 35762 +45
Branches 5967 5970 +3
===========================================
+ Hits 25858 25902 +44
+ Misses 8200 8198 -2
- Partials 1659 1662 +3
🚀 New features to boost your workflow:
|
3120dfd to
363dc08
Compare
363dc08 to
ec19467
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WebViewTracking.enableWithPatternsAPI that accepts wildcard host patterns (e.g.,"*.example.com,"preview-*.shopist.io") in addition to plain hosts. Patterns are validated on our side and then transmitted to the Browser SDK through the existinggetAllowedWebViewHosts()bridge.HostPatternValidatortodd-sdk-android-corewhich handles validating and normalizing wildcard patterns. It lives in thecoreso the incoming first-party-hosts widlcard matching work can reuse it.Motivation
Customers weren't able to easily enumerate hostnames loaded in a WebView such as ephemeral preview URLs, multi-tenant subdomains.
Additional Notes
iOS PR: DataDog/dd-sdk-ios#2963
Broswer PR: DataDog/browser-sdk#4703
Review checklist (to be filled by reviewers)