Repository navigation
refactor(api): move task and control routes into hq_routes (ARCH-10d) - #250
Merged
Merged
Conversation
Move the five remaining HQ v1 dispatch arms (task assignment GET/POST, claim, checkpoint, control) verbatim from api.rs into hq_routes::handle, with an exact method+segment ownership pattern for each. Completes the ARCH-10 route extraction. Add the ARCH-10d spec. No-Test: mechanical move of existing arms; behavior covered by the existing API, FakeBackend and scoped-credential tests. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
Queued — the merge queue status continues in this comment ↓. |
Owner
Author
|
@Mergifyio queue |
This was referenced Oct 3, 2026
Contributor
Merge Queue Status
This pull request spent 37 minutes 19 seconds in the queue, including 26 minutes 44 seconds running CI. Required conditions to merge
|
This was referenced Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dieser PR verschiebt die letzten fünf HQ-v1-Routen für Zuweisung, Claim, Checkpoint und Steuerung in das bestehende Routenmodul.
Der Quellvergleich zeigt unveränderte Routeninhalte; das Verhalten der laufenden App wurde hier nicht gemessen.
Zwei unabhängige Reviews haben diesen Commit geprüft; die Freigabe läuft über die getestete Merge-Warteschlange.
Report
Scope
ARCH-10d, the final five existing HQ arms. Base
1334b70a0e05de018270369ee57d6a77a2dcf010; candidatec7225c57f3da9f4b7c022aafed94fe4dc79c3b27. Three files, +108/-83 = 191 diff lines including the 16-line spec.The 83 lines removed from api.rs are copied literally into hq_routes::handle. Ownership adds exact full-slice patterns for GET/POST task assignment, POST task claim/checkpoint and POST control. Existing ownership and outer delegation order remain unchanged. Wrong method/length and siblings keep the existing None fallback.
AssignmentRequest deserialization/errors/envelopes, owner/escalation/fence/status/detail mapping, control projectId/action/backend argument order, continuous_error and continuous_response remain unchanged. No schema, store, auth, credential, policy, M4 activation or new behavior.
No-Test: mechanical moveis the approved ARCH-10 rationale; existing API/FakeBackend/scoped credential tests remain unchanged.Evidence
Author observed as Claude Sonnet 5.5 in native CLI init (2026-10-03 22:33:40 CEST); standard subscription route, no Fast Mode or installation.
/home/pa/wt/srv-arch10d-hq-task-control, clean committed candidate before full gate invocation.bash scripts/ci/gates.sh lane precommit-> exit 0 before commit; gitleaks secret scan passed, no leaks.bash scripts/ci/gates.sh lane prepush-> direct exit 0, 22:34:31–22:37:23 CEST, 172 s, 11 green gates. Full log/tmp/prepush10d.log, header HEAD c7225c5; Rust footer 1705 passed / 7 skipped.git ls-remote origin claude/arch-10d-hq-task-controlequals the full candidate SHA.git diff --check <base> <candidate>-> exit 0.Existing node_modules linked only after matching package/lock bytes; inventory had extraneous entries, no installation claimed.
Review disposition — Tier A, round 1 (coordinator)
ACCEPT for exact candidate
c7225c57f3da9f4b7c022aafed94fe4dc79c3b27against1334b70a0e05de018270369ee57d6a77a2dcf010, 2026-10-03 23:04 CEST. Both complete first-round independent vendor reports read by Root:Confirmed introduced findings: none; accepted fixes: none needed; rejected hypotheses: above with fixed-source evidence. INFO: reviewed existing control/assignment/FakeBackend tests do not certify real runtime; reviewer did not establish direct claim/checkpoint coverage within its inspected test region, no exhaustive absence claim. This baseline limitation is not an introduced regression and does not require mirrored mechanical-move tests.
Two independent non-Claude vendors satisfy TierA for this unchanged candidate. No high finding, no second round. Root author evidence remains own committed-head prepush0/172s/11green/full log, secret scan0, foregroundpush0/remoteSHA match. Ready through Mergify is authorized while main remains green; actual PR CI/real merge-queue Windows/merge still pending. Later code changes invalidate affected evidence.
NICHT ABGEDECKT
Linux own prepush only: Windows cfg tests/Clippy require the real merge-queue Windows lane; an ordinary PR Windows success is a stub. Full lane linux, browser smoke, frontend build, workflow gates and external services were not proven by this run.
No running-app, GUI, installed-build, screenshot or runtime acceptance. Reviewer source reads do not prove runtime behavior or exhaustive existing-test coverage.
Graph tools were not advertised; project/generation/index coverage UNKNOWN. Bounded source fallback only.