Repository navigation
merge queue: checking #1915 on main (f060314) - #1916
Closed
mergify[bot] wants to merge 7 commits into
Closed
mergify[bot] wants to merge 7 commits into
mergify[bot] wants to merge 7 commits into
Conversation
Exercise the mounted App at the Tauri boundary before implementing LIVE. All four new cases fail on the missing live launcher at the exact base. Plan-ID: KR-08c-2b-LIVE Test-First: src/screens/terminal/TerminalRoute.test.tsx::appends an explicit live launch without replacing existing worker tabs Test-First: src/screens/terminal/TerminalRoute.test.tsx::fences live insertion before exit subscription Test-First: src/screens/terminal/TerminalRoute.test.tsx::retains live launch failure across dismissal restore and remount until acknowledgement Co-Authored-By: GPT-6 Astra <noreply@openai.com>
Reuse the shared pending guard and retained request feedback in live views. Track explicit route-local insertion before exit subscription settlement, normalize the worker link and close the mounted chooser after success. Keep chooser errors in the action strip without covering the viewer. Plan-ID: KR-08c-2b-LIVE Test-First: src/screens/terminal/TerminalRoute.test.tsx::appends an explicit live launch without replacing existing worker tabs Test-First: src/screens/terminal/TerminalRoute.test.tsx::fences live insertion before exit subscription Test-First: src/screens/terminal/TerminalRoute.test.tsx::retains live launch failure across dismissal restore and remount until acknowledgement Test-First: src/screens/terminal/TerminalRoute.test.tsx::keeps the same request pending across empty live and empty subscription views Co-Authored-By: GPT-6 Astra <noreply@openai.com>
Resolve the event-name gate finding without changing test expectations. Plan-ID: KR-08c-2b-LIVE Test-First: src/screens/terminal/TerminalRoute.test.tsx::fences live insertion before exit subscription Test-First: src/screens/terminal/TerminalRoute.test.tsx::keeps the same request pending across empty live and empty subscription views Co-Authored-By: GPT-6 Astra <noreply@openai.com>
Retain all deferred completions so assertion failures cannot leave additional IPC promises pending during unconditional public cleanup. Plan-ID: KR-08c-2b-LIVE Test-First: src/screens/terminal/TerminalRoute.test.tsx::fences live insertion before exit subscription Test-First: src/screens/terminal/TerminalRoute.test.tsx::keeps the same request pending across empty live and empty subscription views Co-Authored-By: GPT-6 Astra <noreply@openai.com>
Expose R1915-C4 through the mounted App and Tauri boundary: a pending ad-hoc insertion must retain the busy restore panel and restart result. The regression compiles and fails against reviewed production 99d9478. Plan-ID: KR-08c-2b-LIVE Test-First: src/screens/terminal/TerminalRoute.test.tsx::preserves an explicit restart and its restore panel when a pending launch inserts Co-Authored-By: OpenAI gpt-6-astra <noreply@openai.com>
Use the existing anchored popover without growing the live action strip. Keep a newer explicit restart and restore panel intact during ad-hoc insertion. Disarm settled launch snapshots only after checking committed session state, preserving insertion-before-subscription observation. Address R1915-C1/C2/C4/C5 and update the package's pending review status. Plan-ID: KR-08c-2b-LIVE Test-First: src/screens/terminal/TerminalRoute.test.tsx::preserves an explicit restart and its restore panel when a pending launch inserts Co-Authored-By: OpenAI gpt-6-astra <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a merge queue draft opened by Mergify. Nobody needs to act on it.
Mergify opened it for batch sophisticated-tapenade-en13v5 of the
defaultqueue, to test #1915 before it merges intomain. Pushing to this branch or closing this pull request removes #1915 from the queue.What this draft tests
Mergify checks that #1915 still passes CI on top of
main. CI runs on this draft's code, built in this order:mainatf060314🎉 Where it stands: checks passed
CI passed on this draft.
Follow the
defaultqueue in the dashboardWhat happens next
mainand closes this draft.Metadata for CI tooling, read by
mergify ciRequired conditions of queue rule
defaultfor mergecheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergemain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge ProtectionsRequired conditions to stay in the queue
-conflict-draftbase = maincheck-success = gates (linux)check-success = gates (windows)check-success = red-firstgithub-review-approved[🛡 GitHub repository ruleset rulemain-pr-required-checks]label != do-not-mergelabel = review-okmain-pr-required-checks]:check-success = @github-actions/gates (linux)check-neutral = @github-actions/gates (linux)check-skipped = @github-actions/gates (linux)main-pr-required-checks]:check-success = @github-actions/gates (windows)check-neutral = @github-actions/gates (windows)check-skipped = @github-actions/gates (windows)main-pr-required-checks]:check-success = @github-actions/red-firstcheck-neutral = @github-actions/red-firstcheck-skipped = @github-actions/red-firstmain-pr-required-checks]:check-neutral = @mergify/Mergify Merge Protectionscheck-skipped = @mergify/Mergify Merge Protectionscheck-success = @mergify/Mergify Merge Protections