Repository navigation
fix: preserve question history and legacy attribution (KR-06b-1) - #1896
Merged
Merged
Conversation
Replace obsolete local-stream assertions while preserving input unlock and second-answer coverage. Exercise fetched history through the real hook and Tauri boundary. Plan-ID: KR-06b-1 Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows the stored answer rather than the submitted text Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::unlocks for a second answer without fabricating unreadable history Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::loads the latest 50 persisted questions on fetch and remount Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::preserves closed status attribution timestamps and stored context Co-authored-by: GPT-6 Astra <gpt-6-astra@users.noreply.github.com>
Use QuestionsState.history without a second cap or success-text store. Preserve closed status, recorded answerer and time, and stable stored project and worker IDs with honest missing-data fallbacks. Plan-ID: KR-06b-1 Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::shows the stored answer rather than the submitted text Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::unlocks for a second answer without fabricating unreadable history Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::loads the latest 50 persisted questions on fetch and remount Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::preserves closed status attribution timestamps and stored context Co-authored-by: GPT-6 Astra <gpt-6-astra@users.noreply.github.com>
Cover answered records with null attribution through NeedsYou and real useQuestions. Correct the mixed-history expectation while retaining expired and refused assertions. Plan-ID: KR-06b-1 Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::labels legacy answered questions without attribution as unknown origin Co-authored-by: GPT-6 Astra <gpt-6-astra@users.noreply.github.com>
Use the local history copy for answered records whose attribution was not stored. Keep nobody attribution for expired and refused records. Plan-ID: KR-06b-1 Test-First: src/screens/leitstand/needs/NeedsYou.test.tsx::labels legacy answered questions without attribution as unknown origin Co-authored-by: GPT-6 Astra <gpt-6-astra@users.noreply.github.com>
Owner
Author
Root acceptance check (2026-10-25 ~01:53Z) — head 72f0652
|
Cuarroc
marked this pull request as ready for review
October 25, 2026 01:52
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
30 of 46 tasks
Contributor
Merge Queue Status
This pull request spent 10 minutes 53 seconds in the queue, including 10 minutes 13 seconds running CI. Required conditions to merge
|
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Der Fragenverlauf zeigt gespeicherte Einträge und kennzeichnet fehlende Herkunft korrekt.
Dieser Entwurf ersetzt #1893 und enthält den geprüften Verlauf mit der C1-Korrektur.
Die zusätzliche Bestätigung einer gerade gespeicherten Antwort folgt in KR-06b-1b.
Report
Plan-ID: KR-06b-1
Child ticket: 50b01db1-881f-4919-9901-0a4faa8ac5cb
Parent: b5998181-4fc9-4637-9783-1903d16a4a46 (OPEN)
Supersedes #1893. This replacement branch points directly to the existing reviewed C1 commit
72f0652897e200e9cab6b6b288c1e6ad194d6454; no new source commit, cherry-pick, revert, rebase or history rewrite was made. The originalcodex/kr-06b-questionsbranch retains22a13980and its C2 history. PR base is main; original merge-base is60aa6ac17afb89cc5f88e220db1f9bf7dbb7d7fb.Change and bounded delivery
Replace the local 20-line success-text stream with fetched
QuestionsState.history, preserving the existing frontend hook's 50-record cap, fresh fetch/remount, question, stored answer, closed status, actual attribution/time and stable stored project/worker context. There is no second store/poller or backend change.C1 distinguishes legacy answered records with
answeredBy=null:Herkunft nicht gespeichert. Expired/refused null-attribution records retainniemand hat entschieden; human/unverified labels remain. The compiling legacy regression preceded the correction (75ab90b6then72f06528). Existing input-unlock/second-answer, Enter/Escape, options, errors, lanes and honest loading/empty cases are retained. Tests exercise real NeedsYou/useQuestions/IPC normalization with only Tauri boundaries mocked.Actual original-base diff: 138 added + 45 deleted = 183 RAW lines, four files inside
needs/. C1 delta from initial revieweded835cdcis 14 added + 2 deleted = 16 RAW lines, three files. No native seam, hook, gate, dependency, style, route, IPC, PLAN or scope change. Fleet/scope/lifetime remain KR-06b-2; parent acceptance remains open.Root split and review disposition
Root's round-two decision accepted C1 and split C2 after the last review round. Additive reverts cannot satisfy the unchanged red-first gate: they retain C2 Test-First trailers while removing the named tests. Root explicitly authorized this replacement from the already reviewed C1 commit, retaining the old branch/history. No gate exception or bypass was used.
72f06528after RED75ab90b6; round-two reviewer explicitly confirmed the C1 correctionipc.ts:2038-2040normalizes createdAt, answeredAt and answeredBy before this component; no new malformed-input policyReview binding remains Root's original two-family disposition on
ed835cdcplus the round-two non-author delta reviewer, observed by Root asclaude-opus-5-5[1m](Anthropic), explicitly confirming C1. The replacement contains onlyed835cdc..72f06528, a subset of that reviewed delta. No additional review/model/E1 measurement is claimed. Root checks this binding and alone sets ready/review-ok/Mergify; this handover is DRAFT, not self-acceptance.Evidence
Original author: OpenAI
gpt-6-astra/high, native job162 turn_context observed before source edits. This coordinator replacement introduces no new source commit or implementation author.ed835cdc; initial exact test commit1a17616372f06528; author job162 receipt72f06528; preserved log ends withed835cdc..72f06528normal push receiptbash scripts/ci/red-first.shin replacement worktree72f06528; only initial/C1 evidence remains, all candidate obligations greengit push -u origin codex/kr-06b-1-historyand mandatory prepush hookgit ls-remote origin refs/heads/codex/kr-06b-1-history72f0652897e200e9cab6b6b288c1e6ad194d645472f06528, clean; C2 commits are not ancestors of this branch; old branch remains at22a13980Fresh resource guards and each heavy phase were chained in the same shell command (
guard && phase), preserving load/RAM/build-slot limits and hook exit codes. Existing dependencies and a warm assigned build target were reused; no dependency install/change or extra agent/reviewer/QA/service was started. Architecture/gates remain unchanged.One initial normal-push attempt was interrupted by the SSH observation limit and SIGHUP during the already-compiled Rust suite. It did not publish the branch and is not passing evidence. After checking process termination, unchanged source and absent remote ref, one fresh guarded retry used the warmed build artifacts and completed the full normal hook successfully. No test retry/timeout/skip setting, gate or hook was changed; only the completed final run is counted above.
NICHT ABGEDECKT
Beantwortet: …history row remains; the rejected C2 implementation and tests are absent from this candidate.#[cfg(windows)]tests or Windows clippy branches. Root owns Windows evidence through the Mergify queue; ordinary PR checks are not that verdict.Handover
One C1-only DRAFT replaces #1893. Root verifies the reviewed subset and owns final acceptance, ready/review-ok and Mergify. KR-06b-1b and KR-06b-2 remain blocked on the replacement's actual merge; no follow-on implementation is started by this handover. Installed/effective state is unproven.