docs(design): DS-X-22 builder guide and voice - #1699
Merged
Merged
Conversation
…orted" headers Add docs/design/BUILDING.md and docs/design/voice.md, remove the header comment lines that claim the design stylesheets are not imported (all are), and add the DS-X-22 row to docs/PLAN.md. No-Test: docs and comment-only change Plan-ID: DS-X-22 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Cuarroc
marked this pull request as ready for review
October 17, 2026 05:39
Cuarroc
added
the
review-ok
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
@Mergifyio queue |
Owner
Author
|
Root auto-queue: head 7d9d80d unchanged since review-ok, all checks green. @Mergifyio queue |
30 of 46 tasks
Contributor
Merge Queue Status
This pull request spent 13 minutes 19 seconds in the queue, including 12 minutes 39 seconds running CI. Required conditions to merge
|
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neu gibt es eine kurze Bauanleitung für das Designsystem (
docs/design/BUILDING.md) und die acht Sprachregeln für deutsche Texte (docs/design/voice.md). Außerdem sind die veralteten Kopfzeilen entfernt, die behaupteten, die Design-Stylesheets würden von der App nicht eingebunden. Es ändert sich kein Code und keine CSS-Regel, nur Dokumente und Kommentare.Plan-ID: DS-X-22
Report
Änderung (Stufe C, nur Doku und Kommentare)
docs/design/BUILDING.md(neu): Baustein je Aufgabe (src/design/registry.ts, Galerie#/designsystem), nur Token, Texte übersrc/i18n/de.ts, Zustandswörter aussrc/design/state/states.ts, Bewegungsregeln (reduzierte Bewegung gewinnt immer), „Muster kopieren, nicht installieren“, Verweis auf die Lizenzliste (scripts/lib/license-check.mjs).docs/design/voice.md(neu): die acht Regeln aus dem Design-Polish-Bericht §10, mit deutschen Beispielen.docs/PLAN.md: eine Zeile DS-X-22 nach DS-X-14b, sonst keine Zeile berührt.grep -rn "Not imported" src/design: 9 Treffer statt der geschätzten 23; jede Datei wird von der App importiert, geprüft pergrepaufimport/@importin Nicht-Test-Dateien, z. B.src/shell/Shell.tsx:5-9):src/design/tokens.css:1,glass.css:1,controls/controls.css:1,inputs/inputs.css:1,layout/layout.css:1,forms/forms.css:1,variants/variants.css:1(Satzteil ersetzt durch Verweis aufuseGlassVariant.ts, weil der Schalter existiert),state/state.css:3,data/data.css:1-2//-Kommentar insrc/design/state/states.ts:4-5(vongrep "Not imported"wegen Zeilenumbruch nicht gefunden)Belege
node scripts/plan-check.mjs --offline→ Exit 0 (0 Befunde)grep -rn "Not imported" src/design→ keine Treffer (grep Exit 1)npx vitest run src/design src/i18n→ Exit 0 (44 Dateien, 234 Tests)bash scripts/ci/secret-scan.sh→ Exit 0bash scripts/ci/gates.sh lane prepush→ Exit 0 (ungefiltert in Datei, Exit-Code direkt gelesen); der Pre-push-Hook lief dieselbe Bahn beim Push erneut, Exit 0git ls-remote origin claude/ds-x-22→7d9d80d5Red test: keiner, reine Doku und Kommentare (Commit-Trailer
No-Test: docs and comment-only change).Architecture drift: keine Befunde.
NICHT ABGEDECKT
#[cfg(windows)]-Tests und Windows-Arme von clippy laufen nicht auf Linux; die Windows-Bahn kommt aus der Merge-Queue.linux(CI), nicht inprepush.scripts/contrast-check.mjs:2-3;AGENTS.md/Skill-Verweis auf BUILDING.md fügt Root hinzu.Review: ausstehend (Stufe C: die Gates genügen), Root kommissioniert.
🤖 Generated with Claude Code on the ProjectA server worker
Root acceptance (head 7d9d80d)
Tier C (docs + comment lines only, no runtime effect): gates suffice, no external review required (AGENTS.md rule 5). Root checked at head 7d9d80d:
src/change is a comment line (git diff origin/main...7d9d80d5 -- src/: 10 files, only/* */and//text); no CSS rule and no code changed;variants/useGlassVariant.tsexists; every path named indocs/design/BUILDING.mdexists at the head;git ls-remote= 7d9d80d).Follow-up (Root): add the
docs/design/BUILDING.mdpointer to AGENTS.md/skill after merge; stale "imported by the app" wording inscripts/contrast-check.mjs:2-3noted, not in scope.Decision: accept. Bound to head 7d9d80d; a later push voids it.