Repository navigation
ci: exact-match gitleaks exception for the synthetic typed-review fixture - #1773
Merged
Merged
Conversation
Extract the confirmed exception from agent-harness#1770 so full-history scrub checks for agent-harness#1763, agent-harness#1764, agent-harness#1744, and agent-harness#1762 use the main-targeted configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Anchor the exception to an exact full-secret match per review for agent-harness#1770, agent-harness#1763, agent-harness#1764, agent-harness#1744, and agent-harness#1762. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ViperJuice
marked this pull request as ready for review
October 20, 2026 05:54
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
gitleaksjob in.github/workflows/scrub.ymlchecks out withfetch-depth: 0, so it scans every branch and tag. It always loads.gitleaks.tomlfrom the checked-out tree. A synthetic test-vector digest on the branch for #1770 tripsgeneric-api-key. That PR already allowlists the value, but only in its own config. Scans running from any other checkout still use main's config, which has no exception. That is why agent-harness#1763, agent-harness#1764, agent-harness#1744 and agent-harness#1762 all fail on the same finding: commitbbb3bb8b,phase-loop-runtime/tests/data/typed_review_contract_vectors.json:67.The value is a SHA-256 digest computed from a test-only identifier. A Daybreak review independently recomputed it and confirmed it is not a credential.
What
.gitleaks.toml: one allowlist regex, the exception from37be3360(agent-harness#1770). It is anchored with\A…\zso it must match the whole extracted secret. Nothing else changes: no path or rule exclusions, no.gitleaksignore, no change to the workflow or to what gets scanned.CHANGELOG.md: an[Unreleased]entry.The first commit extracted the hunk exactly. Round 1 of the independent review rejected it: the regex was unanchored, so tokens with the value embedded inside them were also suppressed. The second commit adds the anchors and corrects the CHANGELOG wording. Both commits are kept.
Verification
scrub.yml, over the full fetched history.generic-api-key,github-fine-grained-pat,github-pat,aws-access-token,slack-bot-token,gitlab-pat) produce the same findings under both configs.make checkandgit diff --checkpass.Follow-ups
agent-harness#1770, agent-harness#1740 and agent-harness#1733 carry the same exception without anchors. Their owners have been told not to merge that version and to drop or replace it when they merge main.
Draft. A maintainer decides when to merge.
🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.