Skip to content

Implement BAML typed-review contracts and governed intake - #1770

Draft
ViperJuice wants to merge 16 commits into
mainfrom
codex/typed-review-spec-20261019
Draft

ViperJuice wants to merge 16 commits into
mainfrom
codex/typed-review-spec-20261019

Conversation

@ViperJuice

@ViperJuice ViperJuice commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Current RT3 checkpoint — draft, repository verification FAILED/open. Integration head: bf1a4a0303c8d6f2414b87a0b81b52efab66e9e0. This update supersedes the earlier RT3 pending-work statements retained below; historical RCONTRACT results remain scoped to their recorded heads.

The local T3 bridge now includes durable request/prepare/register/intake/resume/correction handling, original task/thread/run binding, bounded terminal-text recovery, fault and standalone CLI conformance, and host documentation. The supported profile remains HOST_ATTESTED/NON_GATING with a pre-bound shared checkout: Python emits host-action data and does not dispatch providers. Unknown launch outcomes remain unresolved. The checkpoint also includes reviewed test-portability and bounded finalizer compatibility changes. It does not qualify governed admission or live routes.

Integrated implementation at be9edf64fb3e5d06f06ce4fa100b64c5d550b92f has these separate scoped results under Python 3.12:

  • Canonical nine-module RT3 selection: 603 passed.
  • A subsequent, separately authorized full canary-module run with short /tmp placement: 289 passed, four existing skips. The first combined run's three socket-path setup failures remain recorded; these runs are not a synthetic aggregate suite pass.
  • Pinned Ruff 0.15.5, entry docs, canonical plan/manifest, two inventory/ancestry guards and docs audit passed. One plan warning about a post-dispatch evidence-reducer lane remains recorded. The four skips retain root-runner and real-uv-launcher coverage limits.

Metadata-only commit bb7a1a889438b9671bfbbc85582c8b970b1909de appends these results to plans/evidence/typed-review/RT3.json and plans/evidence/typed-review/ledger.json; all earlier reports, byte bindings, failed results and review caps remain intact. The two controls passed preservation/JSON checks and canonical manifest validation; post-commit docs audit passed. Reviewed runtime/test bytes are unchanged. This is evidence reduction, not phase acceptance.

Required repository verification remains FAILED/open. Full CI run39371741302 at bb7a1a889438b9671bfbbc85582c8b970b1909de recorded 1 failed, 14723 passed, 661 skipped and 1 xfailed. The failing BAML owner-death late-spawn case failed its healthy-followup assertion; the downstream aggregate jobs propagated that failure. A subsequent isolated instrumented pass does not establish a flake or exclude a lifecycle issue. The supplemental scope review returned material objections; root held the proposed test-budget change. No BAML source/test change or timeout adjustment is included, and review caps remain intact.

Ordinary main integration 8506898493c0c83c80f954701c5799681f740f4f has parents bb7a1a889438b9671bfbbc85582c8b970b1909de and 7b49e86774ccd3bba8ef539b39b585bb9e7b482d. It adopts the accepted main configuration from agent-harness#1773 and preserves CHANGELOG entries; the other 2020 tracked blobs are unchanged. This supersedes the prior configuration-retention statement. Entry docs, docs audit against that main input, and the CHANGELOG whitespace check pass. This integration is not a BAML fix or suite clearance. Any automatic CI on this new head is distinct evidence, not a rerun or erasure of the failed run.

Original make check and verified 282-node failures remain unresolved. Native/helper runtime, namespace and qualified-venue prerequisites, private follow-up obligations and final closeout remain held. Historical remote 8585a9aed728159fd245447ed146918cdb132c99 success applies only to that checkpoint. RT3 EC/IF completion is not claimed; RPANEL and RENFORCE remain incomplete. Root owns monitoring and subsequent disposition. Keep this PR draft: no ready, merge, release or activation authority. Existing dependencies/exclusions below, including agent-harness#1443 and agent-harness#1744, remain in force.
Latest ordinary integration 4612bd5c6679486a4dd91dfa5dd4ca041c37878a adds main 66ad918832bab0df0a2a54d521d71deae17acbee to prior checkpoint 8506898493c0c83c80f954701c5799681f740f4f. The only conflict was CHANGELOG; both sides were retained. All 14 other changed blobs exactly match upstream skill/bundle/size-gate changes; reviewed RT3 source/tests/plans/evidence and accepted scanner configuration are unchanged. Bounded integration checks: 20 tests passed with seven existing size-guidance warnings; entry docs, docs audit and diff checks passed.

Historical hosted run39378869235 at 8506898493c0c83c80f954701c5799681f740f4f completed successfully (pytest, hosted fallback and suite gate); scrub39378869451 also passed. That separate success does not erase failed39371741302 or resolve its BAML cause. It is not new-head proof. Current-head automatic PR CI and one separately authorized test.yml dispatch with chronology=false for the upstream skills integration provide new, separately bound evidence; results are pending. All local/native/runtime, review, phase/governance and private follow-up holds above remain open. This is narrow integration/publication acceptance only, not phase or final implementation acceptance.
Current local-integration checkpoint bf1a4a0303c8d6f2414b87a0b81b52efab66e9e0 merges main 3f6a96a27d06735123d31e05592dcc5d0378bc05 into 4612bd5c6679486a4dd91dfa5dd4ca041c37878a. README and CHANGELOG retain both RT3 and incoming offline-producer sections. Automatic CLI/inventory integration was checked as the exact union; other changes preserve incoming main and reviewed RT3 blobs outside that delta.

Three separately bounded offline checks passed once on this head: fleet map 14, artifact 116, and the exact inventory AST guard 1. Entry docs, docs audit and diff checks passed. The earlier combined selection timed out at its 120-second aggregate runner limit with partial buffered output lost; that remains inconclusive, with no proven cause and no claim of full CLI or current full-suite success. A historical pre-merge inventory capture failed before the merge began. That retrospective evidence gap remains explicit; verified fresh inventories establish preservation only from the stopped-state recovery baseline forward.

Historical exact-head dispatch39540643883 at 4612bd5c6679486a4dd91dfa5dd4ca041c37878a completed successfully, separate from that head's successful PR checks. Neither is proof for this new head. New automatic PR checks and one separately authorized test.yml / chronology=false Gate A dispatch are new evidence whose results remain pending. All original local failures, native/helper/namespace/venue requirements, private follow-ups, BAML scope objections/budget hold and phase/governance requirements remain open. No phase, final implementation, readiness or merge acceptance is claimed.

Adds a shared typed-review acceptance boundary for delegated reviewers, panels and presidents. RCONTRACT now sends original review JSON through the declared BAML 0.20.1 worker, checks it against the saved-source schema and actual worker reply, and records coordinator-owned acceptance. It preserves valid dissent, separates host provenance from governed eligibility, and durably limits each lineage to one correction across restarts.

The implementation includes immutable source/request bindings, canonical request and receipt vectors, replay of saved BAML maps, atomic duplicate/conflicting delivery handling, metadata-only rejection records, and private original content. Worker snapshot replacement reaps the retiring process before starting another. The callable API and host responsibilities are documented in docs/phase-loop/typed-review-contract.md; exact EC-RCONTRACT-1/2/3 and IF-0-RCONTRACT-1/2 evidence is in plans/evidence/typed-review/RCONTRACT.json.

Validation on the committed implementation: sealed phase suite 670 passed, 194 skipped, 1 xfailed; make check passed lint and 843 tests, with 157 skipped and 1 xfailed. Each suite retained six supervisor teardown thread warnings. Entry docs, docs freshness and closeout audits passed. The initial committed-history docs audit failure and generated-toolchain audit failures remain recorded with their resolutions. Planning review reached COMPLETE / AGREE in round 2; independent implementation review reached COMPLETE / AGREE in round 3. Those are manual review records, not BAML-accepted or landing-ratification evidence. The reviewer-proposed nonblocking envelope-cap adjustment was implemented afterward and covered by final sealed verification.

This remains a draft: RT3 fault conformance and final review/verification, RPANEL integration and RENFORCE consumer enforcement/live-route qualification are pending. The proposal inputs and their non-unanimous design-review history remain unchanged, and v11 remains the selected governing roadmap. No merge, release, production activation or live-route qualification is claimed. Recheck agent-harness#1443 ownership before panel work; agent-harness#1744 remains outside scope.
The required scrub check flagged a deterministic synthetic canonical-vector digest. Daybreak independently recomputed it and added one exact-value exception; the pinned v8.21.2 scan passes with zero findings and all runtime/test-vector hashes remain unchanged. GitHub gitleaks passed on the preceding head; the corrected head requires fresh CI results.
The full GitHub suite on 37be3360 failed two repository guards (14,344 passed, 662 skipped, 1 xfailed): noncanonical plan registration and one unclassified coordinator file-open reference. The repair uses the existing canonical filename grammar, preserves review records and manifest history, and adds the exact host-io classification without changing runtime code or guard assertions. Both failures were reproduced. The same affected test selection passes under Python 3.12: 38 passed, 1 skipped; the prior local Python 3.14 environment failure is retained. Canonical manifest coverage is 48/48; lint and docs checks pass. Independent scoped repair review is COMPLETE / AGREE, with no blockers.

RCONTRACT's corrected-head prerequisite is satisfied at 6b2b2d3f: GitHub run39332069820 completed with actual pytest and suite-gate success. The earlier failed run remains preserved.

RT3 SL-0 is implemented at 8585a9aed728159fd245447ed146918cdb132c99: durable local service and CLI emit private host-action data, bind original task/thread/run identity, recover exact terminal bytes and consume coordinator acceptance. The supported profile is HOST_ATTESTED/NON_GATING with a pre-bound shared checkout; unknown launches remain unresolved. Python performs no provider dispatch, and synthetic host tests do not qualify live routes. Focused adapter tests: 38 passed; an earlier regression run: 133 passed. Parent inventory/manifest guards: 2 passed. SL-1 fault/CLI conformance and documentation are running. Independent implementation review and final sealed verification remain pending; no full-phase or new-head CI success is claimed.

The reviewed canonical plan is plans/phase-plan-v1-typed-review-RT3.md. RPANEL reconnaissance is recorded without implementation or live qualification. Root owns PR monitoring; this PR stays draft with no ready/merge authority.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Local recovery checkpoint only. RT3 repository verification remains FAILED
and external prerequisites remain open; no EC/IF completion or readiness.
Preserve historical review and verification bindings. Publication withheld.
Retain all typed-review and upstream publication changelog blocks.
README combines disjoint documentation changes; reviewed RT3 source/test
bytes and historical evidence are preserved.

RT3 remains FAILED/open. No EC/IF completion, verification waiver,
publication, PR merge or activation. Root retains subsequent disposition.
Append scoped verification evidence without replacing historical failures
or review bindings. Repository verification remains FAILED/open, with no
EC/IF completion. Retain draft-only posture and pending published-head CI.
@ViperJuice

Copy link
Copy Markdown
Collaborator Author

Mechanical main integration published for agent-harness#1770 at d429ac05684ae2c6c66613d086669098e811ce66, merging main 20222e1d1c13c31df779b5f2d27a4916ef3c0515. CHANGELOG was the only conflict; both complete sections were retained. Other merges and parent inventory unions were checked. Historical evidence remains preserved.

Local offline controls: inventory 1, evaluator 19, wheel-schema 3 passed; documentation and whitespace checks passed.

Draft status and all substantive review, qualification and governance holds remain. Earlier CI/review results retain their original head bindings; this update is not source acceptance, live qualification or merge approval. No manual CI dispatch or further source repair was performed by this publication.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant