Repository navigation
fix(web): thread details slides in on close - #21
Open
Claudesaul wants to merge 2 commits into
Open
Claudesaul wants to merge 2 commits into
Claudesaul wants to merge 2 commits into
Conversation
Closing the right panel swapped the header's toggle for the title bar's one, so it jumped across the window on the first frame. It now slides from where the header's toggle sat, on the panel's own curve and duration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closing the right panel makes the thread details button jump about 475px across the window on the first frame, while the panel edge is still far away. Opening doesn't do this: the button rides the edge of the chat.
Change
The chat header and the window's top right each have their own copy of this button, and closing swaps one for the other. The top right one now starts where the header's sat and slides into its slot, on the panel's own timing, so it travels with the closing edge.
Scope and approval
Small fix for an obvious jump. What the button does hasn't changed.
Verification
vp test run apps/web/src/components/chat(598 passed); web typecheck and lint clean.Recording: a few opens and closes at regular speed, then one close and open zoomed in at quarter speed. Both sides include the panel fix from pingdotgg#28922, so only this change differs.
Model: Claude Opus 5.5; harness: T3 Code.